From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>,
Takashi Iwai <tiwai@suse.com>
Subject: Re: [PATCH 1/2] ALSA: pcm: Add support for 705.6KHz and 768KHz sample rate
Date: Tue, 27 Apr 2021 19:12:33 +0800 [thread overview]
Message-ID: <CAA+D8ANB1CZ41Qz6HK2uxT6QjHV3zfL0ayT59oYExX8h5ccW6Q@mail.gmail.com> (raw)
In-Reply-To: <s5hpmygyp2x.wl-tiwai@suse.de>
On Tue, Apr 27, 2021 at 6:56 PM Takashi Iwai <tiwai@suse.de> wrote:
>
> On Tue, 27 Apr 2021 12:34:22 +0200,
> Shengjiu Wang wrote:
> >
> > Some high resolution codecs support 705.6KHz and 768KHz rates.
> > So extend supported sample rate to 768kHz in pcm.h.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
>
> How many devices require it for now?
I have two devices, AK4458, AK5558.
>
> I don't want to extend the core definitions blindly unless those rates
> are really commonly used. You can add those specific rates in the
> codec driver instead.
Ok, this is an option.
>
>
> thanks,
>
> Takashi
>
> > ---
> > include/sound/pcm.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/include/sound/pcm.h b/include/sound/pcm.h
> > index 2e1200d17d0c..88056824ffec 100644
> > --- a/include/sound/pcm.h
> > +++ b/include/sound/pcm.h
> > @@ -121,6 +121,8 @@ struct snd_pcm_ops {
> > #define SNDRV_PCM_RATE_192000 (1<<12) /* 192000Hz */
> > #define SNDRV_PCM_RATE_352800 (1<<13) /* 352800Hz */
> > #define SNDRV_PCM_RATE_384000 (1<<14) /* 384000Hz */
> > +#define SNDRV_PCM_RATE_705600 (1<<15) /* 705600Hz */
> > +#define SNDRV_PCM_RATE_768000 (1<<16) /* 768000Hz */
> >
> > #define SNDRV_PCM_RATE_CONTINUOUS (1<<30) /* continuous range */
> > #define SNDRV_PCM_RATE_KNOT (1<<31) /* supports more non-continuos rates */
> > @@ -136,6 +138,9 @@ struct snd_pcm_ops {
> > #define SNDRV_PCM_RATE_8000_384000 (SNDRV_PCM_RATE_8000_192000|\
> > SNDRV_PCM_RATE_352800|\
> > SNDRV_PCM_RATE_384000)
> > +#define SNDRV_PCM_RATE_8000_768000 (SNDRV_PCM_RATE_8000_768000|\
> > + SNDRV_PCM_RATE_705600|\
> > + SNDRV_PCM_RATE_768000)
> > #define _SNDRV_PCM_FMTBIT(fmt) (1ULL << (__force int)SNDRV_PCM_FORMAT_##fmt)
> > #define SNDRV_PCM_FMTBIT_S8 _SNDRV_PCM_FMTBIT(S8)
> > #define SNDRV_PCM_FMTBIT_U8 _SNDRV_PCM_FMTBIT(U8)
> > --
> > 2.27.0
> >
prev parent reply other threads:[~2021-04-27 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 10:34 [PATCH 1/2] ALSA: pcm: Add support for 705.6KHz and 768KHz sample rate Shengjiu Wang
2021-04-27 10:34 ` [PATCH 2/2] ALSA: pcm: Extend the constraint table for 705.6kHz and 768KHz rate Shengjiu Wang
2021-04-27 10:55 ` [PATCH 1/2] ALSA: pcm: Add support for 705.6KHz and 768KHz sample rate Takashi Iwai
2021-04-27 11:12 ` Shengjiu Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA+D8ANB1CZ41Qz6HK2uxT6QjHV3zfL0ayT59oYExX8h5ccW6Q@mail.gmail.com \
--to=shengjiu.wang@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).