From: Shengjiu Wang <shengjiu.wang@gmail.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Shengjiu Wang <shengjiu.wang@nxp.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Takashi Iwai <tiwai@suse.com>,
ranjani.sridharan@linux.intel.com,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap
Date: Thu, 16 Jul 2020 12:49:02 +0800 [thread overview]
Message-ID: <CAA+D8ANH082mozu+SSsQShAzpfF8=vm_tgyPe0gERb4JsJ-sqw@mail.gmail.com> (raw)
In-Reply-To: <87sgds2ixs.wl-kuninori.morimoto.gx@renesas.com>
On Thu, Jul 16, 2020 at 12:19 PM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
>
>
> Hi Shengjiu
>
> > Add missed return for snd_soc_pcm_component_mmap, otherwise it always
> > return -EINVAL.
> >
> > Fixes: e2329eeba45f ("ASoC: soc-component: add soc_component_err()")
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
> > ---
>
> Oops, indeed.
> Thank you for the patch.
>
> But it seems these functions are also missing "return"
> snd_soc_pcm_component_new()
> snd_soc_pcm_component_sync_stop()
>
> Can you please care these, too ?
Ok, will send v2
best regards
wang shengjiu
prev parent reply other threads:[~2020-07-16 4:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 3:52 [PATCH] ASoC: soc-component: Add missed return for snd_soc_pcm_component_mmap Shengjiu Wang
2020-07-16 4:17 ` Kuninori Morimoto
2020-07-16 4:49 ` Shengjiu Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA+D8ANH082mozu+SSsQShAzpfF8=vm_tgyPe0gERb4JsJ-sqw@mail.gmail.com' \
--to=shengjiu.wang@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjani.sridharan@linux.intel.com \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).