From: Dong Aisheng <dongas86@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
yibin.gong@nxp.com
Subject: Re: [PATCH 2/6] regulator: anatop: only set supply regulator when it actually exists
Date: Thu, 13 Apr 2017 00:00:36 +0800 [thread overview]
Message-ID: <CAA+hA=QG7xwJrX0q3fyTEAHEcwJr-0z0T+MvC2ESDpBGrhQVRA@mail.gmail.com> (raw)
In-Reply-To: <20170412155336.vhhrftqmlxhti36n@sirena.org.uk>
On Wed, Apr 12, 2017 at 11:53 PM, Mark Brown <broonie@kernel.org> wrote:
> On Thu, Apr 13, 2017 at 03:11:01PM +0800, Dong Aisheng wrote:
>
>> You're absolutely right!
>> I did this because there're some where else did the same thing.
>> e.g. drivers/regulator/fixed.c.
>
>> But it's obviously none of any platform specific and is perfectly
>> to be handled in regulator core.
>
> Did my patch solve the problems you were seeing? I just wrote it
> quickly last thing before I finished for the evening.
It can solve the problem.
But it breaks some thing and need a further tiny fix.
I just replied the mail in your patch thread.
Please check it!
Regards
Dong Aisheng
next prev parent reply other threads:[~2017-04-12 16:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-12 1:58 [PATCH 1/6] regulator: anatop: check return value of of_get_regulator_init_data Dong Aisheng
2017-04-11 20:42 ` Applied "regulator: anatop: check return value of of_get_regulator_init_data" to the regulator tree Mark Brown
2017-04-12 1:58 ` [PATCH 2/6] regulator: anatop: only set supply regulator when it actually exists Dong Aisheng
2017-04-11 20:31 ` Mark Brown
2017-04-13 7:11 ` Dong Aisheng
2017-04-12 15:53 ` Mark Brown
2017-04-12 16:00 ` Dong Aisheng [this message]
2017-04-12 16:06 ` Mark Brown
2017-04-12 1:58 ` [PATCH 3/6] regulator: anatop: use of_property_read_string to read the name Dong Aisheng
2017-04-11 20:42 ` Applied "regulator: anatop: use of_property_read_string to read the name" to the regulator tree Mark Brown
2017-04-12 1:58 ` [PATCH 4/6] regulator: anatop: remove unneeded name field of struct anatop_regulator Dong Aisheng
2017-04-11 20:42 ` Applied "regulator: anatop: remove unneeded name field of struct anatop_regulator" to the regulator tree Mark Brown
2017-04-12 1:58 ` [PATCH 5/6] regulator: anatop-regulator: make regulator-name using optionally Dong Aisheng
2017-04-11 20:38 ` Mark Brown
2017-04-13 7:31 ` Dong Aisheng
2017-04-12 1:58 ` [PATCH 6/6] regulator: anatop: set default voltage selector for pcie Dong Aisheng
2017-04-11 20:40 ` Mark Brown
2017-04-13 7:41 ` Dong Aisheng
2017-04-12 15:49 ` Mark Brown
2017-04-12 16:11 ` Dong Aisheng
2017-04-12 16:11 ` Lucas Stach
2017-04-12 16:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA+hA=QG7xwJrX0q3fyTEAHEcwJr-0z0T+MvC2ESDpBGrhQVRA@mail.gmail.com' \
--to=dongas86@gmail.com \
--cc=aisheng.dong@nxp.com \
--cc=broonie@kernel.org \
--cc=kernel@pengutronix.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=yibin.gong@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).