From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F170C4332F for ; Fri, 10 Sep 2021 01:24:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 36F7E61132 for ; Fri, 10 Sep 2021 01:24:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232336AbhIJBZJ (ORCPT ); Thu, 9 Sep 2021 21:25:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235932AbhIJBY5 (ORCPT ); Thu, 9 Sep 2021 21:24:57 -0400 Received: from mail-ot1-x32b.google.com (mail-ot1-x32b.google.com [IPv6:2607:f8b0:4864:20::32b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C929DC0613E0 for ; Thu, 9 Sep 2021 18:23:40 -0700 (PDT) Received: by mail-ot1-x32b.google.com with SMTP id a20-20020a0568300b9400b0051b8ca82dfcso161851otv.3 for ; Thu, 09 Sep 2021 18:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=OAp385IrRyQM0bf2CTn8m6HsT3G2HXxxQxD9bmiIJg4=; b=lXeBnpzgLkHZ7Nnp7RalkiuqX/N3/tdJjiWv7a9ZE7Axa5+ZrA3mAYeZgLrWduclrI Guw2B2fqM+vDktr5tDzNIhkEg4yT6zPys7ac2Sdn00lr0llJYcAY+TDMt2uMWGU1zJJE 3jwZpaUwHphGF5I/gOIPUVz1LIItmTrpAgR86qUhOAjXIGY0QiGzbRgl6s93N8QLrLnD 2wM59yaEtvkBh5kjslfdytuqhnlhrxu79FLJj0zQfLHYyZffKlfq1TNp3pP8K/JUB3k5 3THEZ1kQZ/DPJMWlHjkuRpJq59MFouREYyxoEhXvq6izqXs4YmEcVTTxCyyfkReM6pHT 1TsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OAp385IrRyQM0bf2CTn8m6HsT3G2HXxxQxD9bmiIJg4=; b=Eco3njxodrgx7IIEUWKObgQ2t3Y2Rggt6FHECnw/iEQbD5SrBhCvd4DXKYN1ILcV4/ rLRrMpQ/S5RMXcooqq9cixG4NCG3xpv0YYngpqVkHa0qd7R61yy46dh0Y1YgP+I9I+Lg 0D5q+l58wF5o9mYcNleIJ/YPhoaZ/cMpnckgw6Oea+13ISOEk+MlMzxfmCtrc8WAjhlY VNzKvs/X5SdGfLgKrlf3IiNXUy8u1+sX2ZcFA4k6Fxyv37rRRss2UN7jEFM1fG4PdkK0 8+JC8iE2PgDBFHTy2z2gISEOd3v63FYfassvUgF8DXC6CPgxpPU6JPdtZxRdQbqKw6If QCFg== X-Gm-Message-State: AOAM5303fjByLe7Mnm8euYjrrHSV6wUmYV/Qqv+PXjtHQypxq5IttlXu LCGUv9uvE4/NKcHfYmqDy4DwqodpSLEjc7XeMrEMFw== X-Google-Smtp-Source: ABdhPJwlQyQUySxRUao6VzWG+GD3ZmsaRhSPVis3onD/48fp6HP6gL6VypDF0fexa+FZ27z2U9sJ/GBqmg5vlkEXAfA= X-Received: by 2002:a05:6830:349c:: with SMTP id c28mr2502271otu.35.1631237019961; Thu, 09 Sep 2021 18:23:39 -0700 (PDT) MIME-Version: 1.0 References: <20210818053908.1907051-1-mizhang@google.com> <20210818053908.1907051-4-mizhang@google.com> <8421f104-34e8-cc68-1066-be95254af625@amd.com> <48af420f-20e3-719a-cf5c-e651a176e7c2@amd.com> In-Reply-To: From: Marc Orr Date: Thu, 9 Sep 2021 18:23:29 -0700 Message-ID: Subject: Re: [PATCH v2 3/4] KVM: SVM: move sev_bind_asid to psp To: Mingwei Zhang Cc: Brijesh Singh , Sean Christopherson , Paolo Bonzini , Tom Lendacky , John Allen , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm , linux-crypto@vger.kernel.org, LKML , Alper Gun , Borislav Petkov , David Rienjes , Peter Gonda , Vipin Sharma Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 9, 2021 at 6:18 PM Mingwei Zhang wrote: > > > I believe once we are done with it, will have 5 functions that will need > > >=8 arguments. I don't know if its acceptable. > > > > > In addition, having to construct each sev_data_* structure in KVM code > > > is also a pain and consumes a lot of irrelevant lines as well. > > > > > > > Maybe I am missing something, aren't those lines will be moved from KVM > > to PSP driver? > > > > I am in full support for restructuring, but lets look at full set of PSP > > APIs before making the final decision. > > > > thanks > > > > Oh, sorry for the confusion. I think the current feedback I got is > that my restructuring patchset was blocked due to the fact that it is > a partial one. So, if this patchset got checked in, then the psp-sev.h > will have two types of APIs: ones that use sev_data_* structure and > ones that do not. So one of the worries is that this would make the > situation even worse. > > So that's why I am thinking that maybe it is fine to just avoid using > sev_data_* for all PSP functions exposed to KVM? I use the number of > arguments as the justification. But that might not be a good one. > > In anycase, I will not rush into any code change before we reach a consensus. Isn't the first patch in this patch set a straight-forward bug fix :-)? Assuming others agree, I'd suggest to re-send that one out as a single patch on its own, so we can get it merged while the rest of this patch set works its way through the process.