linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christopher Bostic <christopher.lee.bostic@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux@armlinux.org.uk, sre@kernel.org,
	Michael Turquette <mturquette@baylibre.com>,
	geert+renesas@glider.be,
	Open List OF Flattened dev tree bindings 
	<devicetree@vger.kernel.org>,
	"Moderated list: ARM PORT" <linux-arm-kernel@lists.infradead.org>,
	Jeremy Kerr <jk@ozlabs.org>, Joel Stanley <joel@jms.id.au>,
	Linux open list <linux-kernel@vger.kernel.org>,
	Andrew Jeffery <andrew@aj.id.au>,
	Alistair Popple <alistair@popple.id.au>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Chris Bostic <cbostic@us.ibm.com>
Subject: Re: [PATCH 04/16] drivers/fsi: Add fsi master definition
Date: Thu, 8 Dec 2016 16:49:06 -0600	[thread overview]
Message-ID: <CAA0LjjUOuQXW_pJ0yM=vtKKS09Y-oALUvhF9KPDzx0GF+Xkmew@mail.gmail.com> (raw)
In-Reply-To: <20161207090610.GB14742@kroah.com>

On Wed, Dec 7, 2016 at 3:06 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Tue, Dec 06, 2016 at 08:09:30PM -0600, Chris Bostic wrote:
>> From: Jeremy Kerr <jk@ozlabs.org>
>>
>> Signed-off-by: Jeremy Kerr <jk@ozlabs.org>
>> Signed-off-by: Chris Bostic <cbostic@us.ibm.com>
>> ---
>>  drivers/fsi/fsi-core.c   | 20 ++++++++++++++++++++
>>  drivers/fsi/fsi-master.h | 37 +++++++++++++++++++++++++++++++++++++
>>  2 files changed, 57 insertions(+)
>>  create mode 100644 drivers/fsi/fsi-master.h
>>
>> diff --git a/drivers/fsi/fsi-core.c b/drivers/fsi/fsi-core.c
>> index 3d55bd5..ce9428d 100644
>> --- a/drivers/fsi/fsi-core.c
>> +++ b/drivers/fsi/fsi-core.c
>> @@ -17,6 +17,26 @@
>>  #include <linux/fsi.h>
>>  #include <linux/module.h>
>>
>> +#include "fsi-master.h"
>> +
>> +static atomic_t master_idx = ATOMIC_INIT(-1);
>
> You don't really want/need an atomic variable, please use the simple ida
> interface instead.

Greg,

Will make the change to simple ida interface.

Thanks for your feedback,
Chris

>
> thanks,
>
> greg k-h

      reply	other threads:[~2016-12-08 22:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07  2:09 [PATCH 04/16] drivers/fsi: Add fsi master definition Chris Bostic
2016-12-07  2:09 ` [PATCH 08/16] drivers/fsi: Add crc4 helpers Chris Bostic
2016-12-07  9:02   ` Greg KH
2016-12-07 23:33     ` Jeremy Kerr
2016-12-08 19:43       ` Christopher Bostic
2016-12-07  2:09 ` [PATCH 09/16] drivers/fsi: Implement slave initialisation Chris Bostic
2016-12-07  2:09 ` [PATCH 11/16] drivers/fsi: Add device read/write/peek functions Chris Bostic
2016-12-07  9:29   ` Greg KH
2016-12-07  2:09 ` [PATCH 12/16] drivers/fsi: Set up links for slave communication Chris Bostic
2016-12-07  9:06 ` [PATCH 04/16] drivers/fsi: Add fsi master definition Greg KH
2016-12-08 22:49   ` Christopher Bostic [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA0LjjUOuQXW_pJ0yM=vtKKS09Y-oALUvhF9KPDzx0GF+Xkmew@mail.gmail.com' \
    --to=christopher.lee.bostic@gmail.com \
    --cc=alistair@popple.id.au \
    --cc=andrew@aj.id.au \
    --cc=benh@kernel.crashing.org \
    --cc=cbostic@us.ibm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=jk@ozlabs.org \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).