From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752044AbbCJJPB (ORCPT ); Tue, 10 Mar 2015 05:15:01 -0400 Received: from mail-oi0-f42.google.com ([209.85.218.42]:38333 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750976AbbCJJOz (ORCPT ); Tue, 10 Mar 2015 05:14:55 -0400 MIME-Version: 1.0 In-Reply-To: <20150310085915.GB16501@mwanda> References: <1425934628-3717-1-git-send-email-lstoakes@gmail.com> <20150310070014.GM10964@mwanda> <20150310085915.GB16501@mwanda> Date: Tue, 10 Mar 2015 09:14:55 +0000 Message-ID: Subject: Re: [PATCH] staging: sm750fb: Fix sparse warning From: Lorenzo Stoakes To: Dan Carpenter Cc: Sudip Mukherjee , teddy.wang@siliconmotion.com, Greg KH , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10 March 2015 at 08:59, Dan Carpenter wrote: > > The patch is: > > [patch] cleanup the type of mmio750 > > silencing a Sparse warning is just a side benifit of using correct > data types. The "one thing per patch" rule also means that you should > fix a whole problem instead of half a thing per patch. > > regards, > dan carpenter > Sure, sorry saw the patch as purely a sparse fixup, will adapt to be an overall mmio750 cleanup and resubmit! Best, -- Lorenzo Stoakes https:/ljs.io