From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D829AC2D0A8 for ; Wed, 23 Sep 2020 16:41:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8D55320791 for ; Wed, 23 Sep 2020 16:41:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OC6bVAwX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726697AbgIWQlK (ORCPT ); Wed, 23 Sep 2020 12:41:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53692 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgIWQlG (ORCPT ); Wed, 23 Sep 2020 12:41:06 -0400 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98134C0613CE for ; Wed, 23 Sep 2020 09:41:06 -0700 (PDT) Received: by mail-io1-xd44.google.com with SMTP id d190so169383iof.3 for ; Wed, 23 Sep 2020 09:41:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Dsh5kVcL0Zz/uaeUu7RBOwQv289afFMLyYlaCd/5qzg=; b=OC6bVAwXdTVVp2Ujo5E2D27IUKBduif4l7gS+lm8rNKZ23HhFjma0l3k6LTHvc05LD wu4wlocPR8bXhJbP5kcs/5Jb0861sIHTD1zzrHmwyVMGkJTg5xdlP1JHoyAluRqMwDSq PMZqHfzEdnP6ZYcLzcmeL6S5MBW983kb7H7Dqf/HxAgrDXYF3Xc+9WM/iOkl/mpRa2ii 4W9hAL2LGD/O5XOSRybSP7auxmHuZT9MX6UrWyKzOK/gJhF3S2zcD6dcKS8NXbvzYhlu UABwVR4RQD/hWU5OCt/AbiNEjwCr5pmhM0QHVprhJtXa8A1Mtmf2cvcURrDCVzDu21yT XIjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Dsh5kVcL0Zz/uaeUu7RBOwQv289afFMLyYlaCd/5qzg=; b=PsrlHm4Ntq3cuEsbMR2de5JfnRBzeE7RYfzOry8Eq9O7qM/6oIWvRa3zXdCD5ygq7i YFKsXNaCxgrseK0zIez7sERGp8tCnQxg3Ub5AOq4Cui1GyMOfcW85TeIo//KKxZihdpP ptN3hv1N1b1BPRc3QnELO24/h6eB6dDACeTzHTvKp6fKNg5kt9mpKNOrgHKA/y5qOGFn A5BDXuOtmwKSlrNQ8o40YGecS4LKKM06xLXgQ9DcGkxMfE0nWNbZAyEseNt2tT4jGIMr cr2SO38DxmaoocLODhNw2NeM2piq+38uV8HX/NohUfYu4MGypHAY7RgkBQPukqZi1mRd tkKA== X-Gm-Message-State: AOAM532vN/yuGFuRCW9hOc7hMUmnbRtHELjpCraKf6o8GvxGsM1th7xq jTV8zFtEpjBHj8sd4/WQGYPFRWZ5gmeaSO1YYo0= X-Google-Smtp-Source: ABdhPJwDDwo+YLGCIxjT3ydOvfjQ8egO8Z64SUNEUKOYFAs4VOAUXFLtQ2WDzgWOnzI1D+2yl7GUoWKyTWEisdb9NY0= X-Received: by 2002:a6b:908:: with SMTP id t8mr320427ioi.124.1600879265871; Wed, 23 Sep 2020 09:41:05 -0700 (PDT) MIME-Version: 1.0 References: <20200916153605.5253-1-ztong0001@gmail.com> <20200922135956.GA23437@lst.de> <20200922164154.GA1894@lst.de> <61E8905E-E3FE-46EB-8283-9B35B4F069E1@gmail.com> <20200923050641.GA14878@lst.de> In-Reply-To: <20200923050641.GA14878@lst.de> From: Tong Zhang Date: Wed, 23 Sep 2020 12:40:55 -0400 Message-ID: Subject: Re: [PATCH] nvme: fix use-after-free during booting To: Christoph Hellwig Cc: Keith Busch , Jens Axboe , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org IMHO, WARN_ON_ONCE() looks ok to me. as long as it won't crash the system or lead to any memory corruption issue. We can talk about the reproducer offline if you are interested. - Tong On Wed, Sep 23, 2020 at 1:06 AM Christoph Hellwig wrote: > > On Tue, Sep 22, 2020 at 04:34:45PM -0400, Tong Zhang wrote: > > Hi Christoph, > > I modified the patch a bit and now it works. > > So you're still hitting the WARN_ON_ONCE? I think we need to fix that > as well, but all the ideas I have will turn into a bigger project, > so I think I'll submit this one to Jens, and then do things > incrementally. > > Can you share your reproducer?