From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753570Ab2LELC6 (ORCPT ); Wed, 5 Dec 2012 06:02:58 -0500 Received: from mail-oa0-f46.google.com ([209.85.219.46]:42750 "EHLO mail-oa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752549Ab2LELC4 (ORCPT ); Wed, 5 Dec 2012 06:02:56 -0500 MIME-Version: 1.0 In-Reply-To: <20121204155434.GE3885@mtj.dyndns.org> References: <1354620834-2953-1-git-send-email-xtfeng@gmail.com> <20121204155434.GE3885@mtj.dyndns.org> Date: Wed, 5 Dec 2012 12:02:56 +0100 Message-ID: Subject: Re: [PATCH 1/2] megaraid: fix BUG_ON() from incorrect use of delayed work From: Daniel Vacek To: Tejun Heo Cc: Xiaotian Feng , linux-kernel@vger.kernel.org, Xiaotian Feng , Neela Syam Kolli , "James E.J. Bottomley" , linux-scsi@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 4, 2012 at 4:54 PM, Tejun Heo wrote: > @@ -5190,7 +5188,7 @@ static void > megasas_aen_polling(struct work_struct *work) > { > struct megasas_aen_event *ev = > - container_of(work, struct megasas_aen_event, hotplug_work); > + container_of(work, struct megasas_aen_event, hotplug_work.work); > struct megasas_instance *instance = ev->instance; > union megasas_evt_class_locale class_locale; > struct Scsi_Host *host; -megasas_aen_polling(struct work_struct *work) +megasas_aen_polling(struct delayed_work *work) Not really sure. Just asking? --nX