From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7F91C4332F for ; Fri, 15 Oct 2021 00:15:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1A6161041 for ; Fri, 15 Oct 2021 00:15:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232653AbhJOASD (ORCPT ); Thu, 14 Oct 2021 20:18:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59938 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230288AbhJOASC (ORCPT ); Thu, 14 Oct 2021 20:18:02 -0400 Received: from mail-qk1-x735.google.com (mail-qk1-x735.google.com [IPv6:2607:f8b0:4864:20::735]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70FE6C061570 for ; Thu, 14 Oct 2021 17:15:56 -0700 (PDT) Received: by mail-qk1-x735.google.com with SMTP id l7so7157798qkk.0 for ; Thu, 14 Oct 2021 17:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=s7GfeS32gI4T5cRoYk29Fyp1Z52NUILY3Xlxh32Z6xs=; b=EZeGtuFzkH8pfPvPiQ9aZxa8E/yfOmG4ICvTAnAZeKbvawjJOAS6han9FQ2hOOXPcQ STHK0u/5AWk+ypYEHZa2BLpEDrWdlEselqXq7vawwTBK9Cz380aliYdgo7znLsMub4Ng t7I1o8INVNl1ytvtaMvaHhGfC9nKEzDTc8ONKlbJia6je4sD82sjkJYswVr3l2sWBvhL gRzBD7/21TROm+5b73pcrPokuNabaNTIKDvhjmirKejQQVjrUgnrjCLN3zfIuPQMJvuO kjBh4TwwzfuGIHJdAGaY8wDwpr9t+QhaT/67Ok9t1V0bkvYAcB/V6i0bSyaA1giiyb3C bmug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=s7GfeS32gI4T5cRoYk29Fyp1Z52NUILY3Xlxh32Z6xs=; b=pdwJNTrcw4xh+ysIs8jfqGCo20flMJB8m1IF228ebQ4/rXkunPe6kBxAE0pP3ARMbw zX5m4UynreKGBRmTXPN48s+mBT2sGRdlswHpgHFvUCl/XcJoaQHJne9G1Ay5MfOFY1ey do8MLie2shLpPMG1W6Hcp/d09ZPveWGvcoaoff8S4lEzC3c5v/DDB0vqsatwJ0oItLa6 x515WSHsIA4nsKiZ6FfMWbFvp9UhCtAV7l0Xrad1+XPCX0J9dzJkbR3bmD0o2R0yns4K /6LJBYAfelEhlrrzsFVfXGMevWpnFgiVEUfRvyVq0GU3vkrFzMQignuRbMzVtgGYsYaL EdJw== X-Gm-Message-State: AOAM530/ry4+6QjpJdlmP/QIN/tlsjeOgufjeoRnqQyhaejJ+P478m+D 7pSXVn2d1mcJwkgMOOLGpJFU8h6De4QnO64sGAzGTQ== X-Google-Smtp-Source: ABdhPJy04v77K/HBfyt6r1eUBHzQbcFSDZXxVl24akkIgkNKxr+9V8PP31Kr16nzAYOFxrxe56KwiPOPsHmYaOhUMLM= X-Received: by 2002:a37:4658:: with SMTP id t85mr7370061qka.195.1634256955634; Thu, 14 Oct 2021 17:15:55 -0700 (PDT) MIME-Version: 1.0 References: <20210829154757.784699-1-dmitry.baryshkov@linaro.org> <20210829154757.784699-8-dmitry.baryshkov@linaro.org> <4614587c-b87a-4375-cb6a-6af6f5462c6b@linaro.org> <163415465484.936110.9292145029740247591@swboyd.mtv.corp.google.com> <070b1b25-3718-5f3a-869b-a3954fdcc7c5@linaro.org> <163425629248.1688384.14367506222343416862@swboyd.mtv.corp.google.com> In-Reply-To: <163425629248.1688384.14367506222343416862@swboyd.mtv.corp.google.com> From: Dmitry Baryshkov Date: Fri, 15 Oct 2021 03:15:39 +0300 Message-ID: Subject: Re: [PATCH v7 7/8] clk: qcom: dispcc-sm8250: stop using mmcx regulator To: Stephen Boyd Cc: Bjorn Andersson , Andy Gross , Rob Herring , Taniya Das , Jonathan Marek , Michael Turquette , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "open list:COMMON CLK FRAMEWORK" , "Bryan O'Donoghue" , Mark Brown , Ulf Hansson , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 15 Oct 2021 at 03:04, Stephen Boyd wrote: > > Quoting Dmitry Baryshkov (2021-10-14 02:53:41) > > On 13/10/2021 22:50, Stephen Boyd wrote: > > > Quoting Dmitry Baryshkov (2021-10-07 09:16:13) > > >> On 07/10/2021 18:48, Bjorn Andersson wrote: > > >>> On Sun 29 Aug 08:47 PDT 2021, Dmitry Baryshkov wrote: > > >>> > > >>>> Now as the common qcom clock controller code has been taught about power > > >>>> domains, stop mentioning mmcx supply as a way to power up the clock > > >>>> controller's gdsc. > > >>>> > > >>>> Signed-off-by: Dmitry Baryshkov > > >>>> Reviewed-by: Bjorn Andersson > > >>> > > >>> Once we merge these, I expect that the boards will start crashing if > > >>> the kernel is booted using an existing DTB? > > >>> > > >>> Is it okay to just merge the first 6 patches in the series now and > > >>> postpone these two until we've had the dts change sitting for a while? > > >> > > >> Sure it is. > > >> > > > > > > What's the merge strategy? It goes through arm-soc? > > > > I think this should go through the clk tree. There is little chance of > > conflicts. > > > > The other thing that concerns me is that we don't have backwards > compat code. If things are going to start crashing that's not very nice. > Is there some way to make it work with old and new DTB for one release > so that we don't have to worry about this problem? I have to admit that I did not check that, but without the patch 7 the dispcc and videocc would be compatible with the old DTB. The 'supply = "mmcx"' would ensure that it is used if it is defined. -- With best wishes Dmitry