From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91C0FC433F5 for ; Fri, 22 Apr 2022 10:42:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1446809AbiDVKpZ (ORCPT ); Fri, 22 Apr 2022 06:45:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1446805AbiDVKpQ (ORCPT ); Fri, 22 Apr 2022 06:45:16 -0400 Received: from mail-yw1-x1136.google.com (mail-yw1-x1136.google.com [IPv6:2607:f8b0:4864:20::1136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 071DF25E6 for ; Fri, 22 Apr 2022 03:42:23 -0700 (PDT) Received: by mail-yw1-x1136.google.com with SMTP id 00721157ae682-2f16645872fso80978747b3.4 for ; Fri, 22 Apr 2022 03:42:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sP8JvrZInBak3AnrSA3yrnJGI9uRamz0KMh5AUQsofQ=; b=mxaV6FRRNknnsY7+E9ykC3IUZCerphaQNqbeakR5XX75pUdnHgcJJUsRJ3aXY80yJ9 HktNrl7JztZV1ZWvWCc1if3I9Ost6qcIY13XFooCfXXscYXOh122ddiLA9zXubk6clOK Pmlpju9qsubHxSspDtaLqWbNUAVKqYnqX0P0h9eEiLyxBKvOeIEL9txSEe6wKokO3Xcx ZseIJJFtqjjxN4me2HSBYwtgVXmW4BszQiTWFy6eb9aoZFhLzZZCnUWrVso2JZ4LixRr ujKw/Jfyw6S0id3WlCZ+Fxy1DYCS/YjBsPgfaS7+Js25+QrYAZem9tlZZ8MtG7MuhcPM fEdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sP8JvrZInBak3AnrSA3yrnJGI9uRamz0KMh5AUQsofQ=; b=ZgtTTzldH6iyJ+EMjUotfhNIN5NkD/NH9I9xcEpbY5euucdDmRvcgZCKBv33+oFapR Svx9KDskgriYaslDaDYgaZi+Zy0TrnQzh+Obm3G1txqujjyGHSZtooBiZlXzkGqUY5J6 6xHCeuOik6UaklQqm6ZAxGB5qwGw6O0lamGUfvr92MUiOKNskoczJOB/vAP20dCjbc1h 2N5hdkZpY/sZVXg66xSxoXwLaLAto4DEekQA99Ud6XgvjajHwBoIebcH+NaRHhdMLJva kH0T5C5OHp6InY4/WpPKsnw3unXF7pqddTLpEqz56CRMZSw4N9AEA3LlGbfCqBtceJHd adpQ== X-Gm-Message-State: AOAM531ie0uBMB5yZgtL241Vf+80AFlDbHyetYZF1pDBWqIHUvtaLUkI 2OJJLg+oW5Vao1G6dRb6KswWgUAKoFvT6m8ded+lgQ== X-Google-Smtp-Source: ABdhPJz2tiFNiuWE0RHaKofgV7Ha+x3z1t8YOpPiDzl8uQ8X2u6bN2PirRLEPFpKZHLnbUVDQq7E3Ml0rr2qadl/3mE= X-Received: by 2002:a81:4c11:0:b0:2d1:1925:cd70 with SMTP id z17-20020a814c11000000b002d11925cd70mr3926695ywa.101.1650624142869; Fri, 22 Apr 2022 03:42:22 -0700 (PDT) MIME-Version: 1.0 References: <20220422085211.2776419-1-lv.ruyi@zte.com.cn> In-Reply-To: <20220422085211.2776419-1-lv.ruyi@zte.com.cn> From: Dmitry Baryshkov Date: Fri, 22 Apr 2022 13:42:12 +0300 Message-ID: Subject: Re: [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map() To: cgel.zte@gmail.com Cc: robdclark@gmail.com, sean@poorly.run, quic_abhinavk@quicinc.com, airlied@linux.ie, daniel@ffwll.ch, swboyd@chromium.org, quic_mkrishn@quicinc.com, angelogioacchino.delregno@collabora.com, vulab@iscas.ac.cn, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Lv Ruyi , Zeal Robot Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 22 Apr 2022 at 11:52, wrote: > > From: Lv Ruyi > > The irq_of_parse_and_map() function returns 0 on failure, and does not > return an negative value. > > Reported-by: Zeal Robot > Signed-off-by: Lv Ruyi Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > index 3b92372e7bdf..1fb1ed9e95d9 100644 > --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c > @@ -570,7 +570,7 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) > } > > irq = irq_of_parse_and_map(pdev->dev.of_node, 0); > - if (irq < 0) { > + if (!irq) { > ret = irq; > DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret); > goto fail; > -- > 2.25.1 > -- With best wishes Dmitry