From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E111C6FD1C for ; Fri, 24 Mar 2023 22:06:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232109AbjCXWGh (ORCPT ); Fri, 24 Mar 2023 18:06:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229943AbjCXWGf (ORCPT ); Fri, 24 Mar 2023 18:06:35 -0400 Received: from mail-yb1-xb34.google.com (mail-yb1-xb34.google.com [IPv6:2607:f8b0:4864:20::b34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E1821E5F2 for ; Fri, 24 Mar 2023 15:06:34 -0700 (PDT) Received: by mail-yb1-xb34.google.com with SMTP id j7so4009187ybg.4 for ; Fri, 24 Mar 2023 15:06:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679695593; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=AW96lDx5vwowhGiHzDVKGLsiV7fUhA67Ww+wttjBEwU=; b=kpJyuBzmaRYbioRqb5vGqry2GHgycmPyUnnxvdAANb2s+I5+UckR9viLl/8kUnwtsf Q7+LDDM69Vu2oFwkJGdq0pk81UJndycZyxuRQhPnR7WIn7TI116XPFHuAu6wWLccOc8o 2sBeL91RE2283BvpWqZ1lLdl5THJKMNCJ+BTayM2nZ2dJsHu0EO7S7GQgtCqrYSJvdwW UU7aT8YPVkRLG1i0zyfT4IEd5slRhq8VTdfFrM8OfTioFMwOV0gD8IBlT0YtUSuoNtQu 539xnoMEbH6SAZf8TaExkU7HmF+MVxlf2Ed51omRr2X6PZWYSIxHlxDf25bEFwSFH7oV //iQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679695593; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=AW96lDx5vwowhGiHzDVKGLsiV7fUhA67Ww+wttjBEwU=; b=rgHABOrwb+jrDTqej1hx1c9Ae1PiR+iTA/CLif565PdnyjTP1yCKbebn3mZ7AfrIHR IBCOO0/Y9T7c5KrJhA0PgnmWgWf1+vxMAu/UFxHmM9xXmCOXTPeNmhlzLOouLnGYn2mb EiFyqubKPm+Y/1pBm5Ti4K8PjBxapHzXSIBR9WgTjcjpOjPb/hsBhmXAdJSr8BPftTGK 0Pr+Ydsz9ypdn8yk/nimHagqXwBid/F+h/wB2aKNZN2ygNQX8foF33WUVP1bGSUvfZD0 OEnNlEKlWFklysX60XBJ9HFAsbE9QZRp9gF5lbskDy6RcwSDxpb0NlerzwgLo0hZ92qN 01yA== X-Gm-Message-State: AAQBX9d5jmE6eSXJ+jT1tnvaxu4pxB4lIrkGs40ueZSVUvURM4t12hED RKW+Flga4AE48Tw2UWZQTr8k0ryHAsCAfKg1QTA4hQ== X-Google-Smtp-Source: AKy350b22KWd/52YQxPAH9uA2YhVFFyLDy325ozIEZ34++SQJC7q83qVmJTG2A31rDN5OZEc70zCmWabGGvncpkmyxQ= X-Received: by 2002:a05:6902:1501:b0:b4c:9333:2a2 with SMTP id q1-20020a056902150100b00b4c933302a2mr1857678ybu.9.1679695593310; Fri, 24 Mar 2023 15:06:33 -0700 (PDT) MIME-Version: 1.0 References: <20230306100722.28485-1-johan+linaro@kernel.org> <20230306100722.28485-7-johan+linaro@kernel.org> In-Reply-To: <20230306100722.28485-7-johan+linaro@kernel.org> From: Dmitry Baryshkov Date: Sat, 25 Mar 2023 00:06:21 +0200 Message-ID: Subject: Re: [PATCH 06/10] drm/msm: fix vram leak on bind errors To: Johan Hovold Cc: Rob Clark , Abhinav Kumar , Sean Paul , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Craig Tatlor Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 6 Mar 2023 at 12:09, Johan Hovold wrote: > > Make sure to release the VRAM buffer also in a case a subcomponent fails > to bind. > > Fixes: d863f0c7b536 ("drm/msm: Call msm_init_vram before binding the gpu") > Cc: stable@vger.kernel.org # 5.11 > Cc: Craig Tatlor > Signed-off-by: Johan Hovold > --- > drivers/gpu/drm/msm/msm_drv.c | 26 +++++++++++++++++++------- > 1 file changed, 19 insertions(+), 7 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry