From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Luca Weiss <luca@z3ntu.xyz>,
linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device
Date: Mon, 28 Nov 2022 14:44:45 +0200 [thread overview]
Message-ID: <CAA8EJpofyGs=OEvDB5vx_odJBYHMCsry09PnjgH86bfsyo63jw@mail.gmail.com> (raw)
In-Reply-To: <f6bb5759-453b-fa05-c6e1-f1d57abeaffa@linaro.org>
On Mon, 28 Nov 2022 at 10:34, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 27/11/2022 22:43, Dmitry Baryshkov wrote:
> > On Sun, 27 Nov 2022 at 23:30, Krzysztof Kozlowski
> > <krzysztof.kozlowski@linaro.org> wrote:
> >>
> >> On 27/11/2022 22:25, Dmitry Baryshkov wrote:
> >>> On Sun, 27 Nov 2022 at 20:19, Luca Weiss <luca@z3ntu.xyz> wrote:
> >>>>
> >>>> Document the OnePlus One ("bacon") which is a smartphone based on the
> >>>> Snapdragon 801 SoC.
> >>>>
> >>>> Also allow msm8974 devices to use qcom,msm-id and qcom,board-id.
> >>>
> >>> The patch itself is good. However it raised a broader question for me.
> >>> Up to now all msm8974pro devices use qcom,msm8974 as a top-level
> >>> compatibility string. Should it be changed to use pro-specific one
> >>> (e.g. qcom,msm8974pro)?
> >>
> >> Yes, makes sense.
> >
> > Would you make the patch?
>
> I do not plan to. I don't know which ones are Pro which aren't.
Ack, I'll do it then.
--
With best wishes
Dmitry
prev parent reply other threads:[~2022-11-28 12:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 18:18 [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device Luca Weiss
2022-11-27 18:18 ` [PATCH 2/2] ARM: dts: qcom: msm8974: Add OnePlus One Luca Weiss
2022-11-27 21:08 ` Krzysztof Kozlowski
2022-11-27 21:05 ` [PATCH 1/2] dt-bindings: arm: qcom: Document oneplus,bacon device Krzysztof Kozlowski
2022-11-27 21:25 ` Dmitry Baryshkov
2022-11-27 21:30 ` Krzysztof Kozlowski
2022-11-27 21:43 ` Dmitry Baryshkov
2022-11-28 8:34 ` Krzysztof Kozlowski
2022-11-28 12:44 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA8EJpofyGs=OEvDB5vx_odJBYHMCsry09PnjgH86bfsyo63jw@mail.gmail.com' \
--to=dmitry.baryshkov@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).