From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: Rob Clark <robdclark@gmail.com>
Cc: "Akhil P Oommen" <quic_akhilpo@quicinc.com>,
freedreno <freedreno@lists.freedesktop.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"Abhinav Kumar" <quic_abhinavk@quicinc.com>,
"Christian König" <christian.koenig@amd.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"David Airlie" <airlied@linux.ie>,
"Jonathan Marek" <jonathan@marek.ca>,
"Jordan Crouse" <jordan@cosmicpenguin.net>,
"Sai Prakash Ranjan" <saiprakash.ranjan@codeaurora.org>,
"Sean Paul" <sean@poorly.run>,
"Stephen Boyd" <swboyd@chromium.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/4] drm/msm/adreno: Expose speedbin to userspace
Date: Thu, 13 Jan 2022 10:13:00 +0300 [thread overview]
Message-ID: <CAA8EJpokgiUbqj9BOF52a9QjJK53PinNHfxy_6nbNq53JnO2Og@mail.gmail.com> (raw)
In-Reply-To: <CAF6AEGuJxdrYM5XXt6sUGmjossqZTRzwQ6Y8qYsnfCYDvGQurw@mail.gmail.com>
On Thu, 13 Jan 2022 at 00:19, Rob Clark <robdclark@gmail.com> wrote:
>
> On Tue, Jan 11, 2022 at 1:31 PM Akhil P Oommen <quic_akhilpo@quicinc.com> wrote:
> >
> > Expose speedbin through MSM_PARAM_CHIP_ID parameter to help userspace
> > identify the sku.
> >
> > Signed-off-by: Akhil P Oommen <quic_akhilpo@quicinc.com>
> > ---
> >
> > drivers/gpu/drm/msm/adreno/adreno_gpu.c | 9 +++++----
> > 1 file changed, 5 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> > index f33cfa4..e970e6a 100644
> > --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> > +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> > @@ -242,10 +242,11 @@ int adreno_get_param(struct msm_gpu *gpu, uint32_t param, uint64_t *value)
> > *value = !adreno_is_a650_family(adreno_gpu) ? 0x100000 : 0;
> > return 0;
> > case MSM_PARAM_CHIP_ID:
> > - *value = adreno_gpu->rev.patchid |
> > - (adreno_gpu->rev.minor << 8) |
> > - (adreno_gpu->rev.major << 16) |
> > - (adreno_gpu->rev.core << 24);
> > + *value = (uint64_t) adreno_gpu->rev.patchid |
> > + (uint64_t) (adreno_gpu->rev.minor << 8) |
> > + (uint64_t) (adreno_gpu->rev.major << 16) |
> > + (uint64_t) (adreno_gpu->rev.core << 24) |
> > + (((uint64_t) adreno_gpu->rev.sku) << 32);
>
> How about this instead, so we are only changing the behavior for
> new/unreleased devices:
>
> *value = adreno_gpu->rev.patchid |
> (adreno_gpu->rev.minor << 8) |
> (adreno_gpu->rev.major << 16) |
> (adreno_gpu->rev.core << 24);
> if (!adreno_gpu->info->revn)
> *value |= (((uint64_t) adreno_gpu->rev.sku) << 32);
>
> (sorry about the butchered indentation.. somehow gmail has become
> antagonistic about pasting code)
I assume that you would like to keep userspace compat for older chips.
thus the if.
Maybe we should introduce MSM_PARAM_CHIP_ID_SKU instead (and gradually
make userspace switch to it)?
>
> BR,
> -R
>
> > return 0;
> > case MSM_PARAM_MAX_FREQ:
> > *value = adreno_gpu->base.fast_rate;
> > --
> > 2.7.4
> >
--
With best wishes
Dmitry
next prev parent reply other threads:[~2022-01-13 7:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-11 21:31 [PATCH 1/4] drm/msm/adreno: Add support for Adreno 8c Gen 3 Akhil P Oommen
2022-01-11 21:31 ` [PATCH 2/4] arm64: dts: qcom: sc7280: Support gpu speedbin Akhil P Oommen
2022-01-11 21:31 ` [PATCH 3/4] drm/msm/adreno: Expose speedbin to userspace Akhil P Oommen
2022-01-12 21:19 ` Rob Clark
2022-01-13 7:13 ` Dmitry Baryshkov [this message]
2022-01-17 14:38 ` Akhil P Oommen
2022-01-17 18:52 ` Rob Clark
2022-01-11 21:31 ` [PATCH 4/4] drm/msm/adreno: Update the name of 7c3 gpu Akhil P Oommen
2022-01-11 22:57 ` [PATCH 1/4] drm/msm/adreno: Add support for Adreno 8c Gen 3 Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJpokgiUbqj9BOF52a9QjJK53PinNHfxy_6nbNq53JnO2Og@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@linux.ie \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jonathan@marek.ca \
--cc=jordan@cosmicpenguin.net \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_akhilpo@quicinc.com \
--cc=robdclark@gmail.com \
--cc=saiprakash.ranjan@codeaurora.org \
--cc=sean@poorly.run \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).