From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
To: "José Expósito" <jose.exposito89@gmail.com>
Cc: robdclark@gmail.com, maarten.lankhorst@linux.intel.com,
sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch,
tzimmermann@suse.de, maxime@cerno.tech, mripard@kernel.org,
wens@csie.org, jernej.skrabec@gmail.com,
linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] Add missing format_mod_supported functions
Date: Tue, 21 Dec 2021 13:50:06 +0300 [thread overview]
Message-ID: <CAA8EJpqJ-tWmb5Ba6XSK59toCtLb3nRRmVH8da4Ud_rrRYytmw@mail.gmail.com> (raw)
In-Reply-To: <20211221101319.7980-1-jose.exposito89@gmail.com>
On Tue, 21 Dec 2021 at 13:13, José Expósito <jose.exposito89@gmail.com> wrote:
>
> Hi all,
>
> When setting IN_FORMATS, implementing the
> "drm_plane_funcs.format_mod_supported" function is mandatory to avoid
> exposing a bogus blob.
>
> This patchset adds a bit of documentation and fixes the issue in a
> couple of drivers affected by the bug.
>
> I reviewed all the other drivers and I didn't find more instances of
> the issue.
>
> Jose
>
> José Expósito (3):
> drm/plane: Mention format_mod_supported in IN_FORMATS docs
> drm/msm/mdp4: Add format_mod_supported function
> drm/sun4i: Add format_mod_supported function
>
> drivers/gpu/drm/drm_plane.c | 7 +++++--
> drivers/gpu/drm/msm/disp/mdp4/mdp4_plane.c | 8 ++++++++
You missed mdp5_plane.c here. But I assume that the proposed fix is
not correct, see my comments on patch 1.
> drivers/gpu/drm/sun4i/sun8i_ui_layer.c | 7 +++++++
> drivers/gpu/drm/sun4i/sun8i_vi_layer.c | 7 +++++++
> 4 files changed, 27 insertions(+), 2 deletions(-)
>
> --
> 2.25.1
>
--
With best wishes
Dmitry
prev parent reply other threads:[~2021-12-21 10:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 10:13 [PATCH 0/3] Add missing format_mod_supported functions José Expósito
2021-12-21 10:13 ` [PATCH 1/3] drm/plane: Mention format_mod_supported in IN_FORMATS docs José Expósito
2021-12-21 10:33 ` Simon Ser
2021-12-21 10:48 ` Dmitry Baryshkov
2021-12-21 10:50 ` Simon Ser
2021-12-21 12:33 ` Dmitry Baryshkov
2021-12-21 12:50 ` Simon Ser
2021-12-21 10:13 ` [PATCH 2/3] drm/msm/mdp4: Add format_mod_supported function José Expósito
2021-12-21 10:13 ` [PATCH 3/3] drm/sun4i: " José Expósito
2021-12-21 10:50 ` Dmitry Baryshkov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA8EJpqJ-tWmb5Ba6XSK59toCtLb3nRRmVH8da4Ud_rrRYytmw@mail.gmail.com \
--to=dmitry.baryshkov@linaro.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jose.exposito89@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=maxime@cerno.tech \
--cc=mripard@kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).