From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A34DC43334 for ; Mon, 27 Jun 2022 15:15:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236104AbiF0PPc (ORCPT ); Mon, 27 Jun 2022 11:15:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236155AbiF0PPa (ORCPT ); Mon, 27 Jun 2022 11:15:30 -0400 Received: from mail-qv1-xf30.google.com (mail-qv1-xf30.google.com [IPv6:2607:f8b0:4864:20::f30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFB27186C5 for ; Mon, 27 Jun 2022 08:15:28 -0700 (PDT) Received: by mail-qv1-xf30.google.com with SMTP id c1so15103821qvi.11 for ; Mon, 27 Jun 2022 08:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mzJBc6lpxrhRFAK19Ed32rRqhbZNObvqIUjXDfqFSfg=; b=m67baQfFZVYozVrPpK7ebfiOEWopTNMUi5ny7mGhXcwG8FGpcUPLYZqxyJV2qyNgpt V3DN2DoadHlkkqlczAi/yJVFj8AlRi0aG0bWtztLQ2NnSdWjMD9MatduW+M/FluFke1W t4vfg2QsCjaMDRoxDdrbZudjjex22JBpDrtryJyZ/rY9nnG/JRt8Z5JtGoI0818mgajG 8KyBReHKQOpw/75RNbwZqRctyg1qKnlZnJfSorQa3H7PJxOw4oz1XA/NOWej+M2mJqgr Rnbitb+kztu1tVv8RhcypNCwguzlroIwUk28vvQ88BCVnA8MVc1aFOX8obGV9BLYHV3a GsNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mzJBc6lpxrhRFAK19Ed32rRqhbZNObvqIUjXDfqFSfg=; b=G+k8KY7j7IEVqlO9YF/zSMqvdU5duUA2HG2Ha4mO1v6a++OJzjL3mqShNhE7S9IIaF exnvOKWm5RrTQPcypBZ9+rnMVtj5ONrtEojXRLO8h6Tb+h1quGjC9nVlrLF1oyre8AIf veDZCTj4HbZOHaw6/f5czUA6HvLoU3zMTTlG8Iiv+J7aqG21orD/pquE+4xlNK+OJ/vX QehHz6PDM+hrXf3iVaX9zX3ZOEoFOArblXc85WPjOtjOf0Cg063YD9Y2OJ1XYp6RQpXM 5hjbM88C7KJiuvzuGl/hEsQ17zSK8kIJK/+4vZktJiUxsSEKssVB6UrYC2fJJ5qUOBRr NpZA== X-Gm-Message-State: AJIora97kqP57xYoQb0LsT0/kC+Px9wcm58tWQAMWSp5s9UnNIHFktY4 m/Nch1m9UAZmSeQNUfYsRBZLaGFtYAqcGDE6gIqY+w== X-Google-Smtp-Source: AGRyM1swbxw2oPkjvAcMatteIT7UIcJlIFRpeQlmjTn5jVhoaz05rgHTPHTNwKJZBB6alu02OkIAS6n68qLOaG1Hv+w= X-Received: by 2002:a05:6214:2a83:b0:470:a898:e467 with SMTP id jr3-20020a0562142a8300b00470a898e467mr8896772qvb.122.1656342927912; Mon, 27 Jun 2022 08:15:27 -0700 (PDT) MIME-Version: 1.0 References: <20220501202025.211567-1-konrad.dybcio@somainline.org> <20220501202025.211567-2-konrad.dybcio@somainline.org> In-Reply-To: <20220501202025.211567-2-konrad.dybcio@somainline.org> From: Dmitry Baryshkov Date: Mon, 27 Jun 2022 18:15:15 +0300 Message-ID: Subject: Re: [PATCH v3 2/2] thermal: qcom: tsens-v1: Add support for MSM8992/4 TSENS To: Konrad Dybcio Cc: ~postmarketos/upstreaming@lists.sr.ht, martin.botka@somainline.org, angelogioacchino.delregno@somainline.org, marijn.suijten@somainline.org, jamipkettunen@somainline.org, Amit Kucheria , Thara Gopinath , Andy Gross , Bjorn Andersson , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 1 May 2022 at 23:21, Konrad Dybcio wrote: > > MSM8994, despite being heavily based on MSM8974, uses the > 1.2 version of TSENS. Also, 8994 being 8994, it has a custom > way of calculating the slope. > > MSM8992 in turn is a cut-down version of MSM8994 and uses > the same TSENS hardware, albeit with a different set of sensors. > > Also tested on 8976 (by a person who didn't want to be named) > to make sure the 11->16 max_sensors changes didn't break anything. > > Signed-off-by: Konrad Dybcio > --- > Changes since v2: > > - don't use slope before it's initialized (whoops!) > - don't re-assign the same value to p[0..15] > - free calib_rsel > - use the same ops for 8992 and 8994 > > drivers/thermal/qcom/tsens-v1.c | 293 ++++++++++++++++++++++++++++++-- > drivers/thermal/qcom/tsens.c | 6 + > drivers/thermal/qcom/tsens.h | 2 +- > 3 files changed, 288 insertions(+), 13 deletions(-) > > diff --git a/drivers/thermal/qcom/tsens-v1.c b/drivers/thermal/qcom/tsens-v1.c > index 573e261ccca7..58864962f370 100644 > --- a/drivers/thermal/qcom/tsens-v1.c > +++ b/drivers/thermal/qcom/tsens-v1.c > @@ -142,6 +142,99 @@ > #define CAL_SEL_MASK 7 > #define CAL_SEL_SHIFT 0 > > +/* eeprom layout data for 8994 */ > +#define MSM8994_BASE0_MASK 0x3ff > +#define MSM8994_BASE1_MASK 0xffc00 > +#define MSM8994_BASE0_SHIFT 0 > +#define MSM8994_BASE1_SHIFT 10 Generally I feel that all the _MASK values can be better generated using the GENMASK and newly defined _SHIFT value. > + > +#define MSM8994_S0_MASK 0xf00000 > +#define MSM8994_S1_MASK 0xf000000 > +#define MSM8994_S2_MASK 0xf0000000 > +#define MSM8994_S3_MASK 0xf > +#define MSM8994_S4_MASK 0xf0 > +#define MSM8994_S5_MASK 0xf00 > +#define MSM8994_S6_MASK 0xf000 > +#define MSM8994_S7_MASK 0xf0000 > +#define MSM8994_S8_MASK 0xf00000 > +#define MSM8994_S9_MASK 0xf000000 > +#define MSM8994_S10_MASK 0xf0000000 > +#define MSM8994_S11_MASK 0xf > +#define MSM8994_S12_MASK 0xf0 > +#define MSM8994_S13_MASK 0xf00 > +#define MSM8994_S14_MASK 0xf000 > +#define MSM8994_S15_MASK 0xf0000 > + > +#define MSM8994_S0_SHIFT 20 > +#define MSM8994_S1_SHIFT 24 > +#define MSM8994_S2_SHIFT 28 > +#define MSM8994_S3_SHIFT 0 > +#define MSM8994_S4_SHIFT 4 > +#define MSM8994_S5_SHIFT 8 > +#define MSM8994_S6_SHIFT 12 > +#define MSM8994_S7_SHIFT 16 > +#define MSM8994_S8_SHIFT 20 > +#define MSM8994_S9_SHIFT 24 > +#define MSM8994_S10_SHIFT 28 > +#define MSM8994_S11_SHIFT 0 > +#define MSM8994_S12_SHIFT 4 > +#define MSM8994_S13_SHIFT 8 > +#define MSM8994_S14_SHIFT 12 > +#define MSM8994_S15_SHIFT 16 [skipped the rest] -- With best wishes Dmitry