From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05CCBC433F5 for ; Thu, 29 Sep 2022 10:19:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235395AbiI2KTk (ORCPT ); Thu, 29 Sep 2022 06:19:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40162 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235231AbiI2KTD (ORCPT ); Thu, 29 Sep 2022 06:19:03 -0400 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7717414C9E4 for ; Thu, 29 Sep 2022 03:18:41 -0700 (PDT) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-333a4a5d495so9533197b3.10 for ; Thu, 29 Sep 2022 03:18:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=xIBSn4ztR5ROz6GRB0axkNF5Yod6vvG1hBCcQxzJkTU=; b=vXZ4OhLwR3SENX+ujRusbFRUJC74NHXWWc/G0gw3IeNRB1EkqtQeFK5NHY6GWb56hQ Bt4ca1I3PDbVMJrwAqgEtCdKphsSI1X1JDiis5T4gtY4mZNJyQOskwk9RXIwdPQNij25 9ulJ+ol0TRNBkwj4wbBez1iZFr+mdEagN/RrE/Gl2m14/zUZO+BA5rFu1CXf6jDgU4CW OWKqXNdzHoaOpplyU1OKsJLPMCMl97EbUE9iaNtBU/9sh1KVV3Yhq5bT74cMish+z0hU cg8xFUteACql9ntv68Yk+3DGstRuZYmSygwDvj9paAPSM3+mBlzxGEWqMj5Q4Uv+1G1D kCfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=xIBSn4ztR5ROz6GRB0axkNF5Yod6vvG1hBCcQxzJkTU=; b=MTNoikERD8aIM8+f8SXV5WuY8g6JyIpx/0M6od6nCMpFjCGbM2UsKA/gUzocJ6oWpY GqE8Q629Zen6eRf+hZN3SZgoGiEgRZh4gSp4be1RXr1UO3iHrJ7RXjJWI/ZaNXMCyuIi x92a8RirIIpEVkJ0d9HGITP/25aNzhIPTB9IH2F+lzqETOBnwmYjXDoKcm80YIEHsIZe iLSZonLL5+9nNQ9nEsiJi1b4TXZjws0tFnCIdtTHFqTvB1MJtUMWXc6mBKVNsHcD6GKI 0C1afRj0b5uz98GXIr03svCqbdlhlWUmuVwUfW5PgLxTt1jDlRGQfpfZ6/Ocl7Zbhrc0 LsTA== X-Gm-Message-State: ACrzQf21YwFjxx4ZfSJKGe4izPSHBO9oDFNjeqVjdWGkd3xQJtjfUI9P NozVKTtK5wdfc9XRMy3qAFNd6H+ucErF7QK6ejaxKw== X-Google-Smtp-Source: AMsMyM7nAd9fHTaBaOo32n0H5li8V6GN8ddJbCs/NfzNeuXPCQzg5zRe4XG4V3AvJYADKgSf9Y5X3hxf+ELXjuj8PGY= X-Received: by 2002:a0d:d68a:0:b0:350:a7f0:7b69 with SMTP id y132-20020a0dd68a000000b00350a7f07b69mr2458883ywd.132.1664446720102; Thu, 29 Sep 2022 03:18:40 -0700 (PDT) MIME-Version: 1.0 References: <20220929092916.23068-1-johan+linaro@kernel.org> <20220929092916.23068-9-johan+linaro@kernel.org> In-Reply-To: <20220929092916.23068-9-johan+linaro@kernel.org> From: Dmitry Baryshkov Date: Thu, 29 Sep 2022 13:18:28 +0300 Message-ID: Subject: Re: [PATCH v2 08/11] phy: qcom-qmp-ufs: clean up power-down handling To: Johan Hovold Cc: Vinod Koul , Andy Gross , Bjorn Andersson , Konrad Dybcio , Kishon Vijay Abraham I , Neil Armstrong , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 29 Sept 2022 at 12:29, Johan Hovold wrote: > > Always define the POWER_DOWN_CONTROL register instead of falling back to > the v2 (and v4) offset during power on and power off. > > Signed-off-by: Johan Hovold > --- > drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 22 ++++++++-------------- > 1 file changed, 8 insertions(+), 14 deletions(-) Reviewed-by: Dmitry Baryshkov -- With best wishes Dmitry