From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AADEC43219 for ; Tue, 4 Oct 2022 07:36:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229842AbiJDHgS (ORCPT ); Tue, 4 Oct 2022 03:36:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229556AbiJDHgP (ORCPT ); Tue, 4 Oct 2022 03:36:15 -0400 Received: from mail-yb1-xb2a.google.com (mail-yb1-xb2a.google.com [IPv6:2607:f8b0:4864:20::b2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C27BB41D22 for ; Tue, 4 Oct 2022 00:36:13 -0700 (PDT) Received: by mail-yb1-xb2a.google.com with SMTP id b145so531781yba.0 for ; Tue, 04 Oct 2022 00:36:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=epQv7F2qJ84iAW4L5349YGXrHzlAKAVIa/bBXFB0Ad4=; b=P8ChbWpT0YG30J3zUr9FXH2IBiHLJImXbnh3Bp6QCr7ycn4os8DwkN4zVxe9jwYCqh iIt4Vw+qQeooAwfOIFjtcyhWbY60qsSvde1i9B1qlQycypAtDrAE9i1GayX9ihwQ6Iup xtPOOj2tH08HkIZX0cWdUb1kAHdMa962GNiccPwqpfScp3TLt8e6enqb+fFbr3Z8yk/W JIDHS9gPyiytvYZmDh5rvQbfx8FmrC3lEQtaJwMFyLzpjXqGRkKUPbJCmKF3j7jR50zr hwX2sodAOGDV29UG4gtx/51/9Ak51BAhacwwBK+R++g6UDs+C4wIosMpsOF6AMTOkWHX 3puQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=epQv7F2qJ84iAW4L5349YGXrHzlAKAVIa/bBXFB0Ad4=; b=3UH1cvzU86tPnXzvxdNC6t9Xe6JnN6WcQfkrojY2B2SOBRhYBWJ5saoDbSD7kYoP8D phFIpN+tyCbxnbW5zao/UQiWtyQzGvTzpn6IUjzEjxLmtOUsDkL4p7bCUNd//CaFYxgC PzLIEu/HF5HDcNNykt1kaD03nYmtNUYhw+iYDpZrktzr0egPeNr1jRdGJb0l29gII1fZ 5rrwzliPC/vYUGtefMS9eU/7rfzkCaVBa035LKrG5joIpN1LvHEhtSyyUFslRKpzW/tB HVLmSkFH5XXNHSFkAp2ZaoRDmOqE9ncH0CV8qJAvbv1zDh5ZFOslvPobU7Nzh2V3iVC1 vCfQ== X-Gm-Message-State: ACrzQf0bCprzqItKt20T+IeGqHEuVS843f3q11AUcyxQmzIbMPP8OkB9 qUPbSsLCxjUBFSc2Z1OXhY8b4fFLJJyjLEvmimYlOg== X-Google-Smtp-Source: AMsMyM6+w9SWD7hb7k99VJI3GyDPbYFNuQ+U244465sm48x/yJocpc335gm0ixgO8BVhLnpDafAZBq+Iq06T0RuuEUE= X-Received: by 2002:a05:6902:102e:b0:6bd:bdd2:ac32 with SMTP id x14-20020a056902102e00b006bdbdd2ac32mr8599365ybt.516.1664868972999; Tue, 04 Oct 2022 00:36:12 -0700 (PDT) MIME-Version: 1.0 References: <20221001030641.29354-1-quic_molvera@quicinc.com> <20221001030641.29354-2-quic_molvera@quicinc.com> <09f5d364-320e-9ecc-2c2b-68066c61f802@linaro.org> <9664a623-3c58-49e8-1b9a-69335d844448@linaro.org> In-Reply-To: <9664a623-3c58-49e8-1b9a-69335d844448@linaro.org> From: Dmitry Baryshkov Date: Tue, 4 Oct 2022 10:36:02 +0300 Message-ID: Subject: Re: [PATCH 1/5] dt-bindings: firmware: scm: Add QDU1000/QRU1000 compatibles To: Krzysztof Kozlowski Cc: Melody Olvera , Andy Gross , Bjorn Andersson , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Ulf Hansson , Bhupesh Sharma , linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 4 Oct 2022 at 09:53, Krzysztof Kozlowski wrote: > > On 04/10/2022 00:14, Dmitry Baryshkov wrote: > > On Tue, 4 Oct 2022 at 01:02, Melody Olvera wrote: > >> > >> > >> On 10/1/2022 4:25 AM, Krzysztof Kozlowski wrote: > >>> On 01/10/2022 05:06, Melody Olvera wrote: > >>>> Add compatibles for scm driver for QDU1000 and QRU1000 platforms. > >>>> > >>>> Signed-off-by: Melody Olvera > >>>> --- > >>>> Documentation/devicetree/bindings/firmware/qcom,scm.yaml | 2 ++ > >>>> 1 file changed, 2 insertions(+) > >>>> > >>>> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > >>>> index c5b76c9f7ad0..b47a5dda3c3e 100644 > >>>> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > >>>> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > >>>> @@ -51,6 +51,8 @@ properties: > >>>> - qcom,scm-sm8250 > >>>> - qcom,scm-sm8350 > >>>> - qcom,scm-sm8450 > >>>> + - qcom,scm-qdu1000 > >>>> + - qcom,scm-qru1000 > > > > I think after seeing all the patchsets it's time to ask the following > > question. Do we really need a duplicate compatibility families: > > qdu1000 vs qru1000? I'd suggest using a single set of compatibile > > strings in most of the cases. > > Settle down onto a single name (qdu,qru, qdru, whatever) and define > > distinct compat strings only when there is an actual difference? > > > > E.g .we don't have separate compatible strings for all the sda660, > > apq8096, etc. unless this is required by the corresponding hardware > > block not being compatible with corresponding sdm or msm counterpart. > > > > I am not that fluent in Qualcomm naming, so let me ask - what are the > differences between QDU and QRU? > > For compatible (and/or similar) devices the general recommendation is to > have specific compatibles followed by fallback. Even if devices are > very, very, very similar, usually the recommendation still stays. Well, true. But in some cases we handle this by using a single set of compatibles. Consider e.g. sa8155 vs sm8150 (sa8155 overrides just few compats that differ). Or qrb5165 vs sm8250 (there is no separate qrb5165.dtsi). APQ8096 (#include "msm8996.dtsi"). Etc. I'd say this really depends on the actual difference between qru and qdu. -- With best wishes Dmitry