From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D547C433DB for ; Fri, 26 Mar 2021 17:45:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2084A61A36 for ; Fri, 26 Mar 2021 17:45:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230194AbhCZRoh (ORCPT ); Fri, 26 Mar 2021 13:44:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230076AbhCZRo0 (ORCPT ); Fri, 26 Mar 2021 13:44:26 -0400 Received: from mail-qk1-x72c.google.com (mail-qk1-x72c.google.com [IPv6:2607:f8b0:4864:20::72c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDAC5C0613B1 for ; Fri, 26 Mar 2021 10:44:25 -0700 (PDT) Received: by mail-qk1-x72c.google.com with SMTP id y18so6018049qky.11 for ; Fri, 26 Mar 2021 10:44:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YTiCPMS4dthdULxeLUAd4raLVXYHOILiM1vRqix30Ow=; b=PbK4/qmiwnf4feqIwuNChtdWFYvloADtgfAKq6npa2snWi2rZrZkVtTBVnNtn1eXH7 /O9m+XEscpeDlaZ7PTOxVIFH7aWT8w1K8qklnys1Ob8AXEOVcavq5I+xGg5LM6IBlN9c FgHPOIwoCk8iUQtZkvDhodQ/FZ05kPaRoWt16a7UXjPpEoOwWo17qJy13zkX/Ij70Utq VCKh85h45oZ4xkFHs/TqELfixKKQqB03XpyrXzjZ4aGFmGFe2mSPovfDL1ZCj6oJQNyL W4ct/MjShXCOcs2OdPgm0m/RT0XkQzgkBxxMSSr1dKSq36oAF2mJnJKFCAyj27mEKvRn fWWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YTiCPMS4dthdULxeLUAd4raLVXYHOILiM1vRqix30Ow=; b=odSxWhi5dYYzIKv1sYatH06HgHnmX46Bfcu3sFOiUFeWZiCGyU23Av1ik1/DsCtDTh Zs59LgXlOxQXvZeyo1U4FM9w1XsRfY5tGefsJHfSuqb1fbqNu+PE2jTClAYxSnCAeqpx JcnvpCbqiyAPgXmt3Y+cB8CkXJTX3/vCLivv/bq0zqsZTti2KSZWQUdnJoXMItWk7wxp sX7wuN9TGL2sAa7Rqm+reQXvECi9HAywP+c/OroYhQ7R4jMIGa3OXQ+e/upA3zBlAlj/ ao58704UHYXp3gtVESI9TxcfMIxsxJhT1SjU/V/t2llYE1GJXqAHXnF6dhvSb89SNwIa nqeA== X-Gm-Message-State: AOAM532pPJv3M33bpscXt0G0Yzg62g9rAKxo6v6SIcFlvTXDRXy/os16 sAavnjMcoAVTpZ1TWNZEJXptVHvFVP6kxefr4Djc2g== X-Google-Smtp-Source: ABdhPJyDfbvLtsTUNR1uDU1zGMnuuEd3/ebE97k9a0Rt0IpEgxJ7+D/HRW49YpHNBZUyH1b8T02Zcdk4eWd6x72fMjY= X-Received: by 2002:a37:9e50:: with SMTP id h77mr14193891qke.138.1616780665134; Fri, 26 Mar 2021 10:44:25 -0700 (PDT) MIME-Version: 1.0 References: <20210318195930.2229546-1-dmitry.baryshkov@linaro.org> <20210318195930.2229546-2-dmitry.baryshkov@linaro.org> <20210326012017.GA2110606@robh.at.kernel.org> In-Reply-To: <20210326012017.GA2110606@robh.at.kernel.org> From: Dmitry Baryshkov Date: Fri, 26 Mar 2021 20:44:13 +0300 Message-ID: Subject: Re: [PATCH v3 1/6] dt-bindings: phy: qcom,qmp-usb3-dp: Add support for SM8250 To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Vinod Koul , Kishon Vijay Abraham I , Manu Gautam , Stephen Boyd , Jonathan Marek , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 26 Mar 2021 at 04:20, Rob Herring wrote: > > On Thu, Mar 18, 2021 at 10:59:25PM +0300, Dmitry Baryshkov wrote: > > Add compatible for SM8250 in QMP USB3 DP PHY bindings. > > > > Signed-off-by: Dmitry Baryshkov > > --- > > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 - > > Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml | 2 ++ > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > index 626447fee092..c558aa605b9d 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml > > @@ -38,7 +38,6 @@ properties: > > - qcom,sm8250-qmp-gen3x1-pcie-phy > > - qcom,sm8250-qmp-gen3x2-pcie-phy > > - qcom,sm8250-qmp-modem-pcie-phy > > - - qcom,sm8250-qmp-usb3-phy > > Why is this being moved? Not sure what the differences between the 2 > bindings, but doesn't seem like a backwards compatible change. Hmm. I followed the existing schemas, but they are incorrect. It looks like the commit 724fabf5df13 ("dt-bindings: phy: qcom,qmp-usb3-dp: Add DP phy information") has introduced backwards-incompatible change, which is not followed by the current kernel device trees. I'd proposed to move qcom,sc7180-qmp-usb3-phy and qcom,sdm845-qmp-usb3-phy back to bindings/phy/qcom,qmp-phy.yaml (as those device nodes do not use DP serdes block, etc). I'll include the fix into v4 of this series. > > > - qcom,sm8250-qmp-usb3-uni-phy > > - qcom,sm8350-qmp-ufs-phy > > - qcom,sm8350-qmp-usb3-phy > > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > index 33974ad10afe..9792cc567cb5 100644 > > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-usb3-dp-phy.yaml > > @@ -17,6 +17,8 @@ properties: > > - qcom,sc7180-qmp-usb3-phy > > - qcom,sdm845-qmp-usb3-dp-phy > > - qcom,sdm845-qmp-usb3-phy > > + - qcom,sm8250-qmp-usb3-dp-phy > > + - qcom,sm8250-qmp-usb3-phy > > reg: > > items: > > - description: Address and length of PHY's USB serdes block. > > -- > > 2.30.2 > > -- With best wishes Dmitry