From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A33C1C433DF for ; Tue, 20 Oct 2020 12:25:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4BC5122265 for ; Tue, 20 Oct 2020 12:25:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EN2dgWsa" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405877AbgJTMZf (ORCPT ); Tue, 20 Oct 2020 08:25:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48982 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2394317AbgJTMZe (ORCPT ); Tue, 20 Oct 2020 08:25:34 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B344C061755; Tue, 20 Oct 2020 05:25:34 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id h20so1761911lji.9; Tue, 20 Oct 2020 05:25:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ML5uAkCXg7BuNZzIK/5oJSDtl2w2jDqYSwb3Wy6qgRo=; b=EN2dgWsaEbWsTqxnHNLP/4yVmb9Xsku29Dn9P97JnSm57jrFWVcGIf1tVPjH3Vop1X WYBX779xvz6VaDNpWQufeY5mJxTCqpyGpHftTBTfK3wl+DbdMEFeM+V082QwXakiVoJz 0AUcjpEw5FuBmPj+GyWNtzE2DWGm9u0DEO56o+I7EDCd5gzaIv69fQhrMuJv8qoM93nM ZXuXIbshfnD2J9Pk5uQL8GgRGonjdNjTQhjihahycKyR4KZKbz4qVGuEtqx6thztOvLw sQgQXowiD0bClO6P1LXXoSYG7PzbyCjRa7JHmpJ/Us3I9XGKF5Ani/Cs9ZoWU4s4pwds AqMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ML5uAkCXg7BuNZzIK/5oJSDtl2w2jDqYSwb3Wy6qgRo=; b=Beb6CmszOZWkOR58UB0q49emfykjJJPRARFEx/iDQUhjalKiZ1e4O7q36UBcX3oWcy HhLmCdYjzCesjW4JeZlKSjk3snF11M1FS2g7yusjhHbzcdpVfr5fLHx7n/P94Bny0le0 /GwQAq6AxAfdEI2QmpVG7BbW1Dd+f/k3Zf0TnrpO0+1ca2XPcPf5zDMFdSRGk0MZ6e8C sN91IZJlAtgUUkgX342pAI7Anp4dFwNtzHdzuLkRM2zJc9hkm8uycNWMeURTIro1zqfk FndPi85zdMZHwiJKI/9jABaKOwMnbxhJUMQyG5MEH+UUDtX1kPGt/otEn/Iy6sHGIdER 4sVw== X-Gm-Message-State: AOAM5305r4OwdZcK31ZNKjpXX07QSWblEG3PzfK6V0Wfjsdl/gQCqYu4 y/LEDkaE5Lfan9MJFM+m25SyPi89RXZk05tcgw== X-Google-Smtp-Source: ABdhPJxCfBQ6bdmOhdx4GH2VRVDFLUiGSOzY4fw/kjcUoUR25aNPPq1QlCXg34SenUnbHVFHi9gDJq8f1/QJHbCqek8= X-Received: by 2002:a2e:b4d0:: with SMTP id r16mr1068673ljm.470.1603196733039; Tue, 20 Oct 2020 05:25:33 -0700 (PDT) MIME-Version: 1.0 References: <20201015082119.68287-1-rejithomas@juniper.net> <20201018160147.6b3c940a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20201019091702.5b26870c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20201019091702.5b26870c@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Reji Thomas Date: Tue, 20 Oct 2020 17:55:20 +0530 Message-ID: Subject: Re: [PATCH v2] IPv6: sr: Fix End.X nexthop to use oif. To: Jakub Kicinski Cc: Reji Thomas , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot , Mathieu Xhonneux , David Lebrun Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Oct 19, 2020 at 9:47 PM Jakub Kicinski wrote: > > If we can save the device lookup and still be semantically correct, > that's probably better. I am afraid we need to do a device lookup if I am looking up the neighbor. neigh_lookup apis expect dev to be passed. If I go through the current lookup ie ip6_pol_route() I can drop the dev lookup at risk of returning a non neighbor route as it exists today.