From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758450AbcH3MCg (ORCPT ); Tue, 30 Aug 2016 08:02:36 -0400 Received: from mail-qk0-f172.google.com ([209.85.220.172]:34365 "EHLO mail-qk0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757871AbcH3MCf (ORCPT ); Tue, 30 Aug 2016 08:02:35 -0400 MIME-Version: 1.0 In-Reply-To: References: <1472552924-22297-1-git-send-email-binoy.jayan@linaro.org> From: Masami Hiramatsu Date: Tue, 30 Aug 2016 21:02:13 +0900 Message-ID: Subject: Re: [PATCH v4 0/3] *** Latency histograms - IRQSOFF,PREEMPTOFF *** To: Daniel Wagner Cc: Binoy Jayan , "Steven Rostedt (Red Hat)" , Ingo Molnar , Arnd Bergmann , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-08-30 20:39 GMT+09:00 Daniel Wagner : > Hi Binoy, > > On 08/30/2016 12:28 PM, Binoy Jayan wrote: >> >> Examples of triggers: >> echo 'hist:key=latency.log2:val=hitcount:sort=latency' > >> /sys/kernel/debug/tracing/events/latency/latency_preempt/trigger >> echo 'hist:key=cpu,latency:val=hitcount:sort=latency if cpu==1' > >> /sys/kernel/debug/tracing/events/latency/latency_preempt/trigger >> echo 'hist:key=ltype,cpu:val=latency:sort=ltype,cpu if ltype==0' > >> /sys/kernel/debug/tracing/events/latency/latency_preempt/trigger >> >> Histogram output: >> cat /sys/kernel/debug/tracing/events/latency/latency_preempt/hist > > > Could you also add couple of test cases to > tools/testing/selftests/ftrace/test.d/trigger? > > Especially the sorting thing you mentioned in the other mail? Obviously > first we need to figure out what is the expected behavior of it :) Good idea! And also, for both patch, could you show the output examples? It might help people to imagine what it provides. Thank you, -- Masami Hiramatsu