From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbcFNX2q (ORCPT ); Tue, 14 Jun 2016 19:28:46 -0400 Received: from mail-qg0-f51.google.com ([209.85.192.51]:36601 "EHLO mail-qg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751332AbcFNX2p (ORCPT ); Tue, 14 Jun 2016 19:28:45 -0400 MIME-Version: 1.0 In-Reply-To: <1465742896-5841-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1465742896-5841-1-git-send-email-sudipm.mukherjee@gmail.com> From: Dan Williams Date: Tue, 14 Jun 2016 16:28:43 -0700 X-Google-Sender-Auth: TxlvhvRUrHd0uKZ0Ri3_JVgdpLY Message-ID: Subject: Re: [PATCH] dax: use devm_add_action_or_reset To: Sudip Mukherjee Cc: Andrew Morton , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 12, 2016 at 7:48 AM, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling the cleanup to free > the resources allocated. Lets use the helper devm_add_action_or_reset() > and return directly in case of error, as we know that the cleanup > function has been already called by the helper if there was any error. > > Signed-off-by: Sudip Mukherjee Reviewed-by: Dan Williams > --- > > There is no maintainer mentioned for this driver, so not sure who should > this patch go through. *raises hand*, I'll make sure MAINTAINERS gets updated, for this one it seems Andrew has already taken it. I notice that drivers/nvdimm/ could use the same cleanup. I'll take a look unless you beat me to it.