From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04B3DC432BE for ; Sun, 29 Aug 2021 22:57:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D368E60C3F for ; Sun, 29 Aug 2021 22:57:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235688AbhH2W6W (ORCPT ); Sun, 29 Aug 2021 18:58:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35652 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbhH2W6V (ORCPT ); Sun, 29 Aug 2021 18:58:21 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8687DC061575 for ; Sun, 29 Aug 2021 15:57:28 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id e15so7442815plh.8 for ; Sun, 29 Aug 2021 15:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EfubSOF612V2DUt6cuIT4/UdrIQSTLdh4xmGE4/MlMs=; b=TEEzDM582idM5C9dZDQbevAm9/fNLPtUFzMV7Hkg/Efb69wknfmKTQNKIcx1mdcaX0 bIePfUvAfsb6ykRWWvZe9AztshkGpV1ZQfB5XJOwqOv4qcarDWothKHOtRuxBMNjduh1 yWmz6vmN/3Vggd9w3Lf+KR+ewOT+3RXT0Cu0gdpZjXRh2LPKOwSjrMtyZGzWTpA82o5C 0Wth09fY6fZ+Fz/YxrznUgG6sl4g8uwi9jU0GGQc1+bQWWDNVAmMrYxBrgM3tbwwSJf8 rG5yQkXiEFgR4Gfu4Gvfsv0RwYfXy1VQ3o/LuxfjVS5YrVrU7DbZyq6JKcTf4KChujxa SHEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EfubSOF612V2DUt6cuIT4/UdrIQSTLdh4xmGE4/MlMs=; b=oLrjxoyxOVdumWrsDso19tkCdgqYv5QHJPcuRkU6OtdcPe4lcrvglXB5dx0HjC+wAu p+l72TxQVV5Pej3nlzzLEzgCqSHqKUW5i6d/jwqpRfzDMaw4YU044P7aJWRrvNlreTzr E3E+dT3BPB+X+lvdIhUmmPtSnCn8MHI0EHnDvQwSXuL9c7JnFEpxCuSy1q42MKeJEirV KfbhKt905YO9eJ3KGfRAVWBJSIpSbsLOhdOVcU0/Wx9f/dvtk+CXbW6JMHlyQMITpMx8 CpNlpGq1WtmR3T9Y7gKMXStehRFgonwUQrli8d4T9F4CYj/xH0Pfe+K243K+CIBV1Ox7 HHfw== X-Gm-Message-State: AOAM533S3od2RDEJ5aWU0FVfH9CNTB/lcuzhwRVGpuVBb9n6EGrS1gQ1 olBfMUkOw114rjiFlfXTiup3iIZPgthvkhWTIDXbjg== X-Google-Smtp-Source: ABdhPJzCX/xFJh1YP8PqZ4vZHXe/rLrVN7gGJkz/tzPv08zOUlJvf7FkqLuXNTulofkxzN0w5oQtEuPSuH3954/IpNk= X-Received: by 2002:a17:90a:10:: with SMTP id 16mr20894890pja.162.1630277846584; Sun, 29 Aug 2021 15:57:26 -0700 (PDT) MIME-Version: 1.0 References: <20210828212453.898-1-phil@philpotter.co.uk> <3f63d7e1-0eb4-21c0-49eb-262cdadf0e87@gmail.com> In-Reply-To: <3f63d7e1-0eb4-21c0-49eb-262cdadf0e87@gmail.com> From: Phillip Potter Date: Sun, 29 Aug 2021 23:57:15 +0100 Message-ID: Subject: Re: [PATCH 0/3] staging: r8188eu: cleanup c2h_handler code To: Michael Straube Cc: Greg KH , "Fabio M. De Francesco" , Larry Finger , "open list:STAGING SUBSYSTEM" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 29 Aug 2021 at 16:04, Michael Straube wrote: > > On 8/28/21 23:24, Phillip Potter wrote: > > This small patch set cleans up the c2h_handler code in the HAL layer > > of the driver. In r8188eu, this field of struct hal_ops, is not even > > used, so dependent code has always returned _FAIL. For this reason, we > > should remove this function pointer field, and the wrapper function > > which checks it. This is done in stages by this set, and helps get > > the driver closer to the pointer where the HAL layer is > > deleted/integrated as necessary and no longer a separate entity. > > > > Phillip Potter (3): > > staging: r8188eu: remove c2h_handler field from struct hal_ops > > staging: r8188eu: simplify c2h_evt_hdl function > > staging: r8188eu: remove rtw_hal_c2h_handler function > > > > drivers/staging/r8188eu/core/rtw_cmd.c | 23 +++------------------- > > drivers/staging/r8188eu/hal/hal_intf.c | 9 --------- > > drivers/staging/r8188eu/include/hal_intf.h | 4 ---- > > 3 files changed, 3 insertions(+), 33 deletions(-) > > > > Thanks for your patches Phillip. Looks good to me and I've built and > runtime tested this series with Inter-Tech DMG-02, so... > > Acked-by: Michael Straube > > Thanks, > Michael Thanks very much Michael, appreciate it. Regards, Phil