linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	Dan Carpenter <dan.carpenter@oracle.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-staging@lists.linux.dev,
	Fabio Aiuto <fabioaiuto83@gmail.com>
Subject: Re: [PATCH 0/7] staging: rtl8188eu: replace driver with better version
Date: Fri, 23 Jul 2021 08:29:22 +0100	[thread overview]
Message-ID: <CAA=Fs0k0eQUpDgpxEcLAnZ-d87TM3LgPwPt9ydXO_hf39f_9ig@mail.gmail.com> (raw)
In-Reply-To: <630e139c-85e5-f006-6b64-e368847251fc@lwfinger.net>

On Fri, 23 Jul 2021 at 02:56, Larry Finger <Larry.Finger@lwfinger.net> wrote:
>
> On 7/22/21 7:42 PM, Phillip Potter wrote:
> > I had to break this patchset up a bit to get around the file size limits
> > on the mailing list, and also I removed the hostapd stuff which is
> > userspace related and therefore not required.
> >
> > The driver currently in staging is older and less functional than the
> > version on Larry Finger's GitHub account, branch v5.2.2.4. This series
> > of patches therefore:
> >
> > (1) Removes the current driver from staging.
> > (2) Imports the GitHub version mentioned above in its place.
> >
> > There is plenty of work to do to this driver, including to its Makefile,
> > but it is at least buildable/usable for now.
> >
> > Phillip Potter (7):
> >    staging: rtl8188eu: remove existing staging driver
> >    staging: rtl8188eu: introduce new core dir for RTL8188eu driver
> >    staging: rtl8188eu: introduce new hal dir for RTL8188eu driver
> >    staging: rtl8188eu: introduce new os_dep dir for RTL8188eu driver
> >    staging: rtl8188eu: introduce new include dir for RTL8188eu driver
> >    staging: rtl8188eu: introduce new supporting files for RTL8188eu
> >      driver
> >    staging: rtl8188eu: attach newly imported driver to build system
>
> Phillip,
>
> Patch 3/7 fails with a
> drivers/staging/rtl8188eu/hal/phydm_precomp.h: already exists in error:
> working directory. When I deleted the file, the patch applied.
>
> Patch 5/7 fails with a drivers/staging/rtl8188eu/include/hal_data.h: already
> exists in working directory. Again it applied when I manually deleted that file.
>
> Patches 2-6 all have trailing whitespace warnings.
>
> I have started testing. Unfortunately, my GitHub version has a fault in that it
> runs systemd-udevd at 100% of a CPU. So far, I have found that an older commit
> works fine. As soon as I find the fault, I will let you know.
>
> Larry
>
>
>
Dear Larry,

I obviously screwed up here somewhere as there should be no whitespace
or conflicts, so apologies for that. I will do the patch set again
after work when I've heard back from you about the relevant commit,
and send out again.

Regards,
Phil

  reply	other threads:[~2021-07-23  7:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23  0:42 [PATCH 0/7] staging: rtl8188eu: replace driver with better version Phillip Potter
2021-07-23  0:42 ` [PATCH 1/7] staging: rtl8188eu: remove existing staging driver Phillip Potter
2021-07-23  0:42 ` [PATCH 2/7] staging: rtl8188eu: introduce new core dir for RTL8188eu driver Phillip Potter
2021-07-23  0:42 ` [PATCH 3/7] staging: rtl8188eu: introduce new hal " Phillip Potter
2021-07-23  0:42 ` [PATCH 4/7] staging: rtl8188eu: introduce new os_dep " Phillip Potter
2021-07-23 17:33   ` kernel test robot
2021-07-23 17:33   ` [RFC PATCH] staging: rtl8188eu: fix duplicated inclusion kernel test robot
2021-07-23  0:42 ` [PATCH 5/7] staging: rtl8188eu: introduce new include dir for RTL8188eu driver Phillip Potter
2021-07-23  0:42 ` [PATCH 6/7] staging: rtl8188eu: introduce new supporting files " Phillip Potter
2021-07-23  7:29   ` Fabio Aiuto
2021-07-23 11:09   ` Greg KH
2021-07-23 11:19     ` Phillip Potter
2021-07-23  0:42 ` [PATCH 7/7] staging: rtl8188eu: attach newly imported driver to build system Phillip Potter
2021-07-23  7:19   ` kernel test robot
2021-07-23 14:33   ` kernel test robot
2021-07-23  1:56 ` [PATCH 0/7] staging: rtl8188eu: replace driver with better version Larry Finger
2021-07-23  7:29   ` Phillip Potter [this message]
2021-07-23 11:01 ` Greg KH
2021-07-23 11:05   ` Phillip Potter
2021-07-23 21:08 ` Larry Finger
2021-07-23 21:27   ` Phillip Potter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAA=Fs0k0eQUpDgpxEcLAnZ-d87TM3LgPwPt9ydXO_hf39f_9ig@mail.gmail.com' \
    --to=phil@philpotter.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@oracle.com \
    --cc=fabioaiuto83@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).