From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AFD9C433EF for ; Sat, 4 Sep 2021 17:53:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F0EB60F38 for ; Sat, 4 Sep 2021 17:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237229AbhIDRym (ORCPT ); Sat, 4 Sep 2021 13:54:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231181AbhIDRyl (ORCPT ); Sat, 4 Sep 2021 13:54:41 -0400 Received: from mail-pg1-x534.google.com (mail-pg1-x534.google.com [IPv6:2607:f8b0:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13AC1C061575 for ; Sat, 4 Sep 2021 10:53:40 -0700 (PDT) Received: by mail-pg1-x534.google.com with SMTP id c17so2370196pgc.0 for ; Sat, 04 Sep 2021 10:53:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QnhrKb9fsy/ZBD0qfjeHSev1bAl3ZIGL9b4MHAvFavg=; b=1GocTiMk4sq3+M4s/GkMG0fW6ATqHhJevDe/U8ZczJh8ZT2O7zuS8KUVtTIGvN9EIy IG5bWFYmtmk+2GzNIly9dIKsmoIVA1P4zs7nPzPsoutGXhotFmW+L0igHog677jS2IdK 67n8Wsh6UGb25McHCQZIzQrc9kTu8xAp68AQ89ocbNBzYa9oAeTtlAXc78CBxebY4LMf p8WASJZxyfSRkPtqKV89ivauHU4mkjdFTznd9AMxb5wkG15PVhqz46EqNRAW571Zh0eC PwM/AvomHFsOoS2Ysp0xjWKRJ9KXZ6ZgKv0TtwYt0LLjbN37n7jFQLVkHxvxr/JQsHqx yKXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QnhrKb9fsy/ZBD0qfjeHSev1bAl3ZIGL9b4MHAvFavg=; b=VJQpP0dFOsHYUHfDpiVNjxt88Dow5QKmmd7CQqx2Mlv42O7ExgeSeVyn4gQ0FzCOgG bKIGsGl+R268xUF3muuKlL83jxnqkTBm0aCAc3J7kP02w7+H5EpzRdaCwjeyHQN2QJab M9Mj8GdpawtZ/Yfk/7G73mOrYj7AxmyEJMpvI8VxXOSyUYB7sXbSZ0nNUyac18BTReap N4PZBucgO2zlSJ8iJSE3NxpIXJ/lXdB7VwedRGvGVhRMYrT5agwUyO2flObO3WEKg+lk ZfJR3jofdHIo+K0TyiOEFv/uxGyVsscSPqXrTSJ9oyDQ+VHrxFDVmJv1KbM7Er12zg90 5EHQ== X-Gm-Message-State: AOAM5328H2+vC3ETQYMzXcu8KNzlel2hqdNi3rqzOF8MYqvrt648cWzs u3o+pL8w6SqtcbhLKxDJ4za9fy9IHPgFCvQkd4NyM/sH342GUg== X-Google-Smtp-Source: ABdhPJxYfJgqnyk3VuUHulejj2+44RV8+pgXi1bCUYVuN7MpyZYVC89NpwtNPKIiztcu4lS71NNbNyqHQlYSt302MV8= X-Received: by 2002:a63:1a65:: with SMTP id a37mr4433700pgm.338.1630778019574; Sat, 04 Sep 2021 10:53:39 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Phillip Potter Date: Sat, 4 Sep 2021 18:53:28 +0100 Message-ID: Subject: Re: [PATCH] staging: r8188eu: core: remove condition never execute To: Saurav Girepunje Cc: Larry Finger , Greg KH , Michael Straube , "open list:STAGING SUBSYSTEM" , Linux Kernel Mailing List , saurav.girepunje@hotmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 4 Sept 2021 at 13:50, Saurav Girepunje wrote: > > Remove condition which never get execute. > as pattrib->mdata is always zero before if condition check. > > Signed-off-by: Saurav Girepunje > --- > drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c > index 4178b3c1ff57..f314f55997bf 100644 > --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c > +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c > @@ -5669,9 +5669,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, u16 > else if ((pmlmeinfo->state & 0x03) == WIFI_FW_STATION_STATE) > SetToDs(fctrl); > > - if (pattrib->mdata) > - SetMData(fctrl); > - > qc = (unsigned short *)(pframe + pattrib->hdrlen - 2); > > SetPriority(qc, tid); > -- > 2.32.0 > Thanks for this. Acked-by: Phillip Potter Regards, Phil