From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26256C4320A for ; Sat, 21 Aug 2021 17:46:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0BE7D60F4A for ; Sat, 21 Aug 2021 17:46:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234450AbhHURrW (ORCPT ); Sat, 21 Aug 2021 13:47:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60210 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229882AbhHURrU (ORCPT ); Sat, 21 Aug 2021 13:47:20 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F35BFC061575 for ; Sat, 21 Aug 2021 10:46:40 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id j10-20020a17090a94ca00b00181f17b7ef7so3098257pjw.2 for ; Sat, 21 Aug 2021 10:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=philpotter-co-uk.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vu1I56SlUB4H5MNFLJaRk7CI9dgtIkpJTCZCqyENsJo=; b=YQtkT+tqoJxn4EavjELNpI1oc5ZqmnIjhVgEVh3HZhAjpHmtNBTgxaVRTKa3P29cAT WgqdWaMOff58vgruNGhX6SVoq3gnSnEFp93qt5XWEPWuWGOgzsT8vVyBGfDm4Jnf2/Bk xYlNmMfdfy4VpNcvLyQj5EkSdUFVnZ9UJ17kyOddD39NYb+AH470I6LSaZHG0IWQn+02 b22Cp3yU1k17GTOJPeyO4d6zDz4b7Lu/iK2fUTMCVG5ossfDjEyIqz5ByBHlEULc1Ni4 Zxguhc4/BYDcV1cDp7l6gKJJPYa/4UQwHTc1I0noFAXalRgMmSP028zScaWvp1bkJ8JO OX4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vu1I56SlUB4H5MNFLJaRk7CI9dgtIkpJTCZCqyENsJo=; b=CB98yr+p4pZNC8XJwG8dhfSyBOB7Qy2JB5pyrjA8RpXp1R/+DPnjjMNoGwN9mdH0mu qCrLmKnBKpi6Xlq0PFsThwk3xf5L9h9diF3+PcoUWkVI017BG5fXHQEd4/+6oDRuS/O4 ZGd2OSNyte68u4hkjVphQi6zS9cnjJUZavVzNMztKnx8TKTwwe1mqXbGevSIJKy98YQs v22XEF5qyAfpVhmY8294FMcQWNWPRIO6v0Qu/c4mkZeOB/fFfik3Vgz9+LEnLdZQ7PZQ CnMoqpfzhjfXHABev1ao6Pw0h6RHLajUIvbCTTXI7lIJq6aO04Fp7VTp2V/GCiLqqwvu bnSw== X-Gm-Message-State: AOAM532LAu8CN8yCHPop7U0kegw2htGrJRioSEcSXIT3lGU+vnIOXXi1 qZj8u3hcJRl+v9jzW0fX2oeioOwDF7HNMZNZD1BK0A== X-Google-Smtp-Source: ABdhPJwQkFaAK05n5mpz4eB+v1YRaPrVMP1AkRNqQiA3PUBmA8nhYh9IeIUFwb0sq3WTL7ih0BVpRQpl63ORCQA62vI= X-Received: by 2002:a17:90a:1b2e:: with SMTP id q43mr10969934pjq.217.1629568000545; Sat, 21 Aug 2021 10:46:40 -0700 (PDT) MIME-Version: 1.0 References: <20210821164859.4351-1-martin@kaiser.cx> <20210821164859.4351-7-martin@kaiser.cx> In-Reply-To: <20210821164859.4351-7-martin@kaiser.cx> From: Phillip Potter Date: Sat, 21 Aug 2021 18:46:29 +0100 Message-ID: Subject: Re: [PATCH 07/10] staging: r8188eu: clean up the usb_writeXY functions To: Martin Kaiser Cc: Greg Kroah-Hartman , Larry Finger , Dan Carpenter , Michael Straube , linux-staging@lists.linux.dev, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 21 Aug 2021 at 17:49, Martin Kaiser wrote: > > Remove unnecessary variables, summarize declarations and assignments. > > Signed-off-by: Martin Kaiser > --- > drivers/staging/r8188eu/hal/usb_ops_linux.c | 50 ++++----------------- > 1 file changed, 8 insertions(+), 42 deletions(-) > > diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c > index cb969a200681..e01f1ac19596 100644 > --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c > +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c > @@ -128,59 +128,25 @@ static u32 usb_read32(struct intf_hdl *pintfhdl, u32 addr) > > static int usb_write8(struct intf_hdl *pintfhdl, u32 addr, u8 val) > { > - u16 wvalue; > - u16 len; > - u8 data; > - int ret; > - > - > - wvalue = (u16)(addr & 0x0000ffff); > - len = 1; > - data = val; > - ret = usbctrl_vendorreq(pintfhdl, wvalue, &data, len, REALTEK_USB_VENQT_WRITE); > + u16 wvalue = (u16)(addr & 0x0000ffff); > > - return ret; > + return usbctrl_vendorreq(pintfhdl, wvalue, &val, 1, REALTEK_USB_VENQT_WRITE); > } > > static int usb_write16(struct intf_hdl *pintfhdl, u32 addr, u16 val) > { > - u16 wvalue; > - u16 len; > - __le32 data; > - int ret; > - > - > - > - wvalue = (u16)(addr & 0x0000ffff); > - len = 2; > - > - data = cpu_to_le32(val & 0x0000ffff); > - > - ret = usbctrl_vendorreq(pintfhdl, wvalue, &data, len, REALTEK_USB_VENQT_WRITE); > - > - > + u16 wvalue = (u16)(addr & 0x0000ffff); > + __le32 data = cpu_to_le32(val & 0x0000ffff); > > - return ret; > + return usbctrl_vendorreq(pintfhdl, wvalue, &data, 2, REALTEK_USB_VENQT_WRITE); > } > > static int usb_write32(struct intf_hdl *pintfhdl, u32 addr, u32 val) > { > - u16 wvalue; > - u16 len; > - __le32 data; > - int ret; > - > - > - > - wvalue = (u16)(addr & 0x0000ffff); > - len = 4; > - data = cpu_to_le32(val); > - > - ret = usbctrl_vendorreq(pintfhdl, wvalue, &data, len, REALTEK_USB_VENQT_WRITE); > - > - > + u16 wvalue = (u16)(addr & 0x0000ffff); > + __le32 data = cpu_to_le32(val); > > - return ret; > + return usbctrl_vendorreq(pintfhdl, wvalue, &data, 4, REALTEK_USB_VENQT_WRITE); > } > > static int usb_writeN(struct intf_hdl *pintfhdl, u32 addr, u32 length, u8 *pdata) > -- > 2.20.1 > Acked-by: Phillip Potter Regards, Phil