From: Phillip Potter <phil@philpotter.co.uk>
To: Michael Straube <straube.linux@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Martin Kaiser <martin@kaiser.cx>,
Larry Finger <Larry.Finger@lwfinger.net>,
"Fabio M. De Francesco" <fmdefrancesco@gmail.com>
Subject: Re: [PATCH v2] staging: r8188eu: change declaration of Efuse_Read1ByteFromFakeContent
Date: Sat, 21 Aug 2021 18:01:49 +0100 [thread overview]
Message-ID: <CAA=Fs0mSomgGme9Rfg3vQhtHq6xiFBWis3C4t9zB8rQ7MbZEjA@mail.gmail.com> (raw)
In-Reply-To: <f151ef3c-d625-a937-2096-afae4fee20f1@gmail.com>
On Sat, 21 Aug 2021 at 12:03, Michael Straube <straube.linux@gmail.com> wrote:
>
> On 8/21/21 12:56 PM, Phillip Potter wrote:
> > Remove forward declaration of Efuse_Read1ByteFromFakeContent function
> > from core/rtw_efuse.c, as the function is defined in full directly
> > after this and therefore this forward declaration is redundant.
> >
> > In addition, convert the storage class of the function to static, as the
> > function is only used with rtw_efuse.c, and tidy up the signature
> > alignment.
> >
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> >
> > V1: Removed forward declaration.
> > V2: Takes account of feedback from Michael Straube and Fabio M. De
> > Francesco to make storage class of the function static.
> >
> > ---
> > drivers/staging/r8188eu/core/rtw_efuse.c | 14 +++-----------
> > 1 file changed, 3 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
> > index decccf7622f0..c1c70648f5bc 100644
> > --- a/drivers/staging/r8188eu/core/rtw_efuse.c
> > +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
> > @@ -29,17 +29,9 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
> > #define REG_EFUSE_CTRL 0x0030
> > #define EFUSE_CTRL REG_EFUSE_CTRL /* E-Fuse Control. */
> > /* */
> > -
> > -bool
> > -Efuse_Read1ByteFromFakeContent(
> > - struct adapter *pAdapter,
> > - u16 Offset,
> > - u8 *Value);
> > -bool
> > -Efuse_Read1ByteFromFakeContent(
> > - struct adapter *pAdapter,
> > - u16 Offset,
> > - u8 *Value)
> > +static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
> > + u16 Offset,
> > + u8 *Value)
> > {
> > if (Offset >= EFUSE_MAX_HW_SIZE)
> > return false;
> >
>
> Looks good to me.
>
> Acked-by: Michael Straube<straube.linux@gmail.com>
>
>
> Thanks,
>
> Michael
Thanks Michael.
Regards,
Phil
next prev parent reply other threads:[~2021-08-21 17:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-21 10:56 [PATCH v2] staging: r8188eu: change declaration of Efuse_Read1ByteFromFakeContent Phillip Potter
2021-08-21 11:02 ` Michael Straube
2021-08-21 17:01 ` Phillip Potter [this message]
2021-08-21 12:17 ` Fabio M. De Francesco
2021-08-21 17:02 ` Phillip Potter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAA=Fs0mSomgGme9Rfg3vQhtHq6xiFBWis3C4t9zB8rQ7MbZEjA@mail.gmail.com' \
--to=phil@philpotter.co.uk \
--cc=Larry.Finger@lwfinger.net \
--cc=fmdefrancesco@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=martin@kaiser.cx \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).