From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756542Ab2F0Tt5 (ORCPT ); Wed, 27 Jun 2012 15:49:57 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:52748 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752581Ab2F0Ttz (ORCPT ); Wed, 27 Jun 2012 15:49:55 -0400 MIME-Version: 1.0 In-Reply-To: <20120627193039.GF25319@n2100.arm.linux.org.uk> References: <1340812275-1197-1-git-send-email-stigge@antcom.de> <20120627191542.GC25319@n2100.arm.linux.org.uk> <20120627193039.GF25319@n2100.arm.linux.org.uk> Date: Wed, 27 Jun 2012 16:49:54 -0300 Message-ID: Subject: Re: [PATCH 1/4] mtd: lpc32xx_slc: Select AMBA_PL08X in Kconfig From: Alexandre Pereira da Silva To: Russell King - ARM Linux Cc: Roland Stigge , dedekind1@gmail.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org, dwmw2@infradead.org, kevin.wells@nxp.com, srinivas.bakki@nxp.com, linux-arm-kernel@lists.infradead.org, hechtb@googlemail.com, lars@metafoo.de, b32955@freescale.com, leiwen@marvell.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 27, 2012 at 4:30 PM, Russell King - ARM Linux wrote: > Well, the DMA engine API gets stubbed out when no DMA engine is selected, > so I'm not sure why spi-pl022 needs all those ifdefs (yes, you may wish > to do that if you want to shrink your driver private struct size.) > > Provided the driver is capable of working without DMA engine, I don't see > any reason what so ever to make that driver select or depend on DMA engine > stuff. Ok, so this one can be dropped. It was proposed because of an build error in the past, but it's not happening anymore.