From: Zhouyi Zhou <zhouzhouyi@gmail.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Boqun Feng <boqun.feng@gmail.com>,
mingo@redhat.com, will@kernel.org, longman@redhat.com,
paulmck@kernel.org, Josh Triplett <josh@joshtriplett.org>,
rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
"Joel Fernandes, Google" <joel@joelfernandes.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
rcu <rcu@vger.kernel.org>
Subject: Re: [PATCH][RFC] lockdep: improve comments in wait-type checks
Date: Tue, 24 Aug 2021 22:43:18 +0800 [thread overview]
Message-ID: <CAABZP2wtAVYmWfSBmJDyaLuTFQGq6KsN=3uogZtm8FK1_bAJAg@mail.gmail.com> (raw)
In-Reply-To: <YST4aWMArEBsKW07@hirez.programming.kicks-ass.net>
Thank both of you for correcting my mistakes.
I do benefit a lot from your emails.
Cheers
Zhouyi
On Tue, Aug 24, 2021 at 9:47 PM Peter Zijlstra <peterz@infradead.org> wrote:
>
> On Wed, Aug 11, 2021 at 10:44:21AM +0800, Boqun Feng wrote:
> > Hi,
> >
> > On Wed, Aug 11, 2021 at 05:03:19AM +0800, Zhouyi Zhou wrote:
> > > Hi Peter,
> > > I think comments in wait-type checks may benifit from some comments
> > > improvement.
> >
> > Thanks for looking into this!
> >
> > Even for an RFC patch, it's better that you write a proper commit log,
> > and note that you can put all this background information right after
> > the "---" line, if you think that will help people review it.
> >
> > > I recklessly add Paul to signed-off-by, because I asked his opinion
> > > about comment in rcu_read_lock_bh part.
> > >
> >
> > Probably a Suggested-by will suffice, but I leave that to Paul ;-)
>
> This, also since Paul never actually touched the patch.
>
> > > Thanks a lot
> > > Zhouyi
> > >
> > > Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> > > Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
> >
> > Please make you the last one in the "Signed-off-by" list, see
> > Documentation/process/submitting-patches.rst:
> >
> > "Notably, the last Signed-off-by: must always be that of the developer
> > submitting the patch."
>
> The first sob should be that of the author, and given that's the same
> person as the submitter in this case, he's got a problem at his hands
> ;-)
>
prev parent reply other threads:[~2021-08-24 14:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 21:03 [PATCH][RFC] lockdep: improve comments in wait-type checks Zhouyi Zhou
2021-08-11 2:44 ` Boqun Feng
2021-08-24 13:47 ` Peter Zijlstra
2021-08-24 14:43 ` Zhouyi Zhou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAABZP2wtAVYmWfSBmJDyaLuTFQGq6KsN=3uogZtm8FK1_bAJAg@mail.gmail.com' \
--to=zhouzhouyi@gmail.com \
--cc=boqun.feng@gmail.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mingo@redhat.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).