From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC242C433E0 for ; Fri, 12 Jun 2020 22:36:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81FBA206DC for ; Fri, 12 Jun 2020 22:36:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="G9K+8RbC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726357AbgFLWgD (ORCPT ); Fri, 12 Jun 2020 18:36:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726302AbgFLWgC (ORCPT ); Fri, 12 Jun 2020 18:36:02 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B917C03E96F; Fri, 12 Jun 2020 15:36:02 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id x18so12808161lji.1; Fri, 12 Jun 2020 15:36:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fryTqD33zhXlhU0VCShEW5yvvxlaiAEIgEkAK9Mfyxw=; b=G9K+8RbCufAaP0dcdaPuPYzZ5WrLepmeK8kU6p2w5bRIV/KpcpFyRSSDd9RLym2geU A6CQjKx4zmeUwWpBHqAiUdU1ipmNQ6i5RkkxuqN9ofOs2Z3ohgoqEIFNDNgLaXMtJ1Ps Xd4fhf3hb3Y9EYB91KlHSui/wluQUWTAhA2IZyh1O+HUh5EqyTpQYaaDYTOoGHa/NlsG MF+jDkS5mz40UGj1TBzXwU8UtWBtkC0sVGoo9GhHBXcc6P5NUMaVP6nmIPPI+ynQY19W N9ZDC0oBwAJ3tWfimtTEljahANK+V1JkrlLT0hxTwZdOat6vujMEVxqIgb/Ltm9RMQY1 G6Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fryTqD33zhXlhU0VCShEW5yvvxlaiAEIgEkAK9Mfyxw=; b=HA2stdWsAHwZGNwzzFcgEB6lZZeo62itV5QdwzpypoeJVPWMpDXL8wFVGOvYKPZ56H pWM3M1FoFIv+bPfnQIjvH0UBu+JdbSCvYQTCbzCHO9x5ThVGH0HTrdPSH30TYvQW5xeY 1dbglej1hF/LmkcPLfc+kzzNOHRRYtmxHrKBjFFIFQptAf8waqsgT6HIaiqEQA6OGdQa /EO2qiDfxnerXWCv6G3kAaqdMcuXHk+jOPchn0DXI6gUcmkOtJQhjFydkOYCKxqUBg5J C6kxsyVTS+MbzUVBU4lApYJyZdaAlPcOtCjPSt2xcIjuMJgfzInCwapd6YDcqG/g7T3v f07w== X-Gm-Message-State: AOAM531vpP26zXYApiMJcrOayg2h2f6rIS4BhuzteSK2cN11auo8C4pq AKBVJzxfcnAd0znOUZ8iLEfKoUwj5oB1GLfaiwbceg== X-Google-Smtp-Source: ABdhPJyLqcf4/9DQJIzlsxTVHxCs5qShQXNQyQ5NEHHAYUIPhL0WcEiFdo7Vatdz+V9hFYH0CVkYvXrsYxgSHDpDvt0= X-Received: by 2002:a2e:98d7:: with SMTP id s23mr8082293ljj.2.1592001360627; Fri, 12 Jun 2020 15:36:00 -0700 (PDT) MIME-Version: 1.0 References: <20200612160141.188370-1-lmb@cloudflare.com> In-Reply-To: <20200612160141.188370-1-lmb@cloudflare.com> From: Alexei Starovoitov Date: Fri, 12 Jun 2020 15:35:49 -0700 Message-ID: Subject: Re: [PATCH bpf 1/2] flow_dissector: reject invalid attach_flags To: Lorenz Bauer Cc: Alexei Starovoitov , Daniel Borkmann , Jakub Sitnicki , kernel-team , Network Development , bpf , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 12, 2020 at 9:02 AM Lorenz Bauer wrote: > > Using BPF_PROG_ATTACH on a flow dissector program supports neither flags > nor target_fd but accepts any value. Return EINVAL if either are non-zero. > > Signed-off-by: Lorenz Bauer > Fixes: b27f7bb590ba ("flow_dissector: Move out netns_bpf prog callbacks") > --- > kernel/bpf/net_namespace.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/kernel/bpf/net_namespace.c b/kernel/bpf/net_namespace.c > index 78cf061f8179..56133e78ae4f 100644 > --- a/kernel/bpf/net_namespace.c > +++ b/kernel/bpf/net_namespace.c > @@ -192,6 +192,9 @@ int netns_bpf_prog_attach(const union bpf_attr *attr, struct bpf_prog *prog) > struct net *net; > int ret; > > + if (attr->attach_flags || attr->target_fd) > + return -EINVAL; > + In theory it makes sense, but how did you test it? test_progs -t flow fails 5 tests.