From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: bpf <bpf@vger.kernel.org>,
Network Development <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [RFC][PATCH 1/2] ftrace: Add modify_ftrace_direct()
Date: Tue, 19 Nov 2019 07:37:23 -0800 [thread overview]
Message-ID: <CAADnVQJ7ymcPRCw4iWBuec-tYLXSH-62r96WNAVNwQTLA+DGsg@mail.gmail.com> (raw)
In-Reply-To: <20191119091304.2c775b35@gandalf.local.home>
On Tue, Nov 19, 2019 at 6:13 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Mon, 18 Nov 2019 22:04:28 -0800
> Alexei Starovoitov <alexei.starovoitov@gmail.com> wrote:
>
> > I took your for-next without the extra patch and used it from bpf trampoline.
> > It's looking good so far. Passed basic testing. Will add more stress tests.
> >
> > Do you mind doing:
> > diff --git a/include/linux/ftrace.h b/include/linux/ftrace.h
> > index 73eb2e93593f..6ddb203ca550 100644
> > --- a/include/linux/ftrace.h
> > +++ b/include/linux/ftrace.h
> > @@ -256,16 +256,16 @@ struct ftrace_direct_func
> > *ftrace_find_direct_func(unsigned long addr);
> > # define ftrace_direct_func_count 0
> > static inline int register_ftrace_direct(unsigned long ip, unsigned long addr)
> > {
> > - return -ENODEV;
> > + return -ENOTSUPP;
> > }
> > static inline int unregister_ftrace_direct(unsigned long ip, unsigned
> > long addr)
> > {
> > - return -ENODEV;
> > + return -ENOTSUPP;
> > }
> > static inline int modify_ftrace_direct(unsigned long ip,
> > unsigned long old_addr,
> > unsigned long new_addr)
> > {
> > - return -ENODEV;
> > + return -ENOTSUPP;
> > }
> >
> > otherwise ENODEV is a valid error when ip is incorrect which is
> > indistinguishable from ftrace not compiled in.
>
> Sure I can add this. Want to add a Signed-off-by to it, and I'll just
> pull it in directly? I can write up the change log.
Whichever way is easier for you.
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Thanks!
> -- Steve
next prev parent reply other threads:[~2019-11-19 15:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 19:46 [RFC][PATCH 0/2] ftrace: Add modify_ftrace_direct() Steven Rostedt
2019-11-14 19:46 ` [RFC][PATCH 1/2] " Steven Rostedt
2019-11-15 21:51 ` Alexei Starovoitov
2019-11-17 22:18 ` Steven Rostedt
2019-11-19 6:04 ` Alexei Starovoitov
2019-11-19 14:13 ` Steven Rostedt
2019-11-19 15:37 ` Alexei Starovoitov [this message]
2019-11-14 19:46 ` [RFC][PATCH 2/2] ftrace/samples: Add a sample module that implements modify_ftrace_direct() Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAADnVQJ7ymcPRCw4iWBuec-tYLXSH-62r96WNAVNwQTLA+DGsg@mail.gmail.com \
--to=alexei.starovoitov@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).