From: Alexei Starovoitov <alexei.starovoitov@gmail.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: "Kumar Kartikeya Dwivedi" <memxor@gmail.com>,
bpf <bpf@vger.kernel.org>,
"Jesper Dangaard Brouer" <brouer@redhat.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Martin KaFai Lau" <kafai@fb.com>,
"Song Liu" <songliubraving@fb.com>, "Yonghong Song" <yhs@fb.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"KP Singh" <kpsingh@kernel.org>, "Shuah Khan" <shuah@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Peter Zijlstra" <peterz@infradead.org>,
"open list" <linux-kernel@vger.kernel.org>,
Networking <netdev@vger.kernel.org>,
"open list:KERNEL SELFTEST FRAMEWORK"
<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH bpf-next 5/5] libbpf: add selftests for TC-BPF API
Date: Tue, 30 Mar 2021 16:27:20 -0700 [thread overview]
Message-ID: <CAADnVQKMBgFV7rYHWYQZW=i5fYkDYspgVOvhSWyNjAzY9CLD9A@mail.gmail.com> (raw)
In-Reply-To: <CAEf4Bzb-YjQq=P2w3S1Np_jfqepUH2_t4MmomLg8PhA0=P6zZg@mail.gmail.com>
On Tue, Mar 30, 2021 at 1:28 PM Andrii Nakryiko
<andrii.nakryiko@gmail.com> wrote:
> >
> > In the other thread you've proposed to copy paste hash implemenation
> > into pahole. That's not ideal. If we had libbpfutil other projects
> > could have used that without copy-paste.
>
> I know it's not ideal. But I don't think libbpf should be in the
> business of providing generic data structures with stable APIs either.
There is a need for hash in pahole and it's already using libbpf.
Would be good to reuse the code.
> > that's today. Plus mandatory libelf and libz.
> > I would like to have libsysbpf that doesn't depend on libelf/libz
> > for folks that don't need it.
>
> TBH, bpf.c is such a minimal shim on top of bpf() syscall, that
> providing all of its implementation as a single .h wouldn't be too
> horrible. Then whatever applications want those syscall wrappers would
> just include bpf/bpf.h and have no need for the library at all.
1k line bpf.h. hmm. That's not going to be a conventional C header,
but it could work I guess.
> > Also I'd like to see symbolizer to be included in "libbpf package".
> > Currently it's the main component that libbcc offers, but libbpf doesn't.
> > Say we don't split libbpf. Then symbolizer will bring some dwarf library
> > (say libdwarves ~ 1Mbyte) and libiberty ~ 500k (for c++ demangle).
> > Now we're looking at multi megabyte libbpf package.
>
> Right, which is one of the reasons why it probably doesn't belong in
> libbpf at all. Another is that it's not BPF-specific functionality at
> all.
symbolizer, usdt, python and lua bindings is what made libbcc successful.
I think "libbpf package" should include everything that bpf tracing folks
might need.
Getting -l flags correct from a single package isn't a big deal
compared with the need to deal with different packages that
depend on each other.
> I'm against pro-active splitting just in case. I'd rather discuss
> specific problems when we get to them. I think it's premature right
> now to split libbpf.
Fine.
I'm mainly advocating to change the mental model to see
libbpf as a collection of tools and libraries and not just single libbpf.a
next prev parent reply other threads:[~2021-03-30 23:28 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-25 11:59 [PATCH bpf-next 0/5] libbpf: Add TC-BPF API Kumar Kartikeya Dwivedi
2021-03-25 11:59 ` [PATCH bpf-next 1/5] tools pkt_cls.h: sync with kernel sources Kumar Kartikeya Dwivedi
2021-03-26 23:25 ` Andrii Nakryiko
2021-03-27 3:54 ` Kumar Kartikeya Dwivedi
2021-03-27 3:58 ` Andrii Nakryiko
2021-03-25 12:00 ` [PATCH bpf-next 2/5] libbpf: add helpers for preparing netlink attributes Kumar Kartikeya Dwivedi
2021-03-26 23:52 ` Andrii Nakryiko
2021-03-25 12:00 ` [PATCH bpf-next 3/5] libbpf: add low level TC-BPF API Kumar Kartikeya Dwivedi
2021-03-28 4:42 ` Andrii Nakryiko
2021-03-28 8:11 ` Kumar Kartikeya Dwivedi
2021-03-30 20:39 ` Andrii Nakryiko
2021-03-30 21:11 ` Toke Høiland-Jørgensen
2021-03-31 9:32 ` Kumar Kartikeya Dwivedi
2021-03-30 21:25 ` Daniel Borkmann
2021-03-30 23:30 ` Alexei Starovoitov
2021-03-31 9:44 ` Kumar Kartikeya Dwivedi
2021-04-02 0:19 ` Daniel Borkmann
2021-04-02 15:27 ` Kumar Kartikeya Dwivedi
2021-04-02 18:32 ` Alexei Starovoitov
2021-04-02 19:08 ` Kumar Kartikeya Dwivedi
2021-04-03 17:47 ` Alexei Starovoitov
2021-04-05 17:27 ` Andrii Nakryiko
2021-04-06 10:06 ` Toke Høiland-Jørgensen
2021-04-14 0:47 ` Andrii Nakryiko
2021-04-14 10:58 ` Toke Høiland-Jørgensen
2021-04-14 22:22 ` Andrii Nakryiko
2021-04-14 22:51 ` Toke Høiland-Jørgensen
2021-04-14 23:19 ` Andrii Nakryiko
2021-04-14 23:32 ` Daniel Borkmann
2021-04-14 23:58 ` Andrii Nakryiko
2021-04-15 22:10 ` Daniel Borkmann
2021-04-15 22:22 ` Andrii Nakryiko
2021-04-15 23:10 ` Daniel Borkmann
2021-04-16 9:01 ` Toke Høiland-Jørgensen
2021-04-15 15:57 ` Toke Høiland-Jørgensen
2021-04-15 21:09 ` Andrii Nakryiko
2021-04-05 17:21 ` Andrii Nakryiko
2021-04-06 19:05 ` Kumar Kartikeya Dwivedi
2021-03-31 9:51 ` Toke Høiland-Jørgensen
2021-03-29 11:46 ` Vlad Buslov
2021-03-29 12:32 ` Toke Høiland-Jørgensen
2021-03-29 12:49 ` Vlad Buslov
2021-03-25 12:00 ` [PATCH bpf-next 4/5] libbpf: add high " Kumar Kartikeya Dwivedi
2021-03-25 12:00 ` [PATCH bpf-next 5/5] libbpf: add selftests for " Kumar Kartikeya Dwivedi
2021-03-27 2:15 ` Alexei Starovoitov
2021-03-27 15:17 ` Toke Høiland-Jørgensen
2021-03-29 1:26 ` Alexei Starovoitov
2021-03-29 1:45 ` Kumar Kartikeya Dwivedi
2021-03-28 4:32 ` Andrii Nakryiko
2021-03-29 1:40 ` Alexei Starovoitov
2021-03-29 2:38 ` Andrii Nakryiko
2021-03-30 3:28 ` Alexei Starovoitov
2021-03-30 20:28 ` Andrii Nakryiko
2021-03-30 23:27 ` Alexei Starovoitov [this message]
2021-03-29 9:56 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAADnVQKMBgFV7rYHWYQZW=i5fYkDYspgVOvhSWyNjAzY9CLD9A@mail.gmail.com' \
--to=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=shuah@kernel.org \
--cc=songliubraving@fb.com \
--cc=toke@redhat.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).