From: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
To: Douglas Anderson <dianders@chromium.org>
Cc: Heiko Stuebner <heiko@sntech.de>,
Tomasz Figa <tfiga@chromium.org>,
Ziyuan Xu <xzy.xu@rock-chips.com>,
Ezequiel Garcia <ezequiel@collabora.com>,
ryandcase@chromium.org, Elaine Zhang <zhangqing@rock-chips.com>,
Matthias Kaehlcke <mka@chromium.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-clk@vger.kernel.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] clk: rockchip: Fix video codec clocks on rk3288
Date: Fri, 29 Mar 2019 20:28:04 -0300 [thread overview]
Message-ID: <CAAEAJfCvZ_y-No6vQbf_3kUSyuPYujTjW8XhZHiB=-GU2_NWHQ@mail.gmail.com> (raw)
In-Reply-To: <20190329215455.159717-1-dianders@chromium.org>
On Fri, 29 Mar 2019 at 18:55, Douglas Anderson <dianders@chromium.org> wrote:
>
> It appears that there is a typo in the rk3288 TRM. For
> GRF_SOC_CON0[7] it says that 0 means "vepu" and 1 means "vdpu". It's
> the other way around.
>
> How do I know? Here's my evidence:
>
> 1. Prior to commit 4d3e84f99628 ("clk: rockchip: describe aclk_vcodec
> using the new muxgrf type on rk3288") we always pretended that we
> were using "aclk_vdpu" and the comment in the code said that this
> matched the default setting in the system. In fact the default
> setting is 0 according to the TRM and according to reading memory
> at bootup. In addition rk3288-based Chromebooks ran like this and
> the video codecs worked.
> 2. With the existing clock code if you boot up and try to enable the
> new VIDEO_ROCKCHIP_VPU as a module (and without "clk_ignore_unused"
> on the command line), you get errors like "failed to get ack on
> domain 'pd_video', val=0x80208". After flipping vepu/vdpu things
> init OK.
> 3. If I export and add both the vepu and vdpu to the list of clocks
> for RK3288_PD_VIDEO I can get past the power domain errors, but now
> I freeze when the vpu_mmu gets initted.
> 4. If I just mark the "vdpu" as IGNORE_UNUSED then everything boots up
> and probes OK showing that somehow the "vdpu" was important to keep
> enabled. This is because we were actually using it as a parent.
> 5. After this change I can hack "aclk_vcodec_pre" to parent from
> "aclk_vepu" using assigned-clocks and the video codec still probes
> OK.
>
> Fixes: 4d3e84f99628 ("clk: rockchip: describe aclk_vcodec using the new muxgrf type on rk3288")
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
> I currently have no way to test the JPEG mem2mem driver, so hopefully
> others can test this and make sure it's happy for them. I'm just
> happy not to get strange errors at boot anymore.
>
I won't have access to this hardware for a few days, but I am happy
to provide a simple test tool.
Still haven't reviewed this, but thanks for chasing it down!
EZe
> drivers/clk/rockchip/clk-rk3288.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/rockchip/clk-rk3288.c b/drivers/clk/rockchip/clk-rk3288.c
> index 5a67b7869960..4d767f9c3a80 100644
> --- a/drivers/clk/rockchip/clk-rk3288.c
> +++ b/drivers/clk/rockchip/clk-rk3288.c
> @@ -219,7 +219,7 @@ PNAME(mux_hsadcout_p) = { "hsadc_src", "ext_hsadc" };
> PNAME(mux_edp_24m_p) = { "ext_edp_24m", "xin24m" };
> PNAME(mux_tspout_p) = { "cpll", "gpll", "npll", "xin27m" };
>
> -PNAME(mux_aclk_vcodec_pre_p) = { "aclk_vepu", "aclk_vdpu" };
> +PNAME(mux_aclk_vcodec_pre_p) = { "aclk_vdpu", "aclk_vepu" };
> PNAME(mux_usbphy480m_p) = { "sclk_otgphy1_480m", "sclk_otgphy2_480m",
> "sclk_otgphy0_480m" };
> PNAME(mux_hsicphy480m_p) = { "cpll", "gpll", "usbphy480m_src" };
> --
> 2.21.0.392.gf8f6787159e-goog
>
--
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2019-03-29 23:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-29 21:54 [PATCH] clk: rockchip: Fix video codec clocks on rk3288 Douglas Anderson
2019-03-29 23:28 ` Ezequiel Garcia [this message]
2019-03-30 14:24 ` Ezequiel Garcia
2019-03-30 18:35 ` Doug Anderson
2019-04-10 15:45 ` Doug Anderson
2019-04-10 18:38 ` Jonas Karlman
2019-04-10 23:37 ` Doug Anderson
2019-04-11 1:17 ` elaine.zhang
2019-04-11 6:38 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAEAJfCvZ_y-No6vQbf_3kUSyuPYujTjW8XhZHiB=-GU2_NWHQ@mail.gmail.com' \
--to=ezequiel@vanguardiasur.com.ar \
--cc=dianders@chromium.org \
--cc=ezequiel@collabora.com \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mka@chromium.org \
--cc=mturquette@baylibre.com \
--cc=ryandcase@chromium.org \
--cc=sboyd@kernel.org \
--cc=tfiga@chromium.org \
--cc=xzy.xu@rock-chips.com \
--cc=zhangqing@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).