From: Tomasz Figa <tfiga@chromium.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Joerg Roedel <joro@8bytes.org>, Rob Herring <robh+dt@kernel.org>,
rafael.j.wysocki@intel.com, Robin Murphy <robin.murphy@arm.com>,
"open list:IOMMU DRIVERS" <iommu@lists.linux-foundation.org>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will.deacon@arm.com>,
Rob Clark <robdclark@gmail.com>,
Sricharan R <sricharan@codeaurora.org>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Archit Taneja <architt@codeaurora.org>,
"list@263.net:IOMMU DRIVERS <iommu@lists.linux-foundation.org>,
Joerg Roedel <joro@8bytes.org>,"
<linux-arm-kernel@lists.infradead.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH v10 4/5] iommu/arm-smmu: Add the device_link between masters and smmu
Date: Fri, 16 Mar 2018 15:41:29 +0900 [thread overview]
Message-ID: <CAAFQd5AAgCE7avK=bR45Kjd=LhJ-qe+kD1otPWPaXUo7_JR65g@mail.gmail.com> (raw)
In-Reply-To: <20180314081434.30875-5-vivek.gautam@codeaurora.org>
Hi Vivek,
On Wed, Mar 14, 2018 at 5:14 PM, Vivek Gautam
<vivek.gautam@codeaurora.org> wrote:
> From: Sricharan R <sricharan@codeaurora.org>
>
> Finally add the device link between the master device and
> smmu, so that the smmu gets runtime enabled/disabled only when the
> master needs it. This is done from add_device callback which gets
> called once when the master is added to the smmu.
>
> Signed-off-by: Sricharan R <sricharan@codeaurora.org>
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> Reviewed-by: Tomasz Figa <tfiga@chromium.org>
> ---
>
> Changes since v9:
> - Using device_link_del_dev() to delete the device link, instead of
> doing it in two steps - device_link_find() to first find the link, and
> then calling device_link_del().
>
> drivers/iommu/arm-smmu.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
> index 56a04ae80bf3..4cf270ffd449 100644
> --- a/drivers/iommu/arm-smmu.c
> +++ b/drivers/iommu/arm-smmu.c
> @@ -1460,10 +1460,31 @@ static int arm_smmu_add_device(struct device *dev)
>
> iommu_device_link(&smmu->iommu, dev);
>
> + if (pm_runtime_enabled(smmu->dev)) {
> + struct device_link *link;
> +
> + /*
> + * Establish the link between smmu and master, so that the
> + * smmu gets runtime enabled/disabled as per the master's
> + * needs.
> + */
> + link = device_link_add(dev, smmu->dev, DL_FLAG_PM_RUNTIME);
> + if (!link) {
> + dev_warn(smmu->dev,
> + "Unable to add link to the consumer %s\n",
> + dev_name(dev));
> + ret = -ENODEV;
> + goto out_unlink;
> + }
> + }
If it's an error, we should use dev_err(). Also, as per Robin's
comment for v9 could we make it as follows?
if (pm_runtime_enabled(smmu->dev) &&
!device_link_add(dev, smmu->dev, DL_FLAG_PM_RUNTIME)) {
dev_err(smmu->dev,
"Unable to add link to the consumer %s\n",
dev_name(dev));
ret = -ENODEV;
goto out_unlink;
}
Best regards,
Tomasz
next prev parent reply other threads:[~2018-03-16 6:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 8:14 [PATCH v10 0/5] iommu/arm-smmu: Add runtime pm/sleep support Vivek Gautam
2018-03-14 8:14 ` [PATCH v10 1/5] driver core: Delete the link between two given devices Vivek Gautam
2018-03-14 8:14 ` [PATCH v10 2/5] iommu/arm-smmu: Add pm_runtime/sleep ops Vivek Gautam
2018-03-14 8:14 ` [PATCH v10 3/5] iommu/arm-smmu: Invoke pm_runtime during probe, add/remove device Vivek Gautam
2018-03-14 8:14 ` [PATCH v10 4/5] iommu/arm-smmu: Add the device_link between masters and smmu Vivek Gautam
2018-03-16 6:41 ` Tomasz Figa [this message]
2018-03-14 8:14 ` [PATCH v10 5/5] iommu/arm-smmu: Add support for qcom,smmu-v2 variant Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAFQd5AAgCE7avK=bR45Kjd=LhJ-qe+kD1otPWPaXUo7_JR65g@mail.gmail.com' \
--to=tfiga@chromium.org \
--cc=architt@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mark.rutland@arm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robdclark@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=sricharan@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).