From: Tomasz Figa <tfiga@chromium.org>
To: Hui Fang <hui.fang@nxp.com>
Cc: Anle Pan <anle.pan@nxp.com>,
"m.szyprowski@samsung.com" <m.szyprowski@samsung.com>,
"mchehab@kernel.org" <mchehab@kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jindong Yue <jindong.yue@nxp.com>,
Xuegang Liu <xuegang.liu@nxp.com>, Xu Yang <xu.yang_2@nxp.com>
Subject: Re: [EXT] Re: [PATCH] media: videobuf2-dma-sg: limit the sg segment size
Date: Wed, 13 Sep 2023 18:44:15 +0900 [thread overview]
Message-ID: <CAAFQd5BQ+FsuKipxE-yh3P-NbPdc_U=FHp7PBkWY-xunxthKuA@mail.gmail.com> (raw)
In-Reply-To: <DB9PR04MB9284A1DAB3C642C57298893A87F0A@DB9PR04MB9284.eurprd04.prod.outlook.com>
On Wed, Sep 13, 2023 at 6:14 PM Hui Fang <hui.fang@nxp.com> wrote:
>
> On Tue, Sep 12, 2023 at 16:52 PM Tomasz Figa <tfiga@chromium.org> wrote:
> > Right. You may want to try modifying vb2_dma_sg_alloc_compacted() to use
> > dma_alloc_pages() instead of alloc_pages().
>
> Thanks for your suggestion, it works. And it's a better resolution since no need
> an extra copy from high buffer to low buffer.
Great to hear! Could you submit a patch? Would appreciate adding
Suggested-by: Tomasz Figa <tfiga@chromium.org>
above the Signed-off-by line if you don't mind. Thanks.
Best regards,
Tomasz
next prev parent reply other threads:[~2023-09-13 9:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-28 7:54 [PATCH] media: videobuf2-dma-sg: limit the sg segment size Anle Pan
2023-08-29 10:03 ` Tomasz Figa
2023-08-29 11:14 ` Robin Murphy
2023-08-29 15:04 ` Christoph Hellwig
2023-08-30 3:47 ` Tomasz Figa
2023-08-30 14:33 ` Christoph Hellwig
2023-08-30 16:43 ` Jason Gunthorpe
2023-08-31 12:35 ` Christoph Hellwig
2023-08-31 15:32 ` Jason Gunthorpe
2023-09-01 6:10 ` Christoph Hellwig
2023-09-01 14:26 ` Jason Gunthorpe
[not found] ` <DB9PR04MB92841D8BC1122D5A4210F78987E6A@DB9PR04MB9284.eurprd04.prod.outlook.com>
2023-08-30 13:41 ` [EXT] " Robin Murphy
2023-08-30 3:59 ` Tomasz Figa
2023-09-06 8:52 ` Hans Verkuil
2023-09-06 9:26 ` Tomasz Figa
2023-09-06 9:43 ` Hans Verkuil
2023-08-30 8:50 ` Hui Fang
2023-08-30 9:28 ` Tomasz Figa
2023-09-04 7:10 ` [EXT] " Hui Fang
2023-09-05 3:43 ` Tomasz Figa
2023-09-06 8:16 ` Hui Fang
2023-09-06 9:28 ` Tomasz Figa
2023-09-11 6:13 ` Hui Fang
2023-09-12 2:22 ` Tomasz Figa
2023-09-12 7:01 ` Hui Fang
2023-09-12 7:10 ` Tomasz Figa
2023-09-12 7:43 ` Hui Fang
2023-09-12 7:51 ` Tomasz Figa
2023-09-13 9:13 ` Hui Fang
2023-09-13 9:44 ` Tomasz Figa [this message]
2023-09-13 13:16 ` Hui Fang
2023-09-18 2:28 ` Hui Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAFQd5BQ+FsuKipxE-yh3P-NbPdc_U=FHp7PBkWY-xunxthKuA@mail.gmail.com' \
--to=tfiga@chromium.org \
--cc=anle.pan@nxp.com \
--cc=hui.fang@nxp.com \
--cc=jindong.yue@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=mchehab@kernel.org \
--cc=xu.yang_2@nxp.com \
--cc=xuegang.liu@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).