From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D998C004D4 for ; Thu, 19 Jan 2023 20:36:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229910AbjASUgM (ORCPT ); Thu, 19 Jan 2023 15:36:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229775AbjASUgI (ORCPT ); Thu, 19 Jan 2023 15:36:08 -0500 Received: from mail-pf1-x432.google.com (mail-pf1-x432.google.com [IPv6:2607:f8b0:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A8089AAB0 for ; Thu, 19 Jan 2023 12:36:05 -0800 (PST) Received: by mail-pf1-x432.google.com with SMTP id z3so2445146pfb.2 for ; Thu, 19 Jan 2023 12:36:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=geNr1E6VfBEr6rNDuNt5xZRGvMS8AANNdGRpDjlpRuU=; b=Iz5otatIxfEwMlDKOapnMMO592tFYuufDvsRgepbG9Lwd4QGlufz5Dl1lYejAJruJq 33/30rrzenH9TRxIlCwvCDHh1iqm1pIZOAxmy+FKb6tZhdlMuWznkISuuSDd7d0oq6zg RJ7JJJq26Mrw5WNdK8ic6xb9E74jiaVpl3Tes0OdEvZoxOwjsuEbFeM08H0sgxXZe9U1 zr0+8YSVECHB0GYTME1UzvOcbTbZ2dRJIPlOZ6euEk6w8iFtuAW+Cv9xFFz2N31nMN7G ZcGaeLWfARNbBlBsNW+Cq8XSbrVzVMR2/TlJZpqqsj3z1nvE3nsLxTGbaodzsE93w9cA QGWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=geNr1E6VfBEr6rNDuNt5xZRGvMS8AANNdGRpDjlpRuU=; b=QPozxEVZnm7cubUlQsvo0Yo0oz5t0OgfPFr668wy3yR1iJIkpoccKHIZHe/s98QnA8 1i1MiNOyRkIrq41JMK8MVY7Px2kirdrFNTa2J0+NLd173CtW9Iw3xj16Wz9HqiDLkXyo Zzi/OM5/OtFwQqLqWv95xJlLlAmHLwp2eN9+MRa3AxmsXisZ/iLwX0/BkTkTA43BqDwI Bu8ydrHWaij/qU3ov0qaDEd4xCfuwbsj/olYODxUapyjI5fXs4MNTH4naJ3uk79S1fuu CF0SN5ZUP2RmLu0swjRSIuYULkZl/LAhjfpxD8UpJ4r5cU7VYgv+UfcCZbC3OVXhaSBx j0dg== X-Gm-Message-State: AFqh2kq1Xurw5FbLuVQOvBrr6wfmraT5nEn2EhjISbDdGYh5ORLT4rMa B+EpAmwr3M98u1Mimixa5aGkdvc56015J2Tx7QHhhg== X-Google-Smtp-Source: AMrXdXuXWIkBvjeABJVhFjJg/BU1DXB+KocDp8hkIozqTT9DBpOmCElWzlT4csdohivH2Pe8ccTDvANtE0IQdxcA/rw= X-Received: by 2002:a63:2447:0:b0:4be:c5ec:93e1 with SMTP id k68-20020a632447000000b004bec5ec93e1mr1074292pgk.213.1674160564313; Thu, 19 Jan 2023 12:36:04 -0800 (PST) MIME-Version: 1.0 References: <20221214194056.161492-1-michael.roth@amd.com> <20221214194056.161492-53-michael.roth@amd.com> In-Reply-To: <20221214194056.161492-53-michael.roth@amd.com> From: Dionna Amalie Glaze Date: Thu, 19 Jan 2023 12:35:52 -0800 Message-ID: Subject: Re: [PATCH RFC v7 52/64] KVM: SVM: Provide support for SNP_GUEST_REQUEST NAE event To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, wanpengli@tencent.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, dgilbert@redhat.com, jarkko@kernel.org, ashish.kalra@amd.com, harald@profian.com, Brijesh Singh Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > + > +static void snp_handle_guest_request(struct vcpu_svm *svm, gpa_t req_gpa, gpa_t resp_gpa) > +{ Both regular, > + > +static void snp_handle_ext_guest_request(struct vcpu_svm *svm, gpa_t req_gpa, gpa_t resp_gpa) > +{ and extended guest requests should be subject to rate limiting, since they take a lock on the shared resource that is the AMD-SP (psp?). I proposed a mechanism with empirically chosen defaults in [PATCH v2 0/2] kvm: sev: Add SNP guest request throttling [PATCH v2 1/2] kvm: sev: Add SEV-SNP guest request throttling [PATCH v2 2/2] kvm: sev: If ccp is busy, report throttled to guest http://129.79.113.48/hypermail/linux/kernel/2211.2/03107.html http://129.79.113.48/hypermail/linux/kernel/2211.2/03110.html http://129.79.113.48/hypermail/linux/kernel/2211.2/03111.html But I don't see these on lore. Would you like me to repost these? -- -Dionna Glaze, PhD (she/her)