From: Yury Norov <yury.norov@gmail.com>
To: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
lizefan@huawei.com, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
josh@joshtriplett.org, Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>,
fweisbec@gmail.com, Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 3/8] lib: bitmap: fold nbits into region struct
Date: Tue, 26 Jan 2021 19:08:05 -0800 [thread overview]
Message-ID: <CAAH8bW8efPcdd9SoYhhVAujQcg7SUQe8sOrpCfG6bNDCB-bSCg@mail.gmail.com> (raw)
In-Reply-To: <20210126171141.122639-4-paul.gortmaker@windriver.com>
On Tue, Jan 26, 2021 at 9:12 AM Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
>
> This will reduce parameter passing and enable using nbits as part
> of future dynamic region parameter parsing.
>
> Cc: Yury Norov <yury.norov@gmail.com>
> Cc: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Suggested-by: Yury Norov <yury.norov@gmail.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
> ---
> lib/bitmap.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/lib/bitmap.c b/lib/bitmap.c
> index 75006c4036e9..162e2850c622 100644
> --- a/lib/bitmap.c
> +++ b/lib/bitmap.c
> @@ -487,24 +487,24 @@ EXPORT_SYMBOL(bitmap_print_to_pagebuf);
>
> /*
> * Region 9-38:4/10 describes the following bitmap structure:
> - * 0 9 12 18 38
> - * .........****......****......****......
> - * ^ ^ ^ ^
> - * start off group_len end
> + * 0 9 12 18 38 N
> + * .........****......****......****..................
> + * ^ ^ ^ ^ ^
> + * start off group_len end nbits
> */
> struct region {
> unsigned int start;
> unsigned int off;
> unsigned int group_len;
> unsigned int end;
> + unsigned int nbits;
> };
>
> -static int bitmap_set_region(const struct region *r,
> - unsigned long *bitmap, int nbits)
> +static int bitmap_set_region(const struct region *r, unsigned long *bitmap)
> {
> unsigned int start;
>
> - if (r->end >= nbits)
> + if (r->end >= r->nbits)
> return -ERANGE;
>
> for (start = r->start; start <= r->end; start += r->group_len)
> @@ -640,7 +640,8 @@ int bitmap_parselist(const char *buf, unsigned long *maskp, int nmaskbits)
> struct region r;
> long ret;
>
> - bitmap_zero(maskp, nmaskbits);
> + r.nbits = nmaskbits;
> + bitmap_zero(maskp, r.nbits);
>
> while (buf) {
> buf = bitmap_find_region(buf);
> @@ -655,7 +656,7 @@ int bitmap_parselist(const char *buf, unsigned long *maskp, int nmaskbits)
> if (ret)
> return ret;
>
> - ret = bitmap_set_region(&r, maskp, nmaskbits);
> + ret = bitmap_set_region(&r, maskp);
> if (ret)
> return ret;
> }
> --
> 2.17.1
Acked-by: Yury Norov <yury.norov@gmail.com>
next prev parent reply other threads:[~2021-01-27 6:47 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-26 17:11 [PATCH v3 0/8] support for bitmap (and hence CPU) list "N" abbreviation Paul Gortmaker
2021-01-26 17:11 ` [PATCH 1/8] lib: test_bitmap: clearly separate ERANGE from EINVAL tests Paul Gortmaker
2021-01-26 21:04 ` Andy Shevchenko
2021-01-27 7:21 ` Paul Gortmaker
2021-01-26 17:11 ` [PATCH 2/8] lib: test_bitmap: add more start-end:offset/len tests Paul Gortmaker
2021-01-26 21:11 ` Andy Shevchenko
2021-01-27 3:03 ` Yury Norov
2021-01-26 17:11 ` [PATCH 3/8] lib: bitmap: fold nbits into region struct Paul Gortmaker
2021-01-26 21:16 ` Andy Shevchenko
2021-01-26 21:18 ` Andy Shevchenko
2021-01-27 8:02 ` Paul Gortmaker
2021-01-28 0:47 ` Yury Norov
2021-01-28 10:17 ` Andy Shevchenko
2021-01-27 3:08 ` Yury Norov [this message]
2021-01-26 17:11 ` [PATCH 4/8] lib: bitmap: move ERANGE check from set_region to check_region Paul Gortmaker
2021-01-26 21:19 ` Andy Shevchenko
2021-01-27 3:12 ` Yury Norov
2021-01-26 17:11 ` [PATCH 5/8] lib: bitmap_getnum: separate arg into region and field Paul Gortmaker
2021-01-26 21:23 ` Andy Shevchenko
2021-01-27 2:58 ` Yury Norov
2021-01-27 8:38 ` Paul Gortmaker
2021-01-26 17:11 ` [PATCH 6/8] lib: bitmap: support "N" as an alias for size of bitmap Paul Gortmaker
2021-01-26 21:37 ` Andy Shevchenko
2021-01-26 21:41 ` Andy Shevchenko
2021-01-27 17:57 ` Yury Norov
2021-01-27 8:20 ` Paul Gortmaker
2021-01-26 17:11 ` [PATCH 7/8] lib: test_bitmap: add tests for "N" alias Paul Gortmaker
2021-01-26 17:11 ` [PATCH 8/8] rcu: deprecate "all" option to rcu_nocbs= Paul Gortmaker
2021-01-26 21:36 ` Yury Norov
2021-01-26 22:17 ` Paul E. McKenney
2021-01-26 22:27 ` [PATCH v3 0/8] support for bitmap (and hence CPU) list "N" abbreviation Yury Norov
2021-01-27 9:12 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAH8bW8efPcdd9SoYhhVAujQcg7SUQe8sOrpCfG6bNDCB-bSCg@mail.gmail.com \
--to=yury.norov@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=fweisbec@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=lizefan@huawei.com \
--cc=mingo@kernel.org \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).