From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752399AbcDNG3t (ORCPT ); Thu, 14 Apr 2016 02:29:49 -0400 Received: from mail-yw0-f193.google.com ([209.85.161.193]:34443 "EHLO mail-yw0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751430AbcDNG3s (ORCPT ); Thu, 14 Apr 2016 02:29:48 -0400 MIME-Version: 1.0 X-Originating-IP: [88.146.242.226] In-Reply-To: <20160413224916.GH7765@piout.net> References: <570EAE8B.7010706@nkgroup.cz> <20160413224916.GH7765@piout.net> Date: Thu, 14 Apr 2016 08:29:47 +0200 Message-ID: Subject: Re: [PATCH] rtc: support for rv4162c7 From: Tomas Krcka To: Alexandre Belloni Cc: rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, that's correct, but idetification of this chip is rv4162c7 so i2c_match_id() returns NULL. If it's there any workaround, how the chip can be detected automatically then OK, but without this patch it doesn't work for me. 2016-04-14 0:49 GMT+02:00 Alexandre Belloni : > Hi, > > On 13/04/2016 at 22:39:39 +0200, Tomas Krcka wrote : >> This patch is for support of rv4162c7 RTC chip. >> The device has same parameters as rv4162, but with different identification. >> Tested with PhyTec module AM335x. >> > > Well, technically, it is an rv4162. rv4162-c7 is the only available one. > So this patch is not necessary. > >> Signed-off-by: Tomas Krcka >> >> --- >> drivers/rtc/rtc-m41t80.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c >> index d107a8e..1aa57d8 100644 >> --- a/drivers/rtc/rtc-m41t80.c >> +++ b/drivers/rtc/rtc-m41t80.c >> @@ -81,6 +81,7 @@ static const struct i2c_device_id m41t80_id[] = { >> { "m41st85", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ }, >> { "m41st87", M41T80_FEATURE_HT | M41T80_FEATURE_BL | M41T80_FEATURE_SQ }, >> { "rv4162", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT }, >> + { "rv4162c7", M41T80_FEATURE_SQ | M41T80_FEATURE_WD | M41T80_FEATURE_SQ_ALT }, >> { } >> }; >> MODULE_DEVICE_TABLE(i2c, m41t80_id); >> -- 1.9.1 >> > > -- > Alexandre Belloni, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com