From: Jeff Chua <jeff.chua.linux@gmail.com>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: lkml <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: can't boot with reiserfs on linux-4.6.0+
Date: Thu, 26 May 2016 15:20:45 +0800 [thread overview]
Message-ID: <CAAJw_ZuTM5aU6Hh_ttOwxVxXv2SsOdkF5mqD8Wddn7bLi-1aoQ@mail.gmail.com> (raw)
In-Reply-To: <20160525155131.GF14480@ZenIV.linux.org.uk>
On Wed, May 25, 2016 at 11:51 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Wed, May 25, 2016 at 05:30:22PM +0800, Jeff Chua wrote:
>> On Wed, May 25, 2016 at 2:37 AM, Al Viro <viro@zeniv.linux.org.uk> wrote:
>> > On Tue, May 24, 2016 at 04:59:02PM +0100, Al Viro wrote:
>> >
>> >> Umm... Any chance of getting the function names to go with the addresses?
>> >> I'll try to reproduce it here, but the things would be easier with that
>> >> information...
>> >
>> > See if this fixes your reproducer.
>> >
>> > diff --git a/fs/xattr.c b/fs/xattr.c
>> > index b11945e..49b8eab 100644
>> > --- a/fs/xattr.c
>> > +++ b/fs/xattr.c
>> > @@ -667,6 +667,9 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name)
>> > {
>> > const struct xattr_handler *handler;
>> >
>> > + if (!handlers)
>> > + return NULL;
>> > +
>> > if (!*name)
>> > return NULL;
>> >
>>
>> Tried, but doesn't work.
>
> D'oh... Since "vfs: Distinguish between full xattr names and proper prefixes"
> we really need to return ERR_PTR() there (and I even have a patch from Andreas
> fixing that if (!*name) return NULL; in my queue). Combined delta to test
> (that'll go as two commits, one mine, one his):
>
Al, Linus,
Great that worked! And I see the patch is already in Linus's tree.
Thanks for the quick response and fixes.
Jeff.
> diff --git a/fs/xattr.c b/fs/xattr.c
> index b11945e..fc81e77 100644
> --- a/fs/xattr.c
> +++ b/fs/xattr.c
> @@ -655,6 +655,7 @@ strcmp_prefix(const char *a, const char *a_prefix)
> * operations to the correct xattr_handler.
> */
> #define for_each_xattr_handler(handlers, handler) \
> + if (handlers) \
> for ((handler) = *(handlers)++; \
> (handler) != NULL; \
> (handler) = *(handlers)++)
> @@ -668,7 +669,7 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name)
> const struct xattr_handler *handler;
>
> if (!*name)
> - return NULL;
> + return ERR_PTR(-EINVAL);
>
> for_each_xattr_handler(handlers, handler) {
> const char *n;
next prev parent reply other threads:[~2016-05-26 7:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 14:10 can't boot with reiserfs on linux-4.6.0+ Jeff Chua
2016-05-24 15:59 ` Al Viro
2016-05-24 16:10 ` Linus Torvalds
2016-05-25 8:38 ` Jeff Chua
2016-05-24 18:37 ` Al Viro
2016-05-25 9:30 ` Jeff Chua
2016-05-25 15:51 ` Linus Torvalds
2016-05-25 15:51 ` Al Viro
2016-05-26 7:20 ` Jeff Chua [this message]
[not found] <017b01d1b721$d1686aa0$74393fe0$@alibaba-inc.com>
2016-05-26 7:46 ` Hillf Danton
2016-05-26 22:49 ` Jeff Chua
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAJw_ZuTM5aU6Hh_ttOwxVxXv2SsOdkF5mqD8Wddn7bLi-1aoQ@mail.gmail.com \
--to=jeff.chua.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).