From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757381AbbLBBOe (ORCPT ); Tue, 1 Dec 2015 20:14:34 -0500 Received: from mail-wm0-f41.google.com ([74.125.82.41]:36408 "EHLO mail-wm0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753010AbbLBBOc (ORCPT ); Tue, 1 Dec 2015 20:14:32 -0500 MIME-Version: 1.0 In-Reply-To: <20151202004623.GX23396@atomide.com> References: <1449013103-23238-1-git-send-email-tony@atomide.com> <1449013103-23238-11-git-send-email-tony@atomide.com> <20151202004623.GX23396@atomide.com> From: Matthijs van Duin Date: Wed, 2 Dec 2015 02:14:11 +0100 Message-ID: Subject: Re: [PATCH 10/10] ARM: dts: Fix dm814x pinctrl address and mask To: Tony Lindgren Cc: lkml , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Brian Hutchinson , Delio Brignoli , Neil Armstrong , Philipp Rosenberger Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2 December 2015 at 01:46, Tony Lindgren wrote: > Ouch. We should probably have separate PIN_INPUT_3V3 and PIN_OUTPUT_3V3 > dts macros that ensure that? Can't we just keep bit 18 out of the function mask? The bootloader should already have made sure all pins have bit 18 set (and bit 19 set to correct values after ROM mucked them up, see advisory 2.1.88), so all that needs to be done is avoid touching them. Are the power savings from disabling unnecessary inputs significant enough to spend any headache on it? Matthijs