From: Gary Bisson <gary.bisson@boundarydevices.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Fabio Estevam <fabio.estevam@nxp.com>,
Tony Lindgren <tony@atomide.com>, Shawn Guo <shawnguo@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups
Date: Tue, 7 Mar 2017 18:26:12 +0100 [thread overview]
Message-ID: <CAAMH-ysO7SWYJ3dWjQODXBDEvfnRf09mefWBeDgeWH=MPSd+Ww@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5BKdP+A1JdJxkRXPvZcGGsW2k65nsseDvmFguaM8i18xw@mail.gmail.com>
Hi Fabio,
On Tue, Mar 7, 2017 at 6:19 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Gary,
>
> On Mon, Jan 2, 2017 at 4:20 PM, Gary Bisson
> <gary.bisson@boundarydevices.com> wrote:
>> Now using group_desc structure instead of imx_pin_group.
>>
>> Also leveraging generic functions to retrieve groups count/name/pins.
>>
>> The imx_free_pingroups function can be removed since it is now handled by
>> the core driver during unregister.
>>
>> Finally the device tree parsing is moved after the pinctrl driver registration
>> since this latter initializes the radix trees.
>>
>> Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com>
>
> This patch is in 4.11-rc1 now and it causes a regression on the hog group:
>
> [ 0.061005] imx6q-pinctrl 20e0000.iomuxc: unable to find group for
> node hoggrp
>
> The hog pins can no longer be initialized.
>
> Could you take a look, please?
No it isn't because of the use of radix but instead of:
http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=950b0d91dc10
It has been discussed here:
https://lkml.org/lkml/2017/2/28/140
Tony offered a patch in that thread which works. Tony, have you
submitted it yet?
Regards,
Gary
next prev parent reply other threads:[~2017-03-07 20:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 18:20 [PATCH 0/2] pinctrl: imx: use generic pinctrl helpers Gary Bisson
2017-01-02 18:20 ` [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups Gary Bisson
2017-01-02 21:41 ` Linus Walleij
2017-03-07 17:19 ` Fabio Estevam
2017-03-07 17:26 ` Gary Bisson [this message]
2017-03-07 17:37 ` Fabio Estevam
2017-03-07 17:54 ` Tony Lindgren
2017-03-15 9:46 ` Linus Walleij
2017-03-29 13:33 ` Fabio Estevam
2017-03-29 16:26 ` Tony Lindgren
2017-03-30 9:05 ` Linus Walleij
2017-03-30 15:05 ` Tony Lindgren
2017-01-02 18:20 ` [PATCH 2/2] pinctrl: imx: use generic pinmux helpers for managing functions Gary Bisson
2017-01-02 21:42 ` Linus Walleij
2017-01-02 21:43 ` [PATCH 0/2] pinctrl: imx: use generic pinctrl helpers Linus Walleij
2017-01-02 22:00 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAMH-ysO7SWYJ3dWjQODXBDEvfnRf09mefWBeDgeWH=MPSd+Ww@mail.gmail.com' \
--to=gary.bisson@boundarydevices.com \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).