From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22ADAC433DF for ; Tue, 19 May 2020 15:13:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EF3472081A for ; Tue, 19 May 2020 15:13:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589901182; bh=Qtbu//gwpsRgyyl9L3XkraCEI0EULn3K3RbouB9xCeQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=pfgnFj76KgDVKBohj4VpuZL8ZHeUBirVxm4tBLDyFnsMXAT4tt3vdzdkf/sgDUSRG 5Y5iQ5+KiXXGHdes4yiL2LLIP0ZqTmyVIZ7ECOUPVTZ++nZtaFppv55dp9dj/O3zAp OC1DKYyPNFUeBZT0jlw+SAnEcl8BiBN85f0dtJ5w= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729246AbgESPNB (ORCPT ); Tue, 19 May 2020 11:13:01 -0400 Received: from mail.kernel.org ([198.145.29.99]:60766 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728775AbgESPNA (ORCPT ); Tue, 19 May 2020 11:13:00 -0400 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D84832083E for ; Tue, 19 May 2020 15:12:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589901180; bh=Qtbu//gwpsRgyyl9L3XkraCEI0EULn3K3RbouB9xCeQ=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=jpt+oYEr/qLu8YKDUQL8P9cwVuslDQk/015dkdkhmsDRvEfaZtFD4uA1yKlYIYne8 y47NLk9GyDnv+rTz3Jeuatg8RFxszmBvD4CUBHFaLvXDWHBGCz6HCGmaM6g1RiVCJp 2AeoGrgrAa+hzL2tngLpK22kKiZ60Pq1WRzfandA= Received: by mail-ed1-f43.google.com with SMTP id i16so7339446edv.1 for ; Tue, 19 May 2020 08:12:59 -0700 (PDT) X-Gm-Message-State: AOAM532NPoB+IT9MndIKrDOVQY5ryr5oABlQnJNwZvP+kOFN6DdHl4kX LsuCDRhbiKIkeLKhEpkJev8RkfcvGHezIT1HDg== X-Google-Smtp-Source: ABdhPJyFxb862sEE7yUUw8vzjALBePQs+s7LW5KIAbQcfYVO9A/nJbgo93p98Hnk05Kl1tbTOxD4nL6FFB/3FC4K5Eo= X-Received: by 2002:a50:e1c5:: with SMTP id m5mr12614504edl.47.1589901178288; Tue, 19 May 2020 08:12:58 -0700 (PDT) MIME-Version: 1.0 References: <20200519094045.2447940-1-enric.balletbo@collabora.com> In-Reply-To: <20200519094045.2447940-1-enric.balletbo@collabora.com> From: Chun-Kuang Hu Date: Tue, 19 May 2020 23:12:46 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables To: Enric Balletbo i Serra Cc: linux-kernel , Collabora Kernel ML , Matthias Brugger , Nicolas Boichat , Hsin-Yi Wang , Chun-Kuang Hu , Daniel Vetter , David Airlie , Philipp Zabel , DRI Development , Linux ARM , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Enric: Enric Balletbo i Serra =E6=96=BC 2020=E5=B9= =B45=E6=9C=8819=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8B=E5=8D=885:40=E5=AF=AB= =E9=81=93=EF=BC=9A > > There are some `static const u8` variables that are not used, this > triggers a warning building with `make W=3D1`, it is safe to remove them, > so do it and make the compiler more happy. > Reviewed-by: Chun-Kuang Hu > Signed-off-by: Enric Balletbo i Serra > --- > > .../gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c | 48 ------------------- > 1 file changed, 48 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c b/drivers/gpu= /drm/mediatek/mtk_mt8173_hdmi_phy.c > index 1c3575372230..827b93786fac 100644 > --- a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c > +++ b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c > @@ -107,54 +107,6 @@ > #define RGS_HDMITX_5T1_EDG (0xf << 4) > #define RGS_HDMITX_PLUG_TST BIT(0) > > -static const u8 PREDIV[3][4] =3D { > - {0x0, 0x0, 0x0, 0x0}, /* 27Mhz */ > - {0x1, 0x1, 0x1, 0x1}, /* 74Mhz */ > - {0x1, 0x1, 0x1, 0x1} /* 148Mhz */ > -}; > - > -static const u8 TXDIV[3][4] =3D { > - {0x3, 0x3, 0x3, 0x2}, /* 27Mhz */ > - {0x2, 0x1, 0x1, 0x1}, /* 74Mhz */ > - {0x1, 0x0, 0x0, 0x0} /* 148Mhz */ > -}; > - > -static const u8 FBKSEL[3][4] =3D { > - {0x1, 0x1, 0x1, 0x1}, /* 27Mhz */ > - {0x1, 0x0, 0x1, 0x1}, /* 74Mhz */ > - {0x1, 0x0, 0x1, 0x1} /* 148Mhz */ > -}; > - > -static const u8 FBKDIV[3][4] =3D { > - {19, 24, 29, 19}, /* 27Mhz */ > - {19, 24, 14, 19}, /* 74Mhz */ > - {19, 24, 14, 19} /* 148Mhz */ > -}; > - > -static const u8 DIVEN[3][4] =3D { > - {0x2, 0x1, 0x1, 0x2}, /* 27Mhz */ > - {0x2, 0x2, 0x2, 0x2}, /* 74Mhz */ > - {0x2, 0x2, 0x2, 0x2} /* 148Mhz */ > -}; > - > -static const u8 HTPLLBP[3][4] =3D { > - {0xc, 0xc, 0x8, 0xc}, /* 27Mhz */ > - {0xc, 0xf, 0xf, 0xc}, /* 74Mhz */ > - {0xc, 0xf, 0xf, 0xc} /* 148Mhz */ > -}; > - > -static const u8 HTPLLBC[3][4] =3D { > - {0x2, 0x3, 0x3, 0x2}, /* 27Mhz */ > - {0x2, 0x3, 0x3, 0x2}, /* 74Mhz */ > - {0x2, 0x3, 0x3, 0x2} /* 148Mhz */ > -}; > - > -static const u8 HTPLLBR[3][4] =3D { > - {0x1, 0x1, 0x0, 0x1}, /* 27Mhz */ > - {0x1, 0x2, 0x2, 0x1}, /* 74Mhz */ > - {0x1, 0x2, 0x2, 0x1} /* 148Mhz */ > -}; > - > static int mtk_hdmi_pll_prepare(struct clk_hw *hw) > { > struct mtk_hdmi_phy *hdmi_phy =3D to_mtk_hdmi_phy(hw); > -- > 2.26.2 >