Re: [PATCH v3 02/15] dt-bindings: mediatek: add vdosys1 MERGE definition for mt8195

Re: [PATCH v3 02/15] dt-bindings: mediatek: add vdosys1 MERGE definition for mt8195

[Chun-Kuang Hu]

Hi, Nancy:

Nancy.Lin <nancy.lin@mediatek.com> 於 2021年8月18日 週三 下午5:18寫道：
>
> Add vdosys1 MERGE definition.
>
> Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
> ---
>  .../devicetree/bindings/display/mediatek/mediatek,merge.yaml    | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
> index 1a27b037086b..ba1e0c837988 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,merge.yaml
> @@ -23,6 +23,8 @@ properties:
>            - const: mediatek,mt8173-disp-merge
>        - items:
>            - const: mediatek,mt8195-disp-merge
> +      - items:
> +          - const: mediatek,mt8195-vdo1-merge

I don't know why create a new merge for mt8195. Provide more
information about the difference of these two merge.

Regards,
Chun-Kuang.

>
>    reg:
>      maxItems: 1
> --
> 2.18.0
>

Re: [PATCH v3 15/15] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

[Chun-Kuang Hu]

Hi, Nancy:

Nancy.Lin <nancy.lin@mediatek.com> 於 2021年8月18日 週三 下午5:18寫道：
>
> Add driver data of mt8195 vdosys1 to mediatek-drm and modify drm for
> multi-mmsys support. The two mmsys (vdosys0 and vdosys1) will bring
> up two drm drivers, only one drm driver register as the drm device.
> Each drm driver binds its own component. The first bind drm driver
> will allocate the drm device, and the last bind drm driver registers
> the drm device to drm core. Each crtc path is created with the
> corresponding drm driver data.

Separate this patch to two patch. One is support two mmsys, and
another one is support mt8195 vdosys1.

Regards,
Chun-Kuang.

>
> Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_disp_merge.c   |   4 +
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.c     |  25 +-
>  drivers/gpu/drm/mediatek/mtk_drm_crtc.h     |   3 +-
>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c |  15 +
>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.h |   1 +
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c      | 372 ++++++++++++++++----
>  drivers/gpu/drm/mediatek/mtk_drm_drv.h      |   8 +-
>  7 files changed, 354 insertions(+), 74 deletions(-)
>
>

Re: [PATCH v3 15/15] drm/mediatek: add mediatek-drm of vdosys1 support for MT8195

[Chun-Kuang Hu]

Hi, Nancy:

Nancy.Lin <nancy.lin@mediatek.com> 於 2021年8月18日 週三 下午5:18寫道：
>
> Add driver data of mt8195 vdosys1 to mediatek-drm and modify drm for
> multi-mmsys support. The two mmsys (vdosys0 and vdosys1) will bring
> up two drm drivers, only one drm driver register as the drm device.
> Each drm driver binds its own component. The first bind drm driver
> will allocate the drm device, and the last bind drm driver registers
> the drm device to drm core. Each crtc path is created with the
> corresponding drm driver data.
>
> Signed-off-by: Nancy.Lin <nancy.lin@mediatek.com>
>
>
> +static const struct mtk_ddp_comp_funcs ddp_ovl_adaptor = {
> +       .clk_enable = mtk_ethdr_clk_enable,
> +       .clk_disable = mtk_ethdr_clk_disable,
> +       .config = mtk_ethdr_config,
> +       .start = mtk_ethdr_start,
> +       .stop = mtk_ethdr_stop,
> +       .layer_nr = mtk_ethdr_layer_nr,
> +       .layer_config = mtk_ethdr_layer_config,
> +       .enable_vblank = mtk_ethdr_enable_vblank,
> +       .disable_vblank = mtk_ethdr_disable_vblank,
> +};

I think ethdr is inside the group of ovl_adpator. I preter this
function is implemented by ovl_adaptor, and ovl_adaptor control rdma,
merge, ethdr.

Regards,
Chun-Kuang.

> +
>