From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 816F0C4724C for ; Fri, 1 May 2020 13:22:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59655208D6 for ; Fri, 1 May 2020 13:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339327; bh=FiimbkqFnjmC2xnhT8xRMf1+qKdE7XRvufOkGvNa1FY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=EWYmvXz0DVM2si1paogp9JSSqtTZpao5Oa65S7l784/x2TkiayI/B2/suDtBWxeW/ RcJdFloSMU6851xTixPkEMKTQKhjAEwUsNIlZlM04LuoLTcgkrn97wGq7uB745TnAO b2pchcF/CWhCGjLS0Mi2Aw9pFe5oGwofbRtGktio= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728823AbgEANWG (ORCPT ); Fri, 1 May 2020 09:22:06 -0400 Received: from mail.kernel.org ([198.145.29.99]:44062 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728586AbgEANWG (ORCPT ); Fri, 1 May 2020 09:22:06 -0400 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0AF0B24956 for ; Fri, 1 May 2020 13:22:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339324; bh=FiimbkqFnjmC2xnhT8xRMf1+qKdE7XRvufOkGvNa1FY=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HvnO9yna5TWnLYTjDylC0X8aGKnLwQPuRBiXUfPqDgqolRE08Nyu2wdfMX0fvd8+t iG8YOhLdwzEm2ZMdW9ikhZn0jKNPYekjFTM7Rnd4vE913OfOTczNjFwXLfaQeXqyxM D0YwAicXXdDuWsV+9R67UUwKJC1krNgbC11iO+oE= Received: by mail-ej1-f49.google.com with SMTP id s9so7474394eju.1 for ; Fri, 01 May 2020 06:22:03 -0700 (PDT) X-Gm-Message-State: AGi0PuayWFldwx26vgwraPUdB1wzUB16TEslvpJr1ZU2Yv/j9whVyKW6 Ph7QCnaL5beDsSiAy9XV1bSPf7QDGRtU6dyrTA== X-Google-Smtp-Source: APiQypIl3gBr7lZocFLW1gar0arYtJWjboax4hKeSZ4BY9SY75ypgsnZSc5nuRVr1dbcjoOLhiO2F/63abGFRjTVv/U= X-Received: by 2002:a17:906:eb90:: with SMTP id mh16mr3169239ejb.201.1588339322257; Fri, 01 May 2020 06:22:02 -0700 (PDT) MIME-Version: 1.0 References: <20200417150614.2631786-1-enric.balletbo@collabora.com> <20200417150614.2631786-5-enric.balletbo@collabora.com> In-Reply-To: <20200417150614.2631786-5-enric.balletbo@collabora.com> From: Chun-Kuang Hu Date: Fri, 1 May 2020 21:21:48 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 4/7] drm/mediatek: mtk_dsi: Convert to bridge driver To: Enric Balletbo i Serra Cc: linux-kernel , Collabora Kernel ML , Matthias Brugger , Nicolas Boichat , Hsin-Yi Wang , Laurent Pinchart , Chun-Kuang Hu , Daniel Vetter , David Airlie , Philipp Zabel , DRI Development , Linux ARM , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Enric: Enric Balletbo i Serra =E6=96=BC 2020=E5=B9= =B44=E6=9C=8817=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=8811:06=E5=AF= =AB=E9=81=93=EF=BC=9A > > Convert mtk_dsi to a bridge driver with built-in encoder support for > compatibility with existing component drivers. > > Signed-off-by: Enric Balletbo i Serra > --- > > Changes in v3: > - Add the bridge.type. (Laurent Pinchart) > > Changes in v2: None > > drivers/gpu/drm/mediatek/mtk_dsi.c | 93 ++++++++++++++++++++++-------- > 1 file changed, 69 insertions(+), 24 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediate= k/mtk_dsi.c > index 37b8d7ffd835..869ae0a2e9f8 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dsi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c > @@ -180,6 +180,7 @@ struct mtk_dsi { > struct device *dev; > struct mipi_dsi_host host; > struct drm_encoder encoder; > + struct drm_bridge bridge; > struct drm_connector conn; > struct drm_panel *panel; > struct drm_bridge *next_bridge; > @@ -205,9 +206,9 @@ struct mtk_dsi { > const struct mtk_dsi_driver_data *driver_data; > }; > > -static inline struct mtk_dsi *encoder_to_dsi(struct drm_encoder *e) > +static inline struct mtk_dsi *bridge_to_dsi(struct drm_bridge *b) > { > - return container_of(e, struct mtk_dsi, encoder); > + return container_of(b, struct mtk_dsi, bridge); > } > > static inline struct mtk_dsi *connector_to_dsi(struct drm_connector *c) > @@ -796,32 +797,43 @@ static const struct drm_encoder_funcs mtk_dsi_encod= er_funcs =3D { > .destroy =3D mtk_dsi_encoder_destroy, > }; > > -static bool mtk_dsi_encoder_mode_fixup(struct drm_encoder *encoder, > - const struct drm_display_mode *mod= e, > - struct drm_display_mode *adjusted_= mode) > +static int mtk_dsi_create_conn_enc(struct drm_device *drm, struct mtk_ds= i *dsi); > +static void mtk_dsi_destroy_conn_enc(struct mtk_dsi *dsi); > + > +static int mtk_dsi_bridge_attach(struct drm_bridge *bridge, > + enum drm_bridge_attach_flags flags) > +{ > + struct mtk_dsi *dsi =3D bridge_to_dsi(bridge); > + > + return mtk_dsi_create_conn_enc(bridge->dev, dsi); > +} > + > +static void mtk_dsi_bridge_detach(struct drm_bridge *bridge) > { > - return true; > + struct mtk_dsi *dsi =3D bridge_to_dsi(bridge); > + > + mtk_dsi_destroy_conn_enc(dsi); > } > > -static void mtk_dsi_encoder_mode_set(struct drm_encoder *encoder, > - struct drm_display_mode *mode, > - struct drm_display_mode *adjusted) > +static void mtk_dsi_bridge_mode_set(struct drm_bridge *bridge, > + const struct drm_display_mode *mode, > + const struct drm_display_mode *adjust= ed) > { > - struct mtk_dsi *dsi =3D encoder_to_dsi(encoder); > + struct mtk_dsi *dsi =3D bridge_to_dsi(bridge); > > drm_display_mode_to_videomode(adjusted, &dsi->vm); > } > > -static void mtk_dsi_encoder_disable(struct drm_encoder *encoder) > +static void mtk_dsi_bridge_disable(struct drm_bridge *bridge) > { > - struct mtk_dsi *dsi =3D encoder_to_dsi(encoder); > + struct mtk_dsi *dsi =3D bridge_to_dsi(bridge); > > mtk_output_dsi_disable(dsi); > } > > -static void mtk_dsi_encoder_enable(struct drm_encoder *encoder) > +static void mtk_dsi_bridge_enable(struct drm_bridge *bridge) > { > - struct mtk_dsi *dsi =3D encoder_to_dsi(encoder); > + struct mtk_dsi *dsi =3D bridge_to_dsi(bridge); > > mtk_output_dsi_enable(dsi); > } > @@ -833,11 +845,12 @@ static int mtk_dsi_connector_get_modes(struct drm_c= onnector *connector) > return drm_panel_get_modes(dsi->panel, connector); > } > > -static const struct drm_encoder_helper_funcs mtk_dsi_encoder_helper_func= s =3D { > - .mode_fixup =3D mtk_dsi_encoder_mode_fixup, > - .mode_set =3D mtk_dsi_encoder_mode_set, > - .disable =3D mtk_dsi_encoder_disable, > - .enable =3D mtk_dsi_encoder_enable, > +static const struct drm_bridge_funcs mtk_dsi_bridge_funcs =3D { > + .attach =3D mtk_dsi_bridge_attach, > + .detach =3D mtk_dsi_bridge_detach, > + .disable =3D mtk_dsi_bridge_disable, > + .enable =3D mtk_dsi_bridge_enable, > + .mode_set =3D mtk_dsi_bridge_mode_set, > }; > > static const struct drm_connector_funcs mtk_dsi_connector_funcs =3D { > @@ -1123,6 +1136,34 @@ static const struct mipi_dsi_host_ops mtk_dsi_ops = =3D { > .transfer =3D mtk_dsi_host_transfer, > }; > > +static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *= dsi) > +{ > + int ret; > + > + ret =3D drm_encoder_init(drm, &dsi->encoder, &mtk_dsi_encoder_fun= cs, > + DRM_MODE_ENCODER_DSI, NULL); I'm a bit confused here. drm_encoder_init() exist here and in mtk_dsi_create_conn_enc(). Do you plan to init encodr twice? > + if (ret) { > + DRM_ERROR("Failed to encoder init to drm\n"); > + return ret; > + } > + > + /* > + * Currently display data paths are statically assigned to a crtc= each. > + * crtc 0 is OVL0 -> COLOR0 -> AAL -> OD -> RDMA0 -> UFOE -> DSI0 > + */ > + dsi->encoder.possible_crtcs =3D 1; > + > + ret =3D drm_bridge_attach(&dsi->encoder, &dsi->bridge, NULL, 0); > + if (ret) > + goto err_cleanup_encoder; > + > + return 0; > + > +err_cleanup_encoder: > + drm_encoder_cleanup(&dsi->encoder); > + return ret; > +} > + > static int mtk_dsi_bind(struct device *dev, struct device *master, void = *data) > { > int ret; > @@ -1136,11 +1177,9 @@ static int mtk_dsi_bind(struct device *dev, struct= device *master, void *data) > return ret; > } > > - ret =3D mtk_dsi_create_conn_enc(drm, dsi); > - if (ret) { > - DRM_ERROR("Encoder create failed with %d\n", ret); > + ret =3D mtk_dsi_encoder_init(drm, dsi); > + if (ret) > goto err_unregister; > - } > > return 0; > > @@ -1155,7 +1194,6 @@ static void mtk_dsi_unbind(struct device *dev, stru= ct device *master, > struct drm_device *drm =3D data; > struct mtk_dsi *dsi =3D dev_get_drvdata(dev); > > - mtk_dsi_destroy_conn_enc(dsi); There is mtk_dsi_encoder_init() in bind(), why no mtk_dsi_encoder_uninit() = here? Regards, Chun-Kuang. > mtk_ddp_comp_unregister(drm, &dsi->ddp_comp); > } > > @@ -1265,6 +1303,12 @@ static int mtk_dsi_probe(struct platform_device *p= dev) > > platform_set_drvdata(pdev, dsi); > > + dsi->bridge.funcs =3D &mtk_dsi_bridge_funcs; > + dsi->bridge.of_node =3D dev->of_node; > + dsi->bridge.type =3D DRM_MODE_CONNECTOR_DSI; > + > + drm_bridge_add(&dsi->bridge); > + > ret =3D component_add(&pdev->dev, &mtk_dsi_component_ops); > if (ret) { > dev_err(&pdev->dev, "failed to add component: %d\n", ret)= ; > @@ -1283,6 +1327,7 @@ static int mtk_dsi_remove(struct platform_device *p= dev) > struct mtk_dsi *dsi =3D platform_get_drvdata(pdev); > > mtk_output_dsi_disable(dsi); > + drm_bridge_remove(&dsi->bridge); > component_del(&pdev->dev, &mtk_dsi_component_ops); > mipi_dsi_host_unregister(&dsi->host); > > -- > 2.25.1 >