* [PATCH -next] drm/mediatek: Fix Kconfig warning
@ 2020-04-20 13:50 YueHaibing
2020-04-26 8:20 ` Chun-Kuang Hu
2020-04-29 7:13 ` [PATCH v3 " YueHaibing
0 siblings, 2 replies; 9+ messages in thread
From: YueHaibing @ 2020-04-20 13:50 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg, ck.hu,
enric.balletbo
Cc: dri-devel, linux-kernel, linux-arm-kernel, linux-mediatek, YueHaibing
WARNING: unmet direct dependencies detected for MTK_MMSYS
Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n]
Selected by [y]:
- DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y]
Add missing dependcy COMMON_CLK_MT8173_MMSYS to fix this.
Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/gpu/drm/mediatek/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index c420f5a3d33b..4d9b5540de68 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -6,6 +6,7 @@ config DRM_MEDIATEK
depends on COMMON_CLK
depends on HAVE_ARM_SMCCC
depends on OF
+ depends on COMMON_CLK_MT8173_MMSYS
select DRM_GEM_CMA_HELPER
select DRM_KMS_HELPER
select DRM_MIPI_DSI
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/mediatek: Fix Kconfig warning
2020-04-20 13:50 [PATCH -next] drm/mediatek: Fix Kconfig warning YueHaibing
@ 2020-04-26 8:20 ` Chun-Kuang Hu
2020-04-28 3:17 ` [PATCH v2 -next] soc: mediatek: " YueHaibing
2020-04-28 14:55 ` [PATCH -next] drm/mediatek: " Daniel Vetter
2020-04-29 7:13 ` [PATCH v3 " YueHaibing
1 sibling, 2 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2020-04-26 8:20 UTC (permalink / raw)
To: YueHaibing
Cc: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, CK Hu, Enric Balletbo i Serra, DRI Development,
linux-kernel, Linux ARM, moderated list:ARM/Mediatek SoC support
Hi, YueHaibing:
YueHaibing <yuehaibing@huawei.com> 於 2020年4月20日 週一 下午10:04寫道：
>
> WARNING: unmet direct dependencies detected for MTK_MMSYS
> Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n]
> Selected by [y]:
> - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y]
>
> Add missing dependcy COMMON_CLK_MT8173_MMSYS to fix this.
From the code relationship, mediatek drm has relation with mediatek
mmsys, and mediatek mmsys has relation with medaitek clock.
So I think it's better that CONFIG_MTK_MMSYS select
CONFIG_COMMON_CLK_MT8173_MMSYS.
Regards,
Chun-Kuang.
>
> Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/mediatek/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index c420f5a3d33b..4d9b5540de68 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -6,6 +6,7 @@ config DRM_MEDIATEK
> depends on COMMON_CLK
> depends on HAVE_ARM_SMCCC
> depends on OF
> + depends on COMMON_CLK_MT8173_MMSYS
> select DRM_GEM_CMA_HELPER
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2 -next] soc: mediatek: Fix Kconfig warning
2020-04-26 8:20 ` Chun-Kuang Hu
@ 2020-04-28 3:17 ` YueHaibing
2020-04-28 14:55 ` [PATCH -next] drm/mediatek: " Daniel Vetter
1 sibling, 0 replies; 9+ messages in thread
From: YueHaibing @ 2020-04-28 3:17 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg, ck.hu,
enric.balletbo, yuehaibing
Cc: dri-devel, linux-kernel, linux-arm-kernel, linux-mediatek
WARNING: unmet direct dependencies detected for MTK_MMSYS
Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n]
Selected by [y]:
- DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y]
Make MTK_MMSYS select COMMON_CLK_MT8173_MMSYS to fix this.
Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v2: select COMMON_CLK_MT8173_MMSYS instead of adding DRM_MEDIATEK dependency
---
drivers/soc/mediatek/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/soc/mediatek/Kconfig b/drivers/soc/mediatek/Kconfig
index e84513318725..7f9da11e1a50 100644
--- a/drivers/soc/mediatek/Kconfig
+++ b/drivers/soc/mediatek/Kconfig
@@ -46,8 +46,7 @@ config MTK_SCPSYS
config MTK_MMSYS
bool "MediaTek MMSYS Support"
- depends on COMMON_CLK_MT8173_MMSYS
- default COMMON_CLK_MT8173_MMSYS
+ select COMMON_CLK_MT8173_MMSYS
help
Say yes here to add support for the MediaTek Multimedia
Subsystem (MMSYS).
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/mediatek: Fix Kconfig warning
2020-04-26 8:20 ` Chun-Kuang Hu
2020-04-28 3:17 ` [PATCH v2 -next] soc: mediatek: " YueHaibing
@ 2020-04-28 14:55 ` Daniel Vetter
2020-04-28 16:05 ` Chun-Kuang Hu
1 sibling, 1 reply; 9+ messages in thread
From: Daniel Vetter @ 2020-04-28 14:55 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: YueHaibing, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, CK Hu, Enric Balletbo i Serra, DRI Development,
linux-kernel, Linux ARM, moderated list:ARM/Mediatek SoC support
On Sun, Apr 26, 2020 at 04:20:39PM +0800, Chun-Kuang Hu wrote:
> Hi, YueHaibing:
>
> YueHaibing <yuehaibing@huawei.com> 於 2020年4月20日 週一 下午10:04寫道：
> >
> > WARNING: unmet direct dependencies detected for MTK_MMSYS
> > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n]
> > Selected by [y]:
> > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y]
> >
> > Add missing dependcy COMMON_CLK_MT8173_MMSYS to fix this.
>
> From the code relationship, mediatek drm has relation with mediatek
> mmsys, and mediatek mmsys has relation with medaitek clock.
> So I think it's better that CONFIG_MTK_MMSYS select
> CONFIG_COMMON_CLK_MT8173_MMSYS.
select is very strongly discouraged and should only be used for Kconfig
symbols not visible to users.
-Daniel
>
> Regards,
> Chun-Kuang.
>
> >
> > Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > drivers/gpu/drm/mediatek/Kconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> > index c420f5a3d33b..4d9b5540de68 100644
> > --- a/drivers/gpu/drm/mediatek/Kconfig
> > +++ b/drivers/gpu/drm/mediatek/Kconfig
> > @@ -6,6 +6,7 @@ config DRM_MEDIATEK
> > depends on COMMON_CLK
> > depends on HAVE_ARM_SMCCC
> > depends on OF
> > + depends on COMMON_CLK_MT8173_MMSYS
> > select DRM_GEM_CMA_HELPER
> > select DRM_KMS_HELPER
> > select DRM_MIPI_DSI
> > --
> > 2.17.1
> >
> >
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/mediatek: Fix Kconfig warning
2020-04-28 14:55 ` [PATCH -next] drm/mediatek: " Daniel Vetter
@ 2020-04-28 16:05 ` Chun-Kuang Hu
0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2020-04-28 16:05 UTC (permalink / raw)
To: Chun-Kuang Hu, YueHaibing, Philipp Zabel, David Airlie,
Matthias Brugger, CK Hu, Enric Balletbo i Serra, DRI Development,
linux-kernel, Linux ARM, moderated list:ARM/Mediatek SoC support
Cc: Daniel Vetter
Daniel Vetter <daniel@ffwll.ch> 於 2020年4月28日 週二 下午10:55寫道：
>
> On Sun, Apr 26, 2020 at 04:20:39PM +0800, Chun-Kuang Hu wrote:
> > Hi, YueHaibing:
> >
> > YueHaibing <yuehaibing@huawei.com> 於 2020年4月20日 週一 下午10:04寫道：
> > >
> > > WARNING: unmet direct dependencies detected for MTK_MMSYS
> > > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n]
> > > Selected by [y]:
> > > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y]
> > >
> > > Add missing dependcy COMMON_CLK_MT8173_MMSYS to fix this.
> >
> > From the code relationship, mediatek drm has relation with mediatek
> > mmsys, and mediatek mmsys has relation with medaitek clock.
> > So I think it's better that CONFIG_MTK_MMSYS select
> > CONFIG_COMMON_CLK_MT8173_MMSYS.
>
> select is very strongly discouraged and should only be used for Kconfig
> symbols not visible to users.
Okay, maybe the better solution is that DRM_MEDIATEK depend on MTK_MMSYS.
Regards,
Chun-Kuang.
> -Daniel
>
> >
> > Regards,
> > Chun-Kuang.
> >
> > >
> > > Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device")
> > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > > ---
> > > drivers/gpu/drm/mediatek/Kconfig | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> > > index c420f5a3d33b..4d9b5540de68 100644
> > > --- a/drivers/gpu/drm/mediatek/Kconfig
> > > +++ b/drivers/gpu/drm/mediatek/Kconfig
> > > @@ -6,6 +6,7 @@ config DRM_MEDIATEK
> > > depends on COMMON_CLK
> > > depends on HAVE_ARM_SMCCC
> > > depends on OF
> > > + depends on COMMON_CLK_MT8173_MMSYS
> > > select DRM_GEM_CMA_HELPER
> > > select DRM_KMS_HELPER
> > > select DRM_MIPI_DSI
> > > --
> > > 2.17.1
> > >
> > >
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3 -next] drm/mediatek: Fix Kconfig warning
2020-04-20 13:50 [PATCH -next] drm/mediatek: Fix Kconfig warning YueHaibing
2020-04-26 8:20 ` Chun-Kuang Hu
@ 2020-04-29 7:13 ` YueHaibing
2020-04-29 14:02 ` Enric Balletbo i Serra
2020-04-29 14:15 ` Chun-Kuang Hu
1 sibling, 2 replies; 9+ messages in thread
From: YueHaibing @ 2020-04-29 7:13 UTC (permalink / raw)
To: chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg, ck.hu,
enric.balletbo
Cc: dri-devel, linux-kernel, linux-arm-kernel, linux-mediatek,
linux-kernel, YueHaibing
WARNING: unmet direct dependencies detected for MTK_MMSYS
Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n]
Selected by [y]:
- DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y]
Make DRM_MEDIATEK depend on MTK_MMSYS to fix this.
Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
v3: make DRM_MEDIATEK depends on MTK_MMSYS
v2: select COMMON_CLK_MT8173_MMSYS instead of adding DRM_MEDIATEK dependency
---
drivers/gpu/drm/mediatek/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
index c420f5a3d33b..aa74aac3cbcc 100644
--- a/drivers/gpu/drm/mediatek/Kconfig
+++ b/drivers/gpu/drm/mediatek/Kconfig
@@ -6,12 +6,12 @@ config DRM_MEDIATEK
depends on COMMON_CLK
depends on HAVE_ARM_SMCCC
depends on OF
+ depends on MTK_MMSYS
select DRM_GEM_CMA_HELPER
select DRM_KMS_HELPER
select DRM_MIPI_DSI
select DRM_PANEL
select MEMORY
- select MTK_MMSYS
select MTK_SMI
select VIDEOMODE_HELPERS
help
--
2.17.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning
2020-04-29 7:13 ` [PATCH v3 " YueHaibing
@ 2020-04-29 14:02 ` Enric Balletbo i Serra
2020-04-29 14:15 ` Chun-Kuang Hu
1 sibling, 0 replies; 9+ messages in thread
From: Enric Balletbo i Serra @ 2020-04-29 14:02 UTC (permalink / raw)
To: YueHaibing, chunkuang.hu, p.zabel, airlied, daniel, matthias.bgg, ck.hu
Cc: linux-kernel, linux-kernel, dri-devel, linux-mediatek, linux-arm-kernel
Hi YueHaibing,
Thank you for your patch.
On 29/4/20 9:13, YueHaibing wrote:
> WARNING: unmet direct dependencies detected for MTK_MMSYS
> Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n]
> Selected by [y]:
> - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y]
>
> Make DRM_MEDIATEK depend on MTK_MMSYS to fix this.
>
> Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Definitively we shouldn't select the MTK_MMSYS and we should depend on MTK_MMSYS
instead, so
Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> v3: make DRM_MEDIATEK depends on MTK_MMSYS
> v2: select COMMON_CLK_MT8173_MMSYS instead of adding DRM_MEDIATEK dependency
> ---
> drivers/gpu/drm/mediatek/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index c420f5a3d33b..aa74aac3cbcc 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -6,12 +6,12 @@ config DRM_MEDIATEK
> depends on COMMON_CLK
> depends on HAVE_ARM_SMCCC
> depends on OF
> + depends on MTK_MMSYS
> select DRM_GEM_CMA_HELPER
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL
> select MEMORY
> - select MTK_MMSYS
> select MTK_SMI
> select VIDEOMODE_HELPERS
> help
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning
2020-04-29 7:13 ` [PATCH v3 " YueHaibing
2020-04-29 14:02 ` Enric Balletbo i Serra
@ 2020-04-29 14:15 ` Chun-Kuang Hu
2020-05-06 0:28 ` Chun-Kuang Hu
1 sibling, 1 reply; 9+ messages in thread
From: Chun-Kuang Hu @ 2020-04-29 14:15 UTC (permalink / raw)
To: YueHaibing
Cc: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, CK Hu, Enric Balletbo i Serra, DRI Development,
linux-kernel, Linux ARM, moderated list:ARM/Mediatek SoC support,
linux-kernel
Hi, YueHaibing:
YueHaibing <yuehaibing@huawei.com> 於 2020年4月29日 週三 下午3:14寫道：
>
> WARNING: unmet direct dependencies detected for MTK_MMSYS
> Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n]
> Selected by [y]:
> - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y]
>
> Make DRM_MEDIATEK depend on MTK_MMSYS to fix this.
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
> Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> v3: make DRM_MEDIATEK depends on MTK_MMSYS
> v2: select COMMON_CLK_MT8173_MMSYS instead of adding DRM_MEDIATEK dependency
> ---
> drivers/gpu/drm/mediatek/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> index c420f5a3d33b..aa74aac3cbcc 100644
> --- a/drivers/gpu/drm/mediatek/Kconfig
> +++ b/drivers/gpu/drm/mediatek/Kconfig
> @@ -6,12 +6,12 @@ config DRM_MEDIATEK
> depends on COMMON_CLK
> depends on HAVE_ARM_SMCCC
> depends on OF
> + depends on MTK_MMSYS
> select DRM_GEM_CMA_HELPER
> select DRM_KMS_HELPER
> select DRM_MIPI_DSI
> select DRM_PANEL
> select MEMORY
> - select MTK_MMSYS
> select MTK_SMI
> select VIDEOMODE_HELPERS
> help
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v3 -next] drm/mediatek: Fix Kconfig warning
2020-04-29 14:15 ` Chun-Kuang Hu
@ 2020-05-06 0:28 ` Chun-Kuang Hu
0 siblings, 0 replies; 9+ messages in thread
From: Chun-Kuang Hu @ 2020-05-06 0:28 UTC (permalink / raw)
To: Chun-Kuang Hu
Cc: YueHaibing, Philipp Zabel, David Airlie, Daniel Vetter,
Matthias Brugger, CK Hu, Enric Balletbo i Serra, DRI Development,
linux-kernel, Linux ARM, moderated list:ARM/Mediatek SoC support,
linux-kernel
Hi, YueHaibing:
Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2020年4月29日 週三 下午10:15寫道：
>
> Hi, YueHaibing:
>
> YueHaibing <yuehaibing@huawei.com> 於 2020年4月29日 週三 下午3:14寫道：
> >
> > WARNING: unmet direct dependencies detected for MTK_MMSYS
> > Depends on [n]: (ARCH_MEDIATEK [=y] || COMPILE_TEST [=n]) && COMMON_CLK_MT8173_MMSYS [=n]
> > Selected by [y]:
> > - DRM_MEDIATEK [=y] && HAS_IOMEM [=y] && DRM [=y] && (ARCH_MEDIATEK [=y] || ARM && COMPILE_TEST [=n]) && COMMON_CLK [=y] && HAVE_ARM_SMCCC [=y] && OF [=y]
> >
> > Make DRM_MEDIATEK depend on MTK_MMSYS to fix this.
>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
>
Applied to mediatek-drm-next [1], thanks.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
Regards,
Chun-Kuang.
> >
> > Fixes: 2c758e301ed9 ("soc / drm: mediatek: Move routing control to mmsys device")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> > v3: make DRM_MEDIATEK depends on MTK_MMSYS
> > v2: select COMMON_CLK_MT8173_MMSYS instead of adding DRM_MEDIATEK dependency
> > ---
> > drivers/gpu/drm/mediatek/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/Kconfig b/drivers/gpu/drm/mediatek/Kconfig
> > index c420f5a3d33b..aa74aac3cbcc 100644
> > --- a/drivers/gpu/drm/mediatek/Kconfig
> > +++ b/drivers/gpu/drm/mediatek/Kconfig
> > @@ -6,12 +6,12 @@ config DRM_MEDIATEK
> > depends on COMMON_CLK
> > depends on HAVE_ARM_SMCCC
> > depends on OF
> > + depends on MTK_MMSYS
> > select DRM_GEM_CMA_HELPER
> > select DRM_KMS_HELPER
> > select DRM_MIPI_DSI
> > select DRM_PANEL
> > select MEMORY
> > - select MTK_MMSYS
> > select MTK_SMI
> > select VIDEOMODE_HELPERS
> > help
> > --
> > 2.17.1
> >
> >
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-05-06 0:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-20 13:50 [PATCH -next] drm/mediatek: Fix Kconfig warning YueHaibing
2020-04-26 8:20 ` Chun-Kuang Hu
2020-04-28 3:17 ` [PATCH v2 -next] soc: mediatek: " YueHaibing
2020-04-28 14:55 ` [PATCH -next] drm/mediatek: " Daniel Vetter
2020-04-28 16:05 ` Chun-Kuang Hu
2020-04-29 7:13 ` [PATCH v3 " YueHaibing
2020-04-29 14:02 ` Enric Balletbo i Serra
2020-04-29 14:15 ` Chun-Kuang Hu
2020-05-06 0:28 ` Chun-Kuang Hu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).