From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE089C433DB for ; Sun, 24 Jan 2021 04:58:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FDC922CF6 for ; Sun, 24 Jan 2021 04:58:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726524AbhAXE5r (ORCPT ); Sat, 23 Jan 2021 23:57:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:45958 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726367AbhAXE5o (ORCPT ); Sat, 23 Jan 2021 23:57:44 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8BC0A22C9F; Sun, 24 Jan 2021 04:57:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611464223; bh=+Dv2W7xUrIowE8lzvyg7LMXioDkpmKs4Tk/Bc5dD3ac=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=prxBeikQt0KHNBec0XCwiIrxyhDRs5m11VZV4O+vUx9PV25en2+tYSzhelYr2OUdB 1h3PXl5DgRhk7QeQCqoO4/4k4N90VQErSruYiXtZVnp7ltNt8qn9Un+bi9BzNr/G93 mlM/GrTlw39LKBbsza6Akhjt8kCE20GnK+9rzIWRFR4X7blMBdfmgOdJCNGxhVvfEP NbbwJnLPXKa/v+Vb2XcgwdiOs05z9QduAFWc+tvgjY0XApV3g//X2Hwf1rhGgBFEBF 7v1QOOlghhLaT7xhldqbmG0/3SdTABCx1Jtm9XoAS/l0Wnr1TcXHRyQiLuc3yrjSnv 6x2UKyZAuaWVA== Received: by mail-ed1-f48.google.com with SMTP id g24so11270602edw.9; Sat, 23 Jan 2021 20:57:03 -0800 (PST) X-Gm-Message-State: AOAM531E9ozVK1F4cv+Cd6dKjF/auxBlQRuT8OwUuceNA5/t/01vmACu 9pvnP1ZsREP6MMQNTN/gVr0j2wYIUtevLpMNjw== X-Google-Smtp-Source: ABdhPJwSMImeoz+A6pH+O3PAla2mGiOTiQQ5C2GVf4VJbqxKYrHrXCj9enw3rYIbJLnELNxQr2L4gK4y4v3aX1He228= X-Received: by 2002:a50:c3c5:: with SMTP id i5mr67225edf.166.1611464222173; Sat, 23 Jan 2021 20:57:02 -0800 (PST) MIME-Version: 1.0 References: <20210122120323.4337-1-chunfeng.yun@mediatek.com> <20210122120323.4337-3-chunfeng.yun@mediatek.com> In-Reply-To: From: Chun-Kuang Hu Date: Sun, 24 Jan 2021 12:56:51 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH next v2 03/17] dt-bindings: phy: mediatek: dsi-phy: modify compatible dependence To: Chun-Kuang Hu Cc: Chunfeng Yun , Vinod Koul , Rob Herring , Greg Kroah-Hartman , Kishon Vijay Abraham I , Matthias Brugger , Philipp Zabel , Min Guo , Linux ARM , "moderated list:ARM/Mediatek SoC support" , linux-kernel , DTML , linux-usb@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Chunfeng: Chun-Kuang Hu =E6=96=BC 2021=E5=B9=B41=E6=9C=8824= =E6=97=A5 =E9=80=B1=E6=97=A5 =E4=B8=8B=E5=8D=8812:47=E5=AF=AB=E9=81=93=EF= =BC=9A > > Hi, Chunfeng: > > Chunfeng Yun =E6=96=BC 2021=E5=B9=B41=E6=9C= =8822=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8B=E5=8D=888:04=E5=AF=AB=E9=81=93= =EF=BC=9A > > > > The compatilbe "mediatek,mt7623-mipi-tx" is not supported in driver, > > and in fact uses "mediatek,mt2701-mipi-tx" instead on MT7623, so change= s > > the compatible items to make dependence clear. > > Reviewed-by: Chun-Kuang Hu Sorry, please remove my reviewed-by tag. We should not define the binding document according to the implementation of driver. We define the binding document according to the hardware. So the description should be like "mt7623-mipi-tx is compatible to mt2701-mipi-tx". Regards, Chun-Kuang. > > > > > Cc: Chun-Kuang Hu > > Cc: Philipp Zabel > > Signed-off-by: Chunfeng Yun > > --- > > v2: separate two patches suggested by CK > > --- > > .../devicetree/bindings/phy/mediatek,dsi-phy.yaml | 13 ++++++++----- > > 1 file changed, 8 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yam= l b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > > index 71d4acea1f66..6e4d795f9b02 100644 > > --- a/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > > +++ b/Documentation/devicetree/bindings/phy/mediatek,dsi-phy.yaml > > @@ -19,11 +19,14 @@ properties: > > pattern: "^dsi-phy@[0-9a-f]+$" > > > > compatible: > > - enum: > > - - mediatek,mt2701-mipi-tx > > - - mediatek,mt7623-mipi-tx > > - - mediatek,mt8173-mipi-tx > > - - mediatek,mt8183-mipi-tx > > + oneOf: > > + - items: > > + - enum: > > + - mediatek,mt7623-mipi-tx > > + - const: mediatek,mt2701-mipi-tx > > + - const: mediatek,mt2701-mipi-tx > > + - const: mediatek,mt8173-mipi-tx > > + - const: mediatek,mt8183-mipi-tx > > > > reg: > > maxItems: 1 > > -- > > 2.18.0