LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] drm/mediatek: Delete not used of_device_get_match_data
@ 2020-05-18 11:22 matthias.bgg
  2020-05-18 15:23 ` Chun-Kuang Hu
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: matthias.bgg @ 2020-05-18 11:22 UTC (permalink / raw)
  To: chunkuang.hu, p.zabel, airlied, daniel
  Cc: matthias.bgg, dri-devel, linux-arm-kernel, linux-mediatek,
	linux-kernel, enric.balletbo, Matthias Brugger

From: Matthias Brugger <matthias.bgg@gmail.com>

The driver will be loaded by via a platform device. So we
will need to get the device_node from the parent device.
Depending on this we will set the driver data.
As all this is done later already, just delete the call to
of_device_get_match_data.

Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
---
 drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
index e2bb0d19ef99..63ec92ba0e92 100644
--- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
+++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
@@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev)
 	if (!private)
 		return -ENOMEM;
 
-	private->data = of_device_get_match_data(dev);
 	private->mmsys_dev = dev->parent;
 	if (!private->mmsys_dev) {
 		dev_err(dev, "Failed to get MMSYS device\n");
-- 
2.26.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data
  2020-05-18 11:22 [PATCH] drm/mediatek: Delete not used of_device_get_match_data matthias.bgg
@ 2020-05-18 15:23 ` Chun-Kuang Hu
  2020-05-18 17:44 ` Enric Balletbo i Serra
  2020-07-04 22:19 ` Chun-Kuang Hu
  2 siblings, 0 replies; 4+ messages in thread
From: Chun-Kuang Hu @ 2020-05-18 15:23 UTC (permalink / raw)
  To: matthias.bgg
  Cc: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
	DRI Development, Linux ARM,
	moderated list:ARM/Mediatek SoC support, linux-kernel,
	Enric Balletbo i Serra, Matthias Brugger

Hi, Matthias:

<matthias.bgg@kernel.org> 於 2020年5月18日 週一 下午7:23寫道:
>
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> The driver will be loaded by via a platform device. So we
> will need to get the device_node from the parent device.
> Depending on this we will set the driver data.
> As all this is done later already, just delete the call to
> of_device_get_match_data.
>

Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index e2bb0d19ef99..63ec92ba0e92 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev)
>         if (!private)
>                 return -ENOMEM;
>
> -       private->data = of_device_get_match_data(dev);
>         private->mmsys_dev = dev->parent;
>         if (!private->mmsys_dev) {
>                 dev_err(dev, "Failed to get MMSYS device\n");
> --
> 2.26.2
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data
  2020-05-18 11:22 [PATCH] drm/mediatek: Delete not used of_device_get_match_data matthias.bgg
  2020-05-18 15:23 ` Chun-Kuang Hu
@ 2020-05-18 17:44 ` Enric Balletbo i Serra
  2020-07-04 22:19 ` Chun-Kuang Hu
  2 siblings, 0 replies; 4+ messages in thread
From: Enric Balletbo i Serra @ 2020-05-18 17:44 UTC (permalink / raw)
  To: matthias.bgg, chunkuang.hu, p.zabel, airlied, daniel
  Cc: linux-kernel, dri-devel, Matthias Brugger, linux-mediatek,
	linux-arm-kernel

Hi Matthias,

On 18/5/20 13:22, matthias.bgg@kernel.org wrote:
> From: Matthias Brugger <matthias.bgg@gmail.com>
> 
> The driver will be loaded by via a platform device. So we
> will need to get the device_node from the parent device.
> Depending on this we will set the driver data.
> As all this is done later already, just delete the call to
> of_device_get_match_data.
> 
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>

Reviewed-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>

> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index e2bb0d19ef99..63ec92ba0e92 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev)
>  	if (!private)
>  		return -ENOMEM;
>  
> -	private->data = of_device_get_match_data(dev);
>  	private->mmsys_dev = dev->parent;
>  	if (!private->mmsys_dev) {
>  		dev_err(dev, "Failed to get MMSYS device\n");
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] drm/mediatek: Delete not used of_device_get_match_data
  2020-05-18 11:22 [PATCH] drm/mediatek: Delete not used of_device_get_match_data matthias.bgg
  2020-05-18 15:23 ` Chun-Kuang Hu
  2020-05-18 17:44 ` Enric Balletbo i Serra
@ 2020-07-04 22:19 ` Chun-Kuang Hu
  2 siblings, 0 replies; 4+ messages in thread
From: Chun-Kuang Hu @ 2020-07-04 22:19 UTC (permalink / raw)
  To: matthias.bgg
  Cc: Chun-Kuang Hu, Philipp Zabel, David Airlie, Daniel Vetter,
	DRI Development, Linux ARM,
	moderated list:ARM/Mediatek SoC support, linux-kernel,
	Enric Balletbo i Serra, Matthias Brugger

Hi, Matthias:

<matthias.bgg@kernel.org> 於 2020年5月18日 週一 下午7:23寫道:
>
> From: Matthias Brugger <matthias.bgg@gmail.com>
>
> The driver will be loaded by via a platform device. So we
> will need to get the device_node from the parent device.
> Depending on this we will set the driver data.
> As all this is done later already, just delete the call to
> of_device_get_match_data.

Applied to mediatek-drm-fixes [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes

Regards,
Chun-Kuang.

>
> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> index e2bb0d19ef99..63ec92ba0e92 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
> @@ -447,7 +447,6 @@ static int mtk_drm_probe(struct platform_device *pdev)
>         if (!private)
>                 return -ENOMEM;
>
> -       private->data = of_device_get_match_data(dev);
>         private->mmsys_dev = dev->parent;
>         if (!private->mmsys_dev) {
>                 dev_err(dev, "Failed to get MMSYS device\n");
> --
> 2.26.2
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-18 11:22 [PATCH] drm/mediatek: Delete not used of_device_get_match_data matthias.bgg
2020-05-18 15:23 ` Chun-Kuang Hu
2020-05-18 17:44 ` Enric Balletbo i Serra
2020-07-04 22:19 ` Chun-Kuang Hu

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git