From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Jassi Brar <jassisinghbrar@gmail.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
CK Hu <ck.hu@mediatek.com>, HS Liao <hs.liao@mediatek.com>,
Houlong Wei <houlong.wei@mediatek.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Frank Wunderlich <frank-w@public-files.de>
Subject: Re: [PATCH v3] mailbox: mediatek: Fix handling of platform_get_irq() error
Date: Sat, 3 Oct 2020 11:26:05 +0800 [thread overview]
Message-ID: <CAAOTY_9jC2CMws-xoRgLmcHY=4f1EbLaFRkjAPsC18rrWn12jQ@mail.gmail.com> (raw)
In-Reply-To: <20200827182507.4938-1-krzk@kernel.org>
Krzysztof Kozlowski <krzk@kernel.org> 於 2020年8月28日 週五 上午2:25寫道：
>
> platform_get_irq() returns -ERRNO on error. In such case casting to u32
> and comparing to 0 would pass the check.
>
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
> Fixes: 623a6143a845 ("mailbox: mediatek: Add Mediatek CMDQ driver")
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> ---
>
> Changes since v2:
> 1. Fix subject.
>
> Changes since v1:
> 1. Correct u32->int,
> 2. Fix left-over '!'.
> ---
> drivers/mailbox/mtk-cmdq-mailbox.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 484d4438cd83..5665b6ea8119 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -69,7 +69,7 @@ struct cmdq_task {
> struct cmdq {
> struct mbox_controller mbox;
> void __iomem *base;
> - u32 irq;
> + int irq;
> u32 thread_nr;
> u32 irq_mask;
> struct cmdq_thread *thread;
> @@ -525,10 +525,8 @@ static int cmdq_probe(struct platform_device *pdev)
> }
>
> cmdq->irq = platform_get_irq(pdev, 0);
> - if (!cmdq->irq) {
> - dev_err(dev, "failed to get irq\n");
> - return -EINVAL;
> - }
> + if (cmdq->irq < 0)
> + return cmdq->irq;
>
> plat_data = (struct gce_plat *)of_device_get_match_data(dev);
> if (!plat_data) {
> --
> 2.17.1
>
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
prev parent reply other threads:[~2020-10-03 3:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 18:25 [PATCH v3] mailbox: mediatek: Fix handling of platform_get_irq() error Krzysztof Kozlowski
2020-10-02 16:30 ` Krzysztof Kozlowski
2020-10-03 3:26 ` Chun-Kuang Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAAOTY_9jC2CMws-xoRgLmcHY=4f1EbLaFRkjAPsC18rrWn12jQ@mail.gmail.com' \
--to=chunkuang.hu@kernel.org \
--cc=ck.hu@mediatek.com \
--cc=frank-w@public-files.de \
--cc=houlong.wei@mediatek.com \
--cc=hs.liao@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).