linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Collabora Kernel ML <kernel@collabora.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	Nicolas Boichat <drinkcat@chromium.org>,
	Hsin-Yi Wang <hsinyi@chromium.org>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables
Date: Sun, 5 Jul 2020 06:32:10 +0800	[thread overview]
Message-ID: <CAAOTY__YSVs5dFPSBcAfpkxZLQcc+Ky_MaO7QmCnXKXYa82=7A@mail.gmail.com> (raw)
In-Reply-To: <CAAOTY_-m67cCrrgb=Ot9gnj22Ks3qDCDFQhELMA=m0xSB9mwWQ@mail.gmail.com>

Hi, Enric:

Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2020年5月19日 週二 下午11:12寫道:
>
> Hi, Enric:
>
> Enric Balletbo i Serra <enric.balletbo@collabora.com> 於 2020年5月19日 週二 下午5:40寫道:
> >
> > There are some `static const u8` variables that are not used, this
> > triggers a warning building with `make W=1`, it is safe to remove them,
> > so do it and make the compiler more happy.
> >
>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

Applied to mediatek-drm-fixes [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes

Regards,
Chun-Kuang.

>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> >
> >  .../gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c    | 48 -------------------
> >  1 file changed, 48 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
> > index 1c3575372230..827b93786fac 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
> > @@ -107,54 +107,6 @@
> >  #define RGS_HDMITX_5T1_EDG             (0xf << 4)
> >  #define RGS_HDMITX_PLUG_TST            BIT(0)
> >
> > -static const u8 PREDIV[3][4] = {
> > -       {0x0, 0x0, 0x0, 0x0},   /* 27Mhz */
> > -       {0x1, 0x1, 0x1, 0x1},   /* 74Mhz */
> > -       {0x1, 0x1, 0x1, 0x1}    /* 148Mhz */
> > -};
> > -
> > -static const u8 TXDIV[3][4] = {
> > -       {0x3, 0x3, 0x3, 0x2},   /* 27Mhz */
> > -       {0x2, 0x1, 0x1, 0x1},   /* 74Mhz */
> > -       {0x1, 0x0, 0x0, 0x0}    /* 148Mhz */
> > -};
> > -
> > -static const u8 FBKSEL[3][4] = {
> > -       {0x1, 0x1, 0x1, 0x1},   /* 27Mhz */
> > -       {0x1, 0x0, 0x1, 0x1},   /* 74Mhz */
> > -       {0x1, 0x0, 0x1, 0x1}    /* 148Mhz */
> > -};
> > -
> > -static const u8 FBKDIV[3][4] = {
> > -       {19, 24, 29, 19},       /* 27Mhz */
> > -       {19, 24, 14, 19},       /* 74Mhz */
> > -       {19, 24, 14, 19}        /* 148Mhz */
> > -};
> > -
> > -static const u8 DIVEN[3][4] = {
> > -       {0x2, 0x1, 0x1, 0x2},   /* 27Mhz */
> > -       {0x2, 0x2, 0x2, 0x2},   /* 74Mhz */
> > -       {0x2, 0x2, 0x2, 0x2}    /* 148Mhz */
> > -};
> > -
> > -static const u8 HTPLLBP[3][4] = {
> > -       {0xc, 0xc, 0x8, 0xc},   /* 27Mhz */
> > -       {0xc, 0xf, 0xf, 0xc},   /* 74Mhz */
> > -       {0xc, 0xf, 0xf, 0xc}    /* 148Mhz */
> > -};
> > -
> > -static const u8 HTPLLBC[3][4] = {
> > -       {0x2, 0x3, 0x3, 0x2},   /* 27Mhz */
> > -       {0x2, 0x3, 0x3, 0x2},   /* 74Mhz */
> > -       {0x2, 0x3, 0x3, 0x2}    /* 148Mhz */
> > -};
> > -
> > -static const u8 HTPLLBR[3][4] = {
> > -       {0x1, 0x1, 0x0, 0x1},   /* 27Mhz */
> > -       {0x1, 0x2, 0x2, 0x1},   /* 74Mhz */
> > -       {0x1, 0x2, 0x2, 0x1}    /* 148Mhz */
> > -};
> > -
> >  static int mtk_hdmi_pll_prepare(struct clk_hw *hw)
> >  {
> >         struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw);
> > --
> > 2.26.2
> >

      reply	other threads:[~2020-07-04 22:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-19  9:40 [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables Enric Balletbo i Serra
2020-05-19 15:12 ` Chun-Kuang Hu
2020-07-04 22:32   ` Chun-Kuang Hu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAAOTY__YSVs5dFPSBcAfpkxZLQcc+Ky_MaO7QmCnXKXYa82=7A@mail.gmail.com' \
    --to=chunkuang.hu@kernel.org \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=drinkcat@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=hsinyi@chromium.org \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).