LKML Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables
@ 2020-05-19  9:40 Enric Balletbo i Serra
  2020-05-19 15:12 ` Chun-Kuang Hu
  0 siblings, 1 reply; 3+ messages in thread
From: Enric Balletbo i Serra @ 2020-05-19  9:40 UTC (permalink / raw)
  To: linux-kernel
  Cc: Collabora Kernel ML, matthias.bgg, drinkcat, hsinyi,
	Chun-Kuang Hu, Daniel Vetter, David Airlie, Philipp Zabel,
	dri-devel, linux-arm-kernel, linux-mediatek

There are some `static const u8` variables that are not used, this
triggers a warning building with `make W=1`, it is safe to remove them,
so do it and make the compiler more happy.

Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---

 .../gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c    | 48 -------------------
 1 file changed, 48 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
index 1c3575372230..827b93786fac 100644
--- a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
+++ b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
@@ -107,54 +107,6 @@
 #define RGS_HDMITX_5T1_EDG		(0xf << 4)
 #define RGS_HDMITX_PLUG_TST		BIT(0)
 
-static const u8 PREDIV[3][4] = {
-	{0x0, 0x0, 0x0, 0x0},	/* 27Mhz */
-	{0x1, 0x1, 0x1, 0x1},	/* 74Mhz */
-	{0x1, 0x1, 0x1, 0x1}	/* 148Mhz */
-};
-
-static const u8 TXDIV[3][4] = {
-	{0x3, 0x3, 0x3, 0x2},	/* 27Mhz */
-	{0x2, 0x1, 0x1, 0x1},	/* 74Mhz */
-	{0x1, 0x0, 0x0, 0x0}	/* 148Mhz */
-};
-
-static const u8 FBKSEL[3][4] = {
-	{0x1, 0x1, 0x1, 0x1},	/* 27Mhz */
-	{0x1, 0x0, 0x1, 0x1},	/* 74Mhz */
-	{0x1, 0x0, 0x1, 0x1}	/* 148Mhz */
-};
-
-static const u8 FBKDIV[3][4] = {
-	{19, 24, 29, 19},	/* 27Mhz */
-	{19, 24, 14, 19},	/* 74Mhz */
-	{19, 24, 14, 19}	/* 148Mhz */
-};
-
-static const u8 DIVEN[3][4] = {
-	{0x2, 0x1, 0x1, 0x2},	/* 27Mhz */
-	{0x2, 0x2, 0x2, 0x2},	/* 74Mhz */
-	{0x2, 0x2, 0x2, 0x2}	/* 148Mhz */
-};
-
-static const u8 HTPLLBP[3][4] = {
-	{0xc, 0xc, 0x8, 0xc},	/* 27Mhz */
-	{0xc, 0xf, 0xf, 0xc},	/* 74Mhz */
-	{0xc, 0xf, 0xf, 0xc}	/* 148Mhz */
-};
-
-static const u8 HTPLLBC[3][4] = {
-	{0x2, 0x3, 0x3, 0x2},	/* 27Mhz */
-	{0x2, 0x3, 0x3, 0x2},	/* 74Mhz */
-	{0x2, 0x3, 0x3, 0x2}	/* 148Mhz */
-};
-
-static const u8 HTPLLBR[3][4] = {
-	{0x1, 0x1, 0x0, 0x1},	/* 27Mhz */
-	{0x1, 0x2, 0x2, 0x1},	/* 74Mhz */
-	{0x1, 0x2, 0x2, 0x1}	/* 148Mhz */
-};
-
 static int mtk_hdmi_pll_prepare(struct clk_hw *hw)
 {
 	struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw);
-- 
2.26.2


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables
  2020-05-19  9:40 [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables Enric Balletbo i Serra
@ 2020-05-19 15:12 ` Chun-Kuang Hu
  2020-07-04 22:32   ` Chun-Kuang Hu
  0 siblings, 1 reply; 3+ messages in thread
From: Chun-Kuang Hu @ 2020-05-19 15:12 UTC (permalink / raw)
  To: Enric Balletbo i Serra
  Cc: linux-kernel, Collabora Kernel ML, Matthias Brugger,
	Nicolas Boichat, Hsin-Yi Wang, Chun-Kuang Hu, Daniel Vetter,
	David Airlie, Philipp Zabel, DRI Development, Linux ARM,
	moderated list:ARM/Mediatek SoC support

Hi, Enric:

Enric Balletbo i Serra <enric.balletbo@collabora.com> 於 2020年5月19日 週二 下午5:40寫道:
>
> There are some `static const u8` variables that are not used, this
> triggers a warning building with `make W=1`, it is safe to remove them,
> so do it and make the compiler more happy.
>

Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
>
>  .../gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c    | 48 -------------------
>  1 file changed, 48 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
> index 1c3575372230..827b93786fac 100644
> --- a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
> +++ b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
> @@ -107,54 +107,6 @@
>  #define RGS_HDMITX_5T1_EDG             (0xf << 4)
>  #define RGS_HDMITX_PLUG_TST            BIT(0)
>
> -static const u8 PREDIV[3][4] = {
> -       {0x0, 0x0, 0x0, 0x0},   /* 27Mhz */
> -       {0x1, 0x1, 0x1, 0x1},   /* 74Mhz */
> -       {0x1, 0x1, 0x1, 0x1}    /* 148Mhz */
> -};
> -
> -static const u8 TXDIV[3][4] = {
> -       {0x3, 0x3, 0x3, 0x2},   /* 27Mhz */
> -       {0x2, 0x1, 0x1, 0x1},   /* 74Mhz */
> -       {0x1, 0x0, 0x0, 0x0}    /* 148Mhz */
> -};
> -
> -static const u8 FBKSEL[3][4] = {
> -       {0x1, 0x1, 0x1, 0x1},   /* 27Mhz */
> -       {0x1, 0x0, 0x1, 0x1},   /* 74Mhz */
> -       {0x1, 0x0, 0x1, 0x1}    /* 148Mhz */
> -};
> -
> -static const u8 FBKDIV[3][4] = {
> -       {19, 24, 29, 19},       /* 27Mhz */
> -       {19, 24, 14, 19},       /* 74Mhz */
> -       {19, 24, 14, 19}        /* 148Mhz */
> -};
> -
> -static const u8 DIVEN[3][4] = {
> -       {0x2, 0x1, 0x1, 0x2},   /* 27Mhz */
> -       {0x2, 0x2, 0x2, 0x2},   /* 74Mhz */
> -       {0x2, 0x2, 0x2, 0x2}    /* 148Mhz */
> -};
> -
> -static const u8 HTPLLBP[3][4] = {
> -       {0xc, 0xc, 0x8, 0xc},   /* 27Mhz */
> -       {0xc, 0xf, 0xf, 0xc},   /* 74Mhz */
> -       {0xc, 0xf, 0xf, 0xc}    /* 148Mhz */
> -};
> -
> -static const u8 HTPLLBC[3][4] = {
> -       {0x2, 0x3, 0x3, 0x2},   /* 27Mhz */
> -       {0x2, 0x3, 0x3, 0x2},   /* 74Mhz */
> -       {0x2, 0x3, 0x3, 0x2}    /* 148Mhz */
> -};
> -
> -static const u8 HTPLLBR[3][4] = {
> -       {0x1, 0x1, 0x0, 0x1},   /* 27Mhz */
> -       {0x1, 0x2, 0x2, 0x1},   /* 74Mhz */
> -       {0x1, 0x2, 0x2, 0x1}    /* 148Mhz */
> -};
> -
>  static int mtk_hdmi_pll_prepare(struct clk_hw *hw)
>  {
>         struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw);
> --
> 2.26.2
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables
  2020-05-19 15:12 ` Chun-Kuang Hu
@ 2020-07-04 22:32   ` Chun-Kuang Hu
  0 siblings, 0 replies; 3+ messages in thread
From: Chun-Kuang Hu @ 2020-07-04 22:32 UTC (permalink / raw)
  To: Chun-Kuang Hu
  Cc: Enric Balletbo i Serra, linux-kernel, Collabora Kernel ML,
	Matthias Brugger, Nicolas Boichat, Hsin-Yi Wang, Daniel Vetter,
	David Airlie, Philipp Zabel, DRI Development, Linux ARM,
	moderated list:ARM/Mediatek SoC support

Hi, Enric:

Chun-Kuang Hu <chunkuang.hu@kernel.org> 於 2020年5月19日 週二 下午11:12寫道:
>
> Hi, Enric:
>
> Enric Balletbo i Serra <enric.balletbo@collabora.com> 於 2020年5月19日 週二 下午5:40寫道:
> >
> > There are some `static const u8` variables that are not used, this
> > triggers a warning building with `make W=1`, it is safe to remove them,
> > so do it and make the compiler more happy.
> >
>
> Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>

Applied to mediatek-drm-fixes [1], thanks.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-fixes

Regards,
Chun-Kuang.

>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> >
> >  .../gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c    | 48 -------------------
> >  1 file changed, 48 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
> > index 1c3575372230..827b93786fac 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_mt8173_hdmi_phy.c
> > @@ -107,54 +107,6 @@
> >  #define RGS_HDMITX_5T1_EDG             (0xf << 4)
> >  #define RGS_HDMITX_PLUG_TST            BIT(0)
> >
> > -static const u8 PREDIV[3][4] = {
> > -       {0x0, 0x0, 0x0, 0x0},   /* 27Mhz */
> > -       {0x1, 0x1, 0x1, 0x1},   /* 74Mhz */
> > -       {0x1, 0x1, 0x1, 0x1}    /* 148Mhz */
> > -};
> > -
> > -static const u8 TXDIV[3][4] = {
> > -       {0x3, 0x3, 0x3, 0x2},   /* 27Mhz */
> > -       {0x2, 0x1, 0x1, 0x1},   /* 74Mhz */
> > -       {0x1, 0x0, 0x0, 0x0}    /* 148Mhz */
> > -};
> > -
> > -static const u8 FBKSEL[3][4] = {
> > -       {0x1, 0x1, 0x1, 0x1},   /* 27Mhz */
> > -       {0x1, 0x0, 0x1, 0x1},   /* 74Mhz */
> > -       {0x1, 0x0, 0x1, 0x1}    /* 148Mhz */
> > -};
> > -
> > -static const u8 FBKDIV[3][4] = {
> > -       {19, 24, 29, 19},       /* 27Mhz */
> > -       {19, 24, 14, 19},       /* 74Mhz */
> > -       {19, 24, 14, 19}        /* 148Mhz */
> > -};
> > -
> > -static const u8 DIVEN[3][4] = {
> > -       {0x2, 0x1, 0x1, 0x2},   /* 27Mhz */
> > -       {0x2, 0x2, 0x2, 0x2},   /* 74Mhz */
> > -       {0x2, 0x2, 0x2, 0x2}    /* 148Mhz */
> > -};
> > -
> > -static const u8 HTPLLBP[3][4] = {
> > -       {0xc, 0xc, 0x8, 0xc},   /* 27Mhz */
> > -       {0xc, 0xf, 0xf, 0xc},   /* 74Mhz */
> > -       {0xc, 0xf, 0xf, 0xc}    /* 148Mhz */
> > -};
> > -
> > -static const u8 HTPLLBC[3][4] = {
> > -       {0x2, 0x3, 0x3, 0x2},   /* 27Mhz */
> > -       {0x2, 0x3, 0x3, 0x2},   /* 74Mhz */
> > -       {0x2, 0x3, 0x3, 0x2}    /* 148Mhz */
> > -};
> > -
> > -static const u8 HTPLLBR[3][4] = {
> > -       {0x1, 0x1, 0x0, 0x1},   /* 27Mhz */
> > -       {0x1, 0x2, 0x2, 0x1},   /* 74Mhz */
> > -       {0x1, 0x2, 0x2, 0x1}    /* 148Mhz */
> > -};
> > -
> >  static int mtk_hdmi_pll_prepare(struct clk_hw *hw)
> >  {
> >         struct mtk_hdmi_phy *hdmi_phy = to_mtk_hdmi_phy(hw);
> > --
> > 2.26.2
> >

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19  9:40 [PATCH] drm/mediatek: mtk_mt8173_hdmi_phy: Remove unnused const variables Enric Balletbo i Serra
2020-05-19 15:12 ` Chun-Kuang Hu
2020-07-04 22:32   ` Chun-Kuang Hu

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git
	git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org
	public-inbox-index lkml

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git