From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7847EC6377A for ; Thu, 22 Jul 2021 00:42:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 45F6E61249 for ; Thu, 22 Jul 2021 00:42:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229911AbhGVACS (ORCPT ); Wed, 21 Jul 2021 20:02:18 -0400 Received: from mail.kernel.org ([198.145.29.99]:44298 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229692AbhGVACQ (ORCPT ); Wed, 21 Jul 2021 20:02:16 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CE83061264 for ; Thu, 22 Jul 2021 00:42:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626914572; bh=5gUuCHYoyXnxCTWjadK1ob5ANKNp6RQJVZAT7k9rS0o=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=FYHaJgCwwBDQfKT43ZcZrVpiPXWAlknCbCDxwcwgOkS3OV8dfY5fbxqlE9xftqXFn QYFKzhtAgo2xkQSyuN0UtgqJMgtyyb8RX9M4ECyz9a7x0y+Mk7ylts6oCUVc64H6BE 4Evov4uuMQEhK40iWmj0oPxH0RbnxKdw8h0SZaB2IjvC1nIHjfwc/2XGT/KfZNzfyA gc9tcVs/52Qxaw1x5j6MsmoTOvuoXeihwyQNj4A8qkLUCXeIbzL7X7/GWMktU0sc7z GyhMvv9zdIKPjJxW71g9Id+XQ8RKvCVL6g3AuuCXgd0e+v+qj/bvtzaiZVZAtNh25o r7/+87x19VhNQ== Received: by mail-ej1-f41.google.com with SMTP id c17so5863126ejk.13 for ; Wed, 21 Jul 2021 17:42:52 -0700 (PDT) X-Gm-Message-State: AOAM532ularUXSoy9E0TcPKiBOr4gSS3FfrCpkhoGBsA3GwrbgFsa1bg ZQZjLAFSWShh87EchFGIWeSWWQJIeESemejAmg== X-Google-Smtp-Source: ABdhPJyKf32KGYOx7/x5mSfSzBsftSabCd3owtHAjkGVEslJ3jlOd7OwePiukXqfZBwKpfVyyVggxJVBTrUCUsVgD+I= X-Received: by 2002:a17:906:27da:: with SMTP id k26mr41548451ejc.267.1626914571435; Wed, 21 Jul 2021 17:42:51 -0700 (PDT) MIME-Version: 1.0 References: <20210712080736.116435-1-linux@fw-web.de> In-Reply-To: <20210712080736.116435-1-linux@fw-web.de> From: Chun-Kuang Hu Date: Thu, 22 Jul 2021 08:42:40 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] drm/mediatek: dpi: fix NULL dereference in mtk_dpi_bridge_atomic_check To: Frank Wunderlich Cc: "moderated list:ARM/Mediatek SoC support" , Frank Wunderlich , Chun-Kuang Hu , Philipp Zabel , David Airlie , Daniel Vetter , Matthias Brugger , Jitao Shi , Rex-BC Chen , DRI Development , Linux ARM , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Frank: Frank Wunderlich =E6=96=BC 2021=E5=B9=B47=E6=9C=8812=E6= =97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=884:08=E5=AF=AB=E9=81=93=EF=BC=9A > > From: Frank Wunderlich > > bridge->driver_private is not set (NULL) so use bridge_to_dpi(bridge) > like it's done in bridge_atomic_get_output_bus_fmts Applied to mediatek-drm-fixes [1], thanks. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/= log/?h=3Dmediatek-drm-fixes Regards, Chun-Kuang. > > Fixes: ec8747c52434 ("drm/mediatek: dpi: Add bus format negotiation") > Signed-off-by: Frank Wunderlich > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediate= k/mtk_dpi.c > index bced555648b0..a2eca1f66984 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -605,7 +605,7 @@ static int mtk_dpi_bridge_atomic_check(struct drm_bri= dge *bridge, > struct drm_crtc_state *crtc_state, > struct drm_connector_state *conn_s= tate) > { > - struct mtk_dpi *dpi =3D bridge->driver_private; > + struct mtk_dpi *dpi =3D bridge_to_dpi(bridge); > unsigned int out_bus_format; > > out_bus_format =3D bridge_state->output_bus_cfg.format; > -- > 2.25.1 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek